Skip to content

feat: restrict available actions on a Drive file - WPB-25616#4869

Open
jullianm wants to merge 10 commits into
developfrom
feat/restrict-available-actions-on-file
Open

feat: restrict available actions on a Drive file - WPB-25616#4869
jullianm wants to merge 10 commits into
developfrom
feat/restrict-available-actions-on-file

Conversation

@jullianm

@jullianm jullianm commented Jun 15, 2026

Copy link
Copy Markdown
Contributor
TaskWPB-25616 [iOS] Viewer-mode: restrict available actions on a file

Issue

This PR hides some actions on a file when the user is in viewer mode.

Testing

  • Have 2 Drive conversations where self user is a guest and one where he's not.
  • Open shared drive screen on each conversation: observe that in viewer mode, only two actions are available (open and make/remove available offline)
  • On a drive conversation where self is a guest, the nav bar trailing "ellipsis" button (more actions) should not be visible.
  • Open Drive tab, observe that the same limited actions are available (in this screen, "share" is disabled and grayed out)
  • Ensure that, in editor mode, all available actions are visible (see PROD version to compare these available actions)

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@jullianm jullianm requested review from a team, caldrian and netbe and removed request for a team June 15, 2026 15:29
@github-actions

github-actions Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Test Results

307 tests   307 ✅  17s ⏱️
 61 suites    0 💤
  1 files      0 ❌

Results for commit 72536b2.

♻️ This comment has been updated with latest results.

Summary: workflow run #27937038300
Allure report (download zip): html-report-30969-feat_restrict-available-actions-on-file

@netbe netbe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, left a question though

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants