feat: restrict available actions on a Drive file - WPB-25616

WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/FilesView.swift

@@ -98,7 +98,7 @@ private extension FilesView {
             }
         }
 
-        if !viewModel.isRecycleBin, !viewModel.isOffline {
+        if showMoreActionsButton {
             ToolbarItem(placement: .navigationBarTrailing) {
                 moreActionsButton
             }
@@ -120,6 +120,10 @@ private extension FilesView {
         }
     }
 
+    var showMoreActionsButton: Bool {
+        !viewModel.isRecycleBin && !viewModel.isOffline && viewModel.selfUserRole == .editor
+    }
+
     var closeButton: some View {
         Button(
             action: { onDismissContainer() },

WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/FilesViewModel.swift

@@ -79,6 +79,10 @@ package final class FilesViewModel: ObservableObject {
     // TODO: [WPB-25941] Remove drive permissions flag when feature is complete
     var isDrivePermissionsFlagEnabled: Bool = UserDefaults.standard.bool(forKey: "enableDrivePermissions")
 
+    var selfUserRole: WireDriveConversation.Participant.Role {
+        selfUser?.role ?? .viewer
+    }
+
     var navigationTitle: String {
         if let title {
             title
@@ -94,7 +98,7 @@ package final class FilesViewModel: ObservableObject {
     }
 
     var navigationSubtitle: String? {
-        if let selfUser, selfUser.role == .viewer, !isBrowsing, isDrivePermissionsFlagEnabled {
+        if selfUserRole == .viewer, !isBrowsing, isDrivePermissionsFlagEnabled {
             Strings.Files.ViewerAccess.navigationSubtitle
         } else {
             nil

WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Item/FilesItemView.swift

@@ -275,7 +275,7 @@ struct FilesItemView: View {
                     Strings.Files.Item.Menu.shareLink,
                     systemImage: "square.and.arrow.up"
                 )
-            }
+            }.disabled(viewModel.disableShareLinkButton)
         }
 
         menuItem(.makeAvailableOffline) { item in

WireMessaging/Sources/WireMessagingUI/WireDrive/Components/Files/Item/FilesItemViewModel.swift

@@ -80,6 +80,10 @@
         isDrivePermissionsFlagEnabled && item.isReadOnly && isBrowsing
     }
 
+    var disableShareLinkButton: Bool {
+        isDrivePermissionsFlagEnabled && item.isReadOnly && isBrowsing
+    }
+
     struct TagsInfo {
         let firstTag: String?
         let additionalTagsIndicator: String?
@@ -243,6 +247,120 @@
         }
     #endif
 
+    var isOffline: Bool {
+        networkMonitor.currentStatus == .disconnected
+    }
+
+    var tagsInfo: TagsInfo {
+        let additionalTags = item.tags.count - 1
+        let formattedNumber: String? = if additionalTags > 0 {
+            additionalTagNumberFormatter.string(for: additionalTags) ?? "+\(additionalTags)"
+        } else {
+            nil
+        }
+        return .init(
+            firstTag: item.tags.sortedAlphabetically.first,
+            additionalTagsIndicator: formattedNumber
+        )
+    }
+
+    var menuActions: Set<ItemAction> {
+        let isViewerMode = item.isReadOnly && isDrivePermissionsFlagEnabled
+
+        if isViewerMode {
+            return viewerMenuActions
+        } else {
+            return editorMenuActions
+        }
+
+    }
+
+    private var viewerMenuActions: Set<ItemAction> {
+        var actions: Set<ItemAction> = []
+
+        if !isInRecycleBin {
+            actions.insert(.primaryAction)
+
+            if !isOffline, isBrowsing {
+                actions.insert(.shareLink)
+            }
+        }
+
+        if !isEditable, !isInRecycleBin, item.kind == .file {
+            if isAvailableOffline {
+                actions.insert(.removeAvailableOffline)
+            } else {
+                if !isOffline {
+                    actions.insert(.makeAvailableOffline)
+                }
+            }
+        }
+
+        return actions
+    }
+
+    private var editorMenuActions: Set<ItemAction> {
+        var actions: Set<ItemAction> = []
+
+        if !isInRecycleBin {
+            actions.insert(.primaryAction)
+
+            if !isOffline {
+                actions.insert(.shareLink)
+            }
+        }
+
+        if !isEditable, !isInRecycleBin, item.kind == .file {
+            if isAvailableOffline {
+                actions.insert(.removeAvailableOffline)
+            } else {
+                if !isOffline {
+                    actions.insert(.makeAvailableOffline)
+                }
+            }
+        }
+
+        if !isBrowsing, !isOffline {
+            if isInRecycleBin {
+                actions.formUnion([.restore, .deletePermanently])
+            } else {
+                if item.kind == .file, isEditable {
+                    actions.insert(.showVersionHistory)
+                }
+                actions.formUnion([
+                    .moveToFolder,
+                    .rename,
+                    .editTags,
+                    .deleteToRecycleBin
+                ])
+
+                if isEditable {
+                    actions.insert(.edit)
+                }
+            }
+        }
+
+        return actions
+    }
+
+    var isAvailableOffline: Bool {
+        let isAvailableOffline = (try? localAssetRepository.asset(nodeID: nodeID)?.isAvailableOffline) ?? false
+        let isDownloaded = switch fileTracker.state {
+        case .loaded:
+            true
+        default:
+            false
+        }
+
+        let isFolder = item.kind == .folder
+
+        return isAvailableOffline && isDownloaded && !isFolder
+    }
+}
+
+// MARK: - Formatting
+
+private extension FilesItemViewModel {
     private static func subtitle(
         selectedSortingKey: FilesSortingViewModel.SortingKey?,
         isBrowsing: Bool,
@@ -361,80 +479,6 @@
             }
         }
     }
-
-    var tagsInfo: TagsInfo {
-        let additionalTags = item.tags.count - 1
-        let formattedNumber: String? = if additionalTags > 0 {
-            additionalTagNumberFormatter.string(for: additionalTags) ?? "+\(additionalTags)"
-        } else {
-            nil
-        }
-        return .init(
-            firstTag: item.tags.sortedAlphabetically.first,
-            additionalTagsIndicator: formattedNumber
-        )
-    }
-
-    var isOffline: Bool {
-        networkMonitor.currentStatus == .disconnected
-    }
-
-    var menuActions: Set<ItemAction> {
-        var actions: Set<ItemAction> = []
-
-        if !isInRecycleBin {
-            actions.insert(.primaryAction)
-
-            if !isOffline {
-                actions.insert(.shareLink)
-            }
-        }
-
-        if !isEditable, !isInRecycleBin, item.kind == .file {
-            if isAvailableOffline {
-                actions.insert(.removeAvailableOffline)
-            } else {
-                if !isOffline {
-                    actions.insert(.makeAvailableOffline)
-                }
-            }
-        }
-
-        if !isBrowsing, !isOffline {
-            if isInRecycleBin {
-                actions.insert(.restore)
-                actions.insert(.deletePermanently)
-            } else {
-                if item.kind == .file, isEditable {
-                    actions.insert(.showVersionHistory)
-                }
-                actions.insert(.moveToFolder)
-                actions.insert(.rename)
-                actions.insert(.editTags)
-                actions.insert(.deleteToRecycleBin)
-
-                if isEditable {
-                    actions.insert(.edit)
-                }
-            }
-        }
-
-        return actions
-    }
-
-    var isAvailableOffline: Bool {
-        let isAvailableOffline = (try? localAssetRepository.asset(nodeID: nodeID)?.isAvailableOffline) ?? false
-        let isDownloaded = switch fileTracker.state {
-        case .loaded:
-            true
-        default:
-            false
-        }
-
-        let isFolder = item.kind == .folder
-
-        return isAvailableOffline && isDownloaded && !isFolder
-    }
 }
 
 private extension [String] {

WireMessaging/Tests/WireMessagingTests/WireDrive/UITests/Components/Files/FilesViewTests.swift

@@ -95,10 +95,7 @@ final class FilesViewTests: XCTestCase {
             editingURLRepository: editingURLRepository
         )
 
-        nodesApi.getDriveConversations_MockValue = [
-            .mocked(),
-            .mocked()
-        ]
+        nodesApi.getDriveConversations_MockValue = .mocked(selfUserRole: .editor)
 
         driveConversationsUseCase = WireDriveGetConversationsUseCase(nodesAPI: nodesApi)
 
@@ -317,7 +314,7 @@ final class FilesViewTests: XCTestCase {
 
     @MainActor
     func testFilesView_LoadingState() async {
-        let view = makeFilesView(state: .loading)
+        let view = await makeFilesView(state: .loading)
 
         snapshotHelper
             .withUserInterfaceStyle(.light)
@@ -329,7 +326,7 @@ final class FilesViewTests: XCTestCase {
 
     @MainActor
     func testFilesView_NoDataState() async {
-        let view = makeFilesView(state: .received(items: []))
+        let view = await makeFilesView(state: .received(items: []))
 
         snapshotHelper
             .withUserInterfaceStyle(.light)
@@ -341,7 +338,7 @@ final class FilesViewTests: XCTestCase {
 
     @MainActor
     func testFilesView_PendingState() async {
-        let view = makeFilesView(state: .pending)
+        let view = await makeFilesView(state: .pending)
 
         snapshotHelper
             .withUserInterfaceStyle(.light)
@@ -353,7 +350,7 @@ final class FilesViewTests: XCTestCase {
 
     @MainActor
     func testFilesView_ErrorState() async {
-        let view = makeFilesView(state: .error(isConnectionError: false))
+        let view = await makeFilesView(state: .error(isConnectionError: false))
 
         snapshotHelper
             .withUserInterfaceStyle(.light)
@@ -364,9 +361,16 @@ final class FilesViewTests: XCTestCase {
     }
 
     @MainActor
-    func testFilesView_ViewerOnlyBanner() async {
-        let view = makeFilesView(state: .received(items: []), isReadOnly: true)
+    func testFilesView_ViewerOnly() async {
+        // Given
+        let nodesApi = MockNodesAPIProtocol()
+        nodesApi.getDriveConversations_MockValue = .mocked(selfUserRole: .viewer)
+        driveConversationsUseCase = WireDriveGetConversationsUseCase(nodesAPI: nodesApi)
 
+        // When
+        let view = await makeFilesView(state: .received(items: []), isReadOnly: true)
+
+        // Then
         snapshotHelper
             .withUserInterfaceStyle(.light)
             .verify(matching: view, named: "light", record: record)
@@ -405,7 +409,7 @@ final class FilesViewTests: XCTestCase {
         state: FilesListStateController.State,
         isBrowsing: Bool = false,
         isReadOnly: Bool = false
-    ) -> some View {
+    ) async -> some View {
         let filesViewModel = FilesViewModel(
             useCases: .init(
                 fetchNodes: fetchNodesUseCase,
@@ -448,6 +452,8 @@ final class FilesViewTests: XCTestCase {
             networkMonitor: networkMonitor
         )
 
+        await filesViewModel.setup()
+
         filesViewModel.filesController.state = state
         filesViewModel.filesController.hasMore = false
         filesViewModel.showReadOnlyBanner = isReadOnly