Skip to content

fix: detect remote static attachments in chat#1794

Open
giwaov wants to merge 2 commits into
xmtp:mainfrom
giwaov:fix-remote-attachment-detection
Open

fix: detect remote static attachments in chat#1794
giwaov wants to merge 2 commits into
xmtp:mainfrom
giwaov:fix-remote-attachment-detection

Conversation

@giwaov

@giwaov giwaov commented May 12, 2026

Copy link
Copy Markdown

Summary

  • fix xmtp.chat remote attachment detection to use the canonical
    emoteStaticAttachment\ content type
  • add regression coverage so remote static attachments remain actionable

Fixes #1463

Testing

  • git diff --check
  • git diff --cached --check
  • Not run: \yarn workspace @xmtp/xmtp.chat test apps/xmtp.chat/src/helpers/messages.test.ts\ because Yarn reports the checkout is missing its node_modules state file; prior \yarn install --immutable\ attempts in this checkout hung before creating
    ode_modules.

Note

Fix isRemoteAttachment to detect remote static attachments in chat

Corrects a typo in messages.ts where the contentType.typeId was compared against 'staticRemoteAttachment' instead of the correct value 'remoteStaticAttachment'. Adds a test to verify that isRemoteAttachment and isActionable both return true for a properly constructed remote attachment message.

Macroscope summarized deb8517.

@giwaov giwaov requested a review from a team as a code owner May 12, 2026 16:11
@changeset-bot

changeset-bot Bot commented May 12, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: deb8517

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@giwaov giwaov requested a review from a team as a code owner May 12, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error Collection: Unable to load attachment

1 participant