Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sour-jobs-share.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@xmtp/xmtp.chat": patch
---

fix: detect remote static attachments in chat
26 changes: 25 additions & 1 deletion apps/xmtp.chat/src/helpers/messages.test.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
contentTypeReaction,
contentTypeRemoteAttachment,
contentTypeReply,
contentTypeText,
DeliveryStatus,
Expand All @@ -9,10 +10,11 @@ import {
type DecodedMessage,
type EnrichedReply,
type Reaction,
type RemoteAttachment,
} from "@xmtp/browser-sdk";
import { type ContentTypeId } from "@xmtp/content-type-primitives";
import { describe, expect, it } from "vitest";
import { stringify } from "./messages";
import { isActionable, isRemoteAttachment, stringify } from "./messages";

const createDecodedMessage = <T>(
content: T,
Expand Down Expand Up @@ -98,3 +100,25 @@ describe("stringify", () => {
expect(stringify(decodedMessage)).toBe(fallback);
});
});

describe("isRemoteAttachment", () => {
it("recognizes remote static attachment messages", async () => {
const content: RemoteAttachment = {
contentDigest: "digest",
contentLength: 42,
filename: "image.png",
nonce: new Uint8Array([1]),
salt: new Uint8Array([2]),
secret: new Uint8Array([3]),
scheme: "https://",
url: "https://example.com/image.png",
};
const decodedMessage = createDecodedMessage(
content,
await contentTypeRemoteAttachment(),
);

expect(isRemoteAttachment(decodedMessage)).toBe(true);
expect(isActionable(decodedMessage)).toBe(true);
});
});
2 changes: 1 addition & 1 deletion apps/xmtp.chat/src/helpers/messages.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export const isText = (m: DecodedMessage): m is DecodedMessage<string> =>
export const isRemoteAttachment = (
m: DecodedMessage,
): m is DecodedMessage<RemoteAttachment> =>
m.contentType.typeId === "staticRemoteAttachment";
m.contentType.typeId === "remoteStaticAttachment";

export const stringify = (message: DecodedMessage): string => {
switch (true) {
Expand Down