Skip to content

fix: Clippy warnings: string formatting, match arms, unused imports, … - #24

Merged
yonas merged 1 commit into
mainfrom
fix/clippy
Feb 1, 2026
Merged

fix: Clippy warnings: string formatting, match arms, unused imports, …#24
yonas merged 1 commit into
mainfrom
fix/clippy

fix: Clippy warnings: string formatting, match arms, unused imports, …

6fbeed4
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
GitHub Actions / Clippy Output succeeded Feb 1, 2026 in 5s

Clippy Output

332 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 332
Note 0
Help 0

Versions

  • rustc 1.93.0 (254b59607 2026-01-19)
  • cargo 1.93.0 (083ac5135 2025-12-15)
  • clippy 0.1.93 (254b59607d 2026-01-19)

Annotations

Check warning on line 249 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

struct pattern is not needed for a unit variant 

warning: struct pattern is not needed for a unit variant
   --> backpack/cli/src/main.rs:249:24
    |
249 |         Commands::Hello {} => {
    |                        ^^^ help: remove the struct pattern
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#unneeded_struct_pattern
    = note: `-W clippy::unneeded-struct-pattern` implied by `-W clippy::all`
    = help: to override `-W clippy::all` add `#[allow(clippy::unneeded_struct_pattern)]`

Check warning on line 74 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

adding items after statements is confusing, since items exist from the start of the scope 

warning: adding items after statements is confusing, since items exist from the start of the scope
  --> backpack/cli/src/main.rs:74:5
   |
74 |     const PROJECT_DESC: &str = env!("CARGO_PKG_DESCRIPTION");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements

Check warning on line 73 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

adding items after statements is confusing, since items exist from the start of the scope 

warning: adding items after statements is confusing, since items exist from the start of the scope
  --> backpack/cli/src/main.rs:73:5
   |
73 |     const PROJECT_NAME: &str = env!("CARGO_PKG_NAME");
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#items_after_statements
   = note: `-W clippy::items-after-statements` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::items_after_statements)]`

Check warning on line 16 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this function has too many lines (162/100) 

warning: this function has too many lines (162/100)
  --> backpack/cli/src/main.rs:16:7
   |
16 | async fn main() -> anyhow::Result<()> {
   |       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#too_many_lines
   = note: `-W clippy::too-many-lines` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::too_many_lines)]`

Check warning on line 12 in backpack/cli/src/commands/merge/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this argument is passed by value, but not consumed in the function body 

warning: this argument is passed by value, but not consumed in the function body
  --> backpack/cli/src/commands/merge/mod.rs:12:18
   |
12 | pub fn run(repo: String) -> anyhow::Result<()> {
   |                  ^^^^^^ help: consider changing the type to: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value

Check warning on line 66 in backpack/cli/src/commands/maintain/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

matching over `()` is more explicit 

warning: matching over `()` is more explicit
  --> backpack/cli/src/commands/maintain/mod.rs:66:16
   |
66 |             Ok(_) => {
   |                ^ help: use `()` instead of `_`: `()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ignored_unit_patterns
   = note: `-W clippy::ignored-unit-patterns` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::ignored_unit_patterns)]`

Check warning on line 64 in backpack/cli/src/commands/maintain/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

variables can be used directly in the `format!` string 

warning: variables can be used directly in the `format!` string
  --> backpack/cli/src/commands/maintain/mod.rs:61:17
   |
61 | /                 eprintln!(
62 | |                     "Failed to complete full release cleanup for {}: {}",
63 | |                     repo, e
64 | |                 );
   | |_________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#uninlined_format_args
   = note: `-W clippy::uninlined-format-args` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::uninlined_format_args)]`

Check warning on line 74 in backpack/cli/src/commands/maintain/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` 

warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let`
  --> backpack/cli/src/commands/maintain/mod.rs:59:9
   |
59 | /         match github::delete_all_releases(&client, &repo) {
60 | |             Err(e) => {
61 | |                 eprintln!(
62 | |                     "Failed to complete full release cleanup for {}: {}",
...  |
74 | |         }
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#single_match_else
   = note: `-W clippy::single-match-else` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::single_match_else)]`
help: try
   |
59 ~         if let Err(e) = github::delete_all_releases(&client, &repo) {
60 +             eprintln!(
61 +                 "Failed to complete full release cleanup for {}: {}",
62 +                 repo, e
63 +             );
64 +         } else {
65 +             println!("Deleted all releases and tags");
66 + 
67 +             // Then create the new release
68 +             github::create_release(&client, &repo)?;
69 + 
70 +             println!("Created new release");
71 +         }
   |

Check warning on line 10 in backpack/cli/src/commands/maintain/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

this argument is passed by value, but not consumed in the function body 

warning: this argument is passed by value, but not consumed in the function body
  --> backpack/cli/src/commands/maintain/mod.rs:10:18
   |
10 | pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
   |                  ^^^^^^ help: consider changing the type to: `&str`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#needless_pass_by_value
   = note: `-W clippy::needless-pass-by-value` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::needless_pass_by_value)]`

Check warning on line 80 in backpack/cli/src/commands/maintain/mod.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

it is more idiomatic to use `Option<&T>` instead of `&Option<T>` 

warning: it is more idiomatic to use `Option<&T>` instead of `&Option<T>`
  --> backpack/cli/src/commands/maintain/mod.rs:10:1
   |
10 |   pub fn run(repo: String, action: &Option<String>) -> anyhow::Result<()> {
   |   ^                                --------------- help: change this to: `Option<&String>`
   |  _|
   | |
11 | |     // Capture backtraces for all errors
12 | |     Hooks::new()
13 | |         .report_creation_hook(BacktraceCollector::new_from_env())
...  |
79 | |     Ok(())
80 | | }
   | |_^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#ref_option
   = note: `-W clippy::ref-option` implied by `-W clippy::pedantic`
   = help: to override `-W clippy::pedantic` add `#[allow(clippy::ref_option)]`

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_x86_64_msvc`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_x86_64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_x86_64_gnu`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_i686_msvc`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_i686_gnullvm`: 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_i686_gnu`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_aarch64_msvc`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1 

warning: multiple versions for dependency `windows_aarch64_gnullvm`: 0.42.2, 0.52.6, 0.53.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5 

warning: multiple versions for dependency `windows-targets`: 0.42.2, 0.52.6, 0.53.5
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2 

warning: multiple versions for dependency `windows-sys`: 0.45.0, 0.52.0, 0.59.0, 0.60.2, 0.61.2
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1 

warning: multiple versions for dependency `windows-strings`: 0.4.2, 0.5.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-result`: 0.3.4, 0.4.1 

warning: multiple versions for dependency `windows-result`: 0.3.4, 0.4.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-link`: 0.1.3, 0.2.1 

warning: multiple versions for dependency `windows-link`: 0.1.3, 0.2.1
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `windows-core`: 0.61.2, 0.62.2 

warning: multiple versions for dependency `windows-core`: 0.61.2, 0.62.2
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions

Check warning on line 1 in backpack/cli/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / Clippy Output

multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18 

warning: multiple versions for dependency `thiserror-impl`: 1.0.69, 2.0.18
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/rust-1.93.0/index.html#multiple_crate_versions
View more details on GitHub Actions