Repository navigation
Conversation
GetShortcutAnalytics returned a shortcut's click analytics (referrer URLs, device/browser breakdown) given only its numeric id, with no check that the caller is the shortcut's creator or an admin, unlike the sibling UpdateShortcut/DeleteShortcut methods which both enforce shortcut.CreatorId == user.ID || user.Role == RoleAdmin. Any authenticated user of the instance could view any other user's shortcut analytics by iterating shortcut ids. Add the same creator-or-admin check used by UpdateShortcut and DeleteShortcut.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #506
Summary
GetShortcutAnalyticsreturned any shortcut's referrer/device analytics given only its numeric id, with no check that the caller is the shortcut's creator or an admin, unlike the siblingUpdateShortcut/DeleteShortcutmethods which both enforce that check.Fix
Add the same creator-or-admin check used by
UpdateShortcutandDeleteShortcut.Testing
Verified against a from-source build with a real end-to-end scenario: two independent users, one shortcut, a simulated click, and a cross-user analytics request. Before the fix, an unrelated authenticated user received the full analytics; after the fix, the identical request returns
PermissionDenied, while the shortcut's actual creator is unaffected.