Skip to content

Fix missing ownership check on GetShortcutAnalytics #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carfeii wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix missing ownership check on GetShortcutAnalytics #507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions server/route/api/v1/shortcut_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,17 @@ func (s *APIV1Service) GetShortcutAnalytics(ctx context.Context, request *v1pb.G
return nil, status.Errorf(codes.NotFound, "shortcut not found")
}

// Analytics (referrers, device/browser breakdown) are more sensitive than
// the shortcut's own visibility setting governs, so restrict to the
// shortcut's creator or an admin, matching UpdateShortcut/DeleteShortcut.
user, err := getCurrentUser(ctx, s.Store)
if err != nil {
return nil, status.Errorf(codes.Internal, "failed to get current user: %v", err)
}
if user == nil || (shortcut.CreatorId != user.ID && user.Role != store.RoleAdmin) {
return nil, status.Errorf(codes.PermissionDenied, "Permission denied")
}

activityFind := &store.FindActivity{
Type: store.ActivityShortcutView,
PayloadShortcutID: &shortcut.Id,
Expand Down