icicle v2 integration#15
Closed
emirsoyturk wants to merge 12 commits into
Closed
Conversation
|
@emirsoyturk tysm for your PR do you mind updating from main so that you get the latest performance updates / new msm |
Author
|
Hey, @alexander-camuto. I am going to apply changes on the main branch but i cannot run tests in the latest version. It throws couple errors. |
|
Will take a look :) |
|
@emirsoyturk patched ! thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR updates the existing ICICLE MSM operations to use the latest version of ICICLE v2 and also enables NTT and INTT operations to be executed on the GPU via ICICLE.