Skip to content

libultrahdr: fix i686-linux build and unrestrict meta.platforms - #533168

Merged
OPNA2608 merged 2 commits into
NixOS:stagingfrom
zwang20:fix-libultrahdr
Jun 20, 2026
Merged

libultrahdr: fix i686-linux build and unrestrict meta.platforms#533168
OPNA2608 merged 2 commits into
NixOS:stagingfrom
zwang20:fix-libultrahdr

Conversation

@zwang20

@zwang20 zwang20 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Things done

nixpkgs-branch-check[bot]

This comment was marked as outdated.

@nixpkgs-ci
nixpkgs-ci Bot requested a review from yzx9 June 19, 2026 03:18
@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jun 19, 2026
@zwang20
zwang20 changed the base branch from master to staging June 19, 2026 03:26
@nixpkgs-ci nixpkgs-ci Bot closed this Jun 19, 2026
@nixpkgs-ci nixpkgs-ci Bot reopened this Jun 19, 2026
@nixpkgs-branch-check
nixpkgs-branch-check Bot dismissed their stale review June 19, 2026 03:34

Review dismissed automatically

@yzx9

yzx9 commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

The code LGTM, but I can’t test this since I don’t have access to a machine with that architecture, e.g. i686-linux.

cc @OPNA2608, who submitted the PR #527782 to restrict meta.platforms.

close: #532626

@OPNA2608

Copy link
Copy Markdown
Contributor

Thanks for the ping. Please apply google/libultrahdr@13a058f to fix tests on big-endian.

@OPNA2608

OPNA2608 commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

libultrahdr and imagemagick build with no issues on powerpc64-linux with this. Change seems fine to me.

Might want to fix the first commit: From: Your Name <you@example.com>

@OPNA2608

Copy link
Copy Markdown
Contributor

LGTM, leaving final approval to @yzx9.

@OPNA2608 OPNA2608 added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jun 20, 2026
@OPNA2608
OPNA2608 added this pull request to the merge queue Jun 20, 2026
Merged via the queue into NixOS:staging with commit c7a1153 Jun 20, 2026
30 checks passed
@yzx9 yzx9 mentioned this pull request Jun 22, 2026
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501-1000 This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants