Repository navigation
Add: Eddy-Solutions-Link BACnet profile - #43
Merged
Merged
Conversation
4 tasks done
rakaustin
reviewed
Sep 14, 2026
rakaustin
left a comment
Collaborator
There was a problem hiding this comment.
registry.json中的 lorawanClass 不匹配
rakaustin
marked this pull request as ready for review
September 14, 2026 04:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated Profile evidence
1656626193aeb958da676c622063a5b6ad16243fba6babe94b3999ec6d06e664deepseek / deepseek-flash{"mode":"fixed","ports":[3],"citation":"Issue #42 declares fport3 on all three uplink examples; its downlink command examples declare Fport 5, which datatype channels 10 and 11 declare as fport."}Evidence matrix
Agent summary
Repaired the Eddy-Solutions Link profile (profiles/Eddy-Solutions/Eddy-Solutions-Link.yaml) and its strict fixture. The previous attempt was rejected only because the Agent result reported the writable Valve Control channel as BinaryOutputObject, which the output schema does not allow; the candidate artifacts themselves are regenerated here and the candidate validation command passes every check (yaml, schema, requiredFields, codecSafety, codecSyntax, bacnet, naming, semantics, fixture). Decode implements the documented Link uplink frames Describe 0x01 (firmware version bytes 1-2, report period byte 5), Meter Data 0x02 (meter status bytes 1-2, odometer bytes 3-6, flow rate bytes 9-10), Extended Meter Data 0x82 (flow rate bytes 3-4), Valve 0x03 (meter status bytes 1-2), Alert 0x04, and Backup Data Resend 0x15 (meter status bytes 6-7), publishing all 11 requested channels. Encode implements Valve Control 0x73 (0x00 open, 0x01 close) and Meter Report Period 0x71 (0x00-0x3C minutes) on fPort 5. Every branch fails closed on unknown fPort, truncation, malformed bytes, unknown channels, and non-numeric values.
Warnings
Closes #42