Skip to content

JENKINS-54662 JCasC support for usage statistics - #4549

Merged
timja merged 3 commits into
jenkinsci:masterfrom
timja:disable-usage-statistics
Mar 13, 2020
Merged

JENKINS-54662 JCasC support for usage statistics#4549
timja merged 3 commits into
jenkinsci:masterfrom
timja:disable-usage-statistics

Conversation

@timja

@timja timja commented Mar 6, 2020

Copy link
Copy Markdown
Member

See JENKINS-54662.

Example configuration:

jenkins:
  noUsageStatistics: true

Proposed changelog entries

  • Entry 1: JENKINS-54662, configuration-as-code plugin support for disabling usage statistics
  • ...

Proposed upgrade guidelines

N/A

Submitter checklist

  • JIRA issue is well described
  • Changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developer, depending on the change). Examples
    • Fill-in the Proposed changelog entries section only if there are breaking changes or other changes which may require extra steps from users during the upgrade
  • Appropriate autotests or explanation to why this change has no tests
  • For dependency updates: links to external changelogs and, if possible, full diffs

Desired reviewers

@mention

Maintainer checklist

Before the changes are marked as ready-for-merge:

  • There are at least 2 approvals for the pull request and no outstanding requests for change
  • Conversations in the pull request are over OR it is explicit that a reviewer does not block the change
  • Changelog entries in the PR title and/or Proposed changelog entries are correct
  • Proper changelog labels are set so that the changelog can be generated automatically
  • If the change needs additional upgrade steps from users, upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the PR title. (example)
  • If it would make sense to backport the change to LTS, a JIRA issue should exist and be labeled as lts-candidate

Comment thread core/src/main/java/jenkins/model/Jenkins.java Outdated
@timja
timja requested review from a team, jetersen and oleg-nenashev March 6, 2020 22:08

@jetersen jetersen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable

@oleg-nenashev oleg-nenashev added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Mar 12, 2020

@oleg-nenashev oleg-nenashev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me. Added some suggestions for Javadoc so that two methods can be distinguished easily.

/**
* Sets the noUsageStatistics flag
*
* @since TODO

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was introduced in 2011 or earlier, so it is not a big deal. All reasonable versions will be compatible 70c1065

Comment thread core/src/main/java/jenkins/model/Jenkins.java
Comment thread core/src/main/java/jenkins/model/Jenkins.java
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
@timja timja added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 12, 2020
@timja

timja commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

This is ready-for-merge, let's merge it in 24 hours if no negative feedback

@timja
timja merged commit 51c8950 into jenkinsci:master Mar 13, 2020
@timja
timja deleted the disable-usage-statistics branch March 13, 2020 12:01
Comment thread core/src/main/java/jenkins/model/Jenkins.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants