JENKINS-54662 JCasC support for usage statistics - #4549
Merged
Conversation
timja
commented
Mar 6, 2020
rsandell
approved these changes
Mar 12, 2020
alecharp
approved these changes
Mar 12, 2020
oleg-nenashev
approved these changes
Mar 12, 2020
oleg-nenashev
left a comment
Member
There was a problem hiding this comment.
The code itself looks good to me. Added some suggestions for Javadoc so that two methods can be distinguished easily.
| /** | ||
| * Sets the noUsageStatistics flag | ||
| * | ||
| * @since TODO |
Member
There was a problem hiding this comment.
It was introduced in 2011 or earlier, so it is not a big deal. All reasonable versions will be compatible 70c1065
Co-Authored-By: Oleg Nenashev <o.v.nenashev@gmail.com>
Member
Author
|
This is ready-for-merge, let's merge it in 24 hours if no negative feedback |
10 tasks
daniel-beck
reviewed
May 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See JENKINS-54662.
Example configuration:
Proposed changelog entries
Proposed upgrade guidelines
N/A
Submitter checklist
Proposed changelog entriessection only if there are breaking changes or other changes which may require extra steps from users during the upgradeDesired reviewers
@mention
Maintainer checklist
Before the changes are marked as
ready-for-merge:Proposed changelog entriesare correctupgrade-guide-neededlabel is set and there is aProposed upgrade guidelinessection in the PR title. (example)lts-candidate