Repository navigation
spec(AST-131): React Native platform: Web (WebView and its modules) - #12551
imdreamrunner wants to merge 23 commits into
Conversation
…and bundled pages under declared native policy
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
…PI with one opt-in exception
…s as parts of the capability
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and seven fixes in the record either way.
Owner decision. spec:AST-131 adds requirements FR1–FR19 and decisions DEC-1–DEC-5 for the React Native web view that no current record states, and the React Native foundation record it details is itself a draft. Approval waits on an engineering owner approving or rejecting them by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), which settles the web capability's contract, including FR19's opt-in to private WebKit switches, and whether it waits for the foundation record's named-feature changes.
Fixes needed:
- FR7 refuses a bundle source with session cookies with
invalid-config, but its warm-up sentence loads a warm bundle view that carries session cookies with no error, so drop "or carries session cookies" from the warm-up sentence. - Current-state impact says the record changes nothing beyond AST-112, but AST-112 on
mainreports a behaviour revision throughgetConstants().versionand has no named features, revision-1 baseline or Stage version floor, so list those AST-112 changes here or wait until they are current. textScaledefaults to 1 while FR17 says the page's text follows the system text size, so default it to React Native's font scale or narrow FR17 to callers that pass it.- FR3 gives
AstryxWebViewInfono member that lists features although FR14 reads features from it, FR18 checks them withhasContractFeature, and OQ7 still asks where they live, so name that member in FR3 and align OQ7 with FR18. - FR16 says calls resolve
not-linkedwhenwebis not opted in, but saysuseAuthSession()calls resolveno-modulewith no condition, so scope that bullet to the platform switched off through the capabilities provider or drop it. - The title says "WebView and its modules" while the record governs only the web view and leaves the modules to a record it does not name, so retitle it and name that record.
- The rubric result "R2 research: none" does not hold, because "Why this exists" surveys react-native-webview, expo-web-browser and expo-auth-session, so move that column out of the record and keep each conclusion inside its decision.
Claims and files checked
Review mode: full; reason: no-earlier-review
- The record states requirements FR1–FR19 and decisions DEC-1–DEC-5: verified (spec.md:100-354, 413-470).
- The record details the React Native foundation record's FR1, FR3, FR6, FR7, FR8, FR12 and FR15 and changes none of them: false, because the foundation record on
mainhas no named features, revision-1 baseline or Stage version floor (spec.md:291-343, 380-383). - The record cites the native-first surfaces record's FR3 and FR13 and the native component guidelines' FR5: verified.
- No other record owns the web view: verified, no record on
mainnames it. - No open pull request overlaps: true when written; two sibling draft records opened afterwards.
- Each of the other five modules has its own record: not verified, no record on
mainnames them (spec.md:41-42, 84). - The rejected alternatives sit inside DEC-1, DEC-2, DEC-4 and DEC-5, one line each: verified.
- Two gaps are recorded, Stage rendering the view only on macOS and keeping no warm pages: verified as stated, labelled against the contract-baseline requirement rather than Stage parity (spec.md:363-367).
- Rubric R1, R3, R4, R5 and R7 results: verified; R2: false (spec.md:44-51); R6: verified as stated, though OQ7 conflicts with FR18.
- Knowledge validation passes with no warning for this record: verified, rerun at this head.
- Prettier and whitespace checks are clean: verified.
- The leak scan finds no internal context: verified.
- The pull request contains specification records only: verified.
docs/specs/AST-131-react-native-web-view/spec.md: the seven fixes above, plus a non-blocking relabel of the two gap lines.
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and ten fixes in the record either way.
Owner decision. spec:AST-131 adds requirements FR1–FR19 and decisions DEC-1–DEC-5 for the React Native web view that no current record states, and the React Native foundation record it details is itself a draft. Approval waits on an engineering owner approving or rejecting them by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner); that decision covers FR19's opt-in to private WebKit switches and whether the record waits for the foundation record's named-feature changes.
Fixes needed:
- Miss: DEC-3 says cookie values never appear in props, but the
cookiessession option reaches the host as thesessionCookiesprop (FR3, FR8), so drop that option and prop, or narrow DEC-3, the "Why this exists" row and the FR8 verification cell to the handle path. - Miss: FR14 lists
hardeningas a feature beyond the baseline although FR4's hardening script is part of that baseline, so drop it from the list or say it names only FR19's opt-in private switches. - Miss: FR4 says the view adds no script beyond the hardening and channel scripts, but FR10 sets the iOS text size and the Android colour scheme through document CSS, which needs a page script, and CSS
color-schemedoes not change whatprefers-color-schemereports, so list that script in FR4 or state only the outcome in FR10. - FR7 refuses a bundle source with session cookies with
invalid-config, but its warm-up sentence loads a warm bundle view that carries session cookies with no error, so drop "or carries session cookies" from the warm-up sentence. - Current-state impact says the record changes nothing beyond the foundation record, but on
mainthat record reports a behaviour revision throughgetConstants().versionand has no named features, revision-1 baseline or Stage version floor, so list the foundation changes this record depends on and name the open amendment and the modules' record in the description. - FR3 gives
AstryxWebViewInfono member that lists features although FR14 reads features from that list and FR18 checks them withhasContractFeature, while OQ7 still asks where they live, so name that member in FR3 and align OQ7 with FR18. textScaledefaults to 1 while FR17 says the page's text follows the system text size, so default it to React Native's font scale or narrow FR17 to callers that pass it.- FR16 says calls resolve
not-linkedwhenwebis not opted in, but saysuseAuthSession()calls resolveno-modulewith no condition, so scope that bullet to a missing native module or drop it. - The title says "WebView and its modules" while the record governs only the web view and leaves the modules to a record it does not name, so retitle it and name that record.
- The rubric result "R2 research: none" does not hold, because "Why this exists" surveys react-native-webview, expo-web-browser and expo-auth-session, so move that column out of the record and keep each conclusion inside its decision.
Claims and files checked
Review mode: full; reason: spec-record
- The record states the web view's contract for navigation, bundled folders, sessions and page storage, the message channel, appearance, process end, capture prevention, the link menu, warm-up, accessibility and fallbacks: verified (FR4–FR17).
- The capability's other modules are placed, not specified: verified (Who uses it, OQ1–OQ3).
- The record details the foundation record's FR1, FR3, FR6, FR7, FR8, FR12 and FR15 and changes none of them: false; its FR14, FR18 and Current-state impact rely on named features, a revision-1 baseline and a Stage version floor that the foundation record on
maindoes not state (spec.md:291-343, 380-383). - The record cites the native-first surfaces record's FR3 and FR13 and the native component guidelines' FR5: verified.
- No other record owns the web view, and no current record owns its contract: verified; no record on
mainnames it. - No open pull request overlaps: false now; the foundation record's open amendment and the open record for the five other modules overlap it.
- Sessions cross as native handles: contradicted by the
cookiessession option (spec.md:132, 203-216, 443-445). - Each of the other five modules has its own record: not on
main; that record is an open draft this record does not name (spec.md:41-42, 84). - Four rejected alternatives sit inside DEC-1, DEC-2, DEC-4 and DEC-5, one line each: verified.
- Two Stage gaps are recorded: verified as stated, but labelled against the contract baseline rather than Stage parity (spec.md:363-367).
- Rubric R1, R3, R4, R5 and R7 results: verified; R2: false (spec.md:44-51); R6: OQ7 conflicts with FR18.
- Knowledge validation passes with no warning for this record: verified, rerun at this head.
- Prettier and whitespace checks are clean: verified.
- The leak scan finds no internal context: verified.
- The pull request contains specification records only: verified.
docs/specs/AST-131-react-native-web-view/spec.md: the ten fixes above, plus three non-blocking notes (relabel the two gap lines; state whether capture prevention on iOS is best-effort or refuses under DEC-5; add AndroidX WebKit to FR1's Android list).
…nfo, textScale follows the system, Stage gaps under their own requirement
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and four fixes in the record either way; this revision fixes nine of the ten earlier findings.
Owner decision. spec:AST-131 adds requirements FR1–FR20 and decisions DEC-1–DEC-5 for the React Native web view that no current record states, and it relies on foundation-record changes and a platform info record that are still open (#12576, #12563, #12553). Approval waits on an engineering owner approving or rejecting them by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding the record until those pull requests are decided.
Fixes needed:
- Miss: FR4 says every frame loses WebRTC, DNS prefetching and
preconnectbefore the page's script runs, but FR19 says the private WebKit settings cover frames FR4 cannot reach and that without the opt-in FR4's protection is the same on both platforms, so state which frames FR4 reaches and record the rest as anFR4 gap:line that names FR19's opt-in, with a matching verification row. - Miss: FR7 refuses a bundle source with
session.pin, but a session handle's pin also applies to the view (FR8) and FR5 stops a navigation outside a pin, so a bundle view with a pinned handle could either refuse withinvalid-configor stop atpin, and FR7 should say that a pinned session from options or a handle refuses withinvalid-config, or that a bundle view ignores a handle's pin. - The title says "WebView and its modules" and the record says each of the five other modules has its own record, but the record specifies only the web view, its device report and
NativeWebView, and the five modules share one record, so retitle it to the web view and say they share one record. - Current-state impact now lists the amended foundation FR3, FR4, FR8 and FR12 but not FR1 and FR7, where the five other modules join the
webcapability and get their group record, so add those two lines.
Non-blocking: add an FR20 gap: line for Astryx Stage ignoring preventsCapture while it shows an Android device.
Claims and files checked
Review mode: full; reason: spec-record
- The record depends on the open foundation amendment and the open platform info record, and the five other web modules have their own record in another open pull request: verified; that one record covers all five modules.
- Merge order of the foundation promotion, its amendment, then this record: consistent with the sibling pull requests.
- The record states the web view's contract for navigation, bundled folders, sessions and page storage, the message channel, appearance, process end, capture prevention, the link menu, warm-up, accessibility, fallbacks and Astryx Stage: verified (FR4–FR20).
- The record relies on the amended foundation FR3, FR4, FR8 and FR12 and restates none of them: partly false; it also relies on the amended FR1 and FR7 (the fourth fix).
- No other record owns the web view: verified; no record on
mainnames it. - Only this workstream's sibling records overlap among open pull requests: verified.
webstays opt-in and the library reaches it only through the capability loader: verified (FR1).- Navigation is declared data decided natively, with a pin that holds across redirects: verified (FR5, DEC-1).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR6). - Bundled folders load from a private origin with no network, and warm-up shows a page loaded ahead of time: verified (FR7); a pinned session handle is not covered (the second fix).
- Sessions cross as native handles whose cookie values never appear in props, with ephemeral views, a page-storage-off mode and page data kept apart where the device can: verified (FR8, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR9, DEC-2).
- The page follows the colour scheme and text scale,
textScaledefaults to the system font scale, and content height is reported: verified (FR10). - A content process end is reported and the app picks the recovery: verified (FR11).
- Loads report a closed set of reasons, and a guarantee the binary cannot keep refuses with
unsupported: verified (FR13, DEC-5). - Behaviour beyond the baseline is named features listed through the platform info module, at revision 1 with no counters: verified (FR3, FR14, FR18).
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings: verified (FR19); FR4's every-frame wording contradicts it (the first fix).
- Astryx Stage shows the web view as the device does, with two named gaps: verified (FR20); a third difference is unnamed (non-blocking).
- The five other modules are part of the
webcapability, each with its own record: false as worded; they share one record (the third fix). - Four rejected alternatives, one line each, inside DEC-1, DEC-2, DEC-4 and DEC-5: verified.
- The record governs the web view, its device report and
NativeWebViewonly: verified; the title is broader (the third fix). - No public evidence links: verified.
- Writing rubric results R1 to R7: verified; the record cites the native-first surfaces and native component guidelines records besides the foundation record, and has no pull request or issue references.
- Specification records only, observable behaviour, no internal company context: verified.
- Knowledge validation passes with no warning for this record: verified, rerun at this head.
- Prettier and whitespace checks are clean: verified, rerun at this head.
- The leak scan finds no internal context: verified.
docs/specs/AST-131-react-native-web-view/spec.md: the four fixes above and one non-blocking note.
… web record stays neutral
…outside the core package
…ssions refused for bundles, AST-112 FR1 and FR7 reliance
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and six fixes in the record either way.
Owner decision. spec:AST-131 adds requirements FR1–FR19 and decisions DEC-1–DEC-5 for the React Native web view that no current record states, and it rests on foundation and platform records that are still open (#12563, #12594, #12553, #12579, #12598). Approval waits on an engineering owner approving them by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding the record until those pull requests are decided.
Fixes needed:
- FR1 says
./webexports "the capability's other modules" and that an app withoutweblinks no sign-in redirect handling, but the record now putsAstryxWebData,AstryxWebBundles,AstryxAuthSessionandAstryxPageSnapshotsoutside the package, so list what./webactually exports, drop the redirect clause from FR1 and its verification row, and bring Current-state impact (with a line for the amended foundation FR20), theuseAuthSessionnote, OQ3 and FR19 in line. - FR7 loads bundled folders that are registered with, routed through and warmed by
AstryxWebBundles, which the record now puts outside the package while it keepsAstryxWebSessionscore for the same kind of dependency, so keep the part ofAstryxWebBundlesthe view needs in the package or drop the bundle source,warm,bundledOriginandwarmBundlefrom this record. - FR14 cites
spec:AST-140FR5 but lists a one-platform feature only on that platform (FR12 and the FR14 verification row follow it), while AST-140 FR5 reports every feature on both platforms withisSupportedfalse and a note where it is missing, so align FR14, FR12 and that row with AST-140 FR5 or amend AST-140. - The new
FR4 gap:line and the FR4 verification row expect FR19's opt-in to close the parser-insertedpreconnectgap, but FR19's settings cover only peer connections, media devices and DNS prefetching, so name link preconnect among FR19's settings or say that part of the gap stays open with the opt-in. - The title still says "WebView and its modules" although the record leaves all four other modules out, so retitle the record and this pull request to the web view.
- Miss: FR5 gives no outcome or event for a top-level navigation to another origin that no person caused (a server redirect, a script navigation, a meta refresh) and does not say which origin counts as the first page's after the first load's own redirects, so state both.
Non-blocking: scope the "only the main frame" rule of FR9 and DEC-2 to devices with channel isolation, and have FR19 name its private API and the self-check the platform code record asks for.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the open foundation amendment, platform info record and shared platform rules, cites the open Stage and Preview records, and is not stacked: verified; all five pull requests are open.
- The record states the web view's contract for navigation, bundled folders, sessions and page storage, the message channel, appearance, process end, capture prevention, the link menu, warm-up, accessibility and fallbacks: verified (FR4–FR17); off-origin navigations no person caused are not covered (the sixth fix).
- Astryx Stage and Preview are separate products that conform to it: verified (Non-goals).
- Relies on the amended foundation FR3 and FR4 without restating them: verified; it also relies on the amended FR1, FR7 and FR20, and FR20 is not listed (the first fix).
- Cites the shared platform rules FR2, FR3, FR5 and FR9: verified; FR14 contradicts FR5's feature listing (the third fix).
- The platform info module lists the named features: verified (FR3).
- Cites the native-first surfaces FR3 and FR13 and the native component guidelines FR5: verified.
- No other record owns the web view, and only sibling records overlap among open pull requests: verified.
webstays opt-in and is reached only through the capability loader: verified (FR1).- Navigation is declared data decided natively, with a pin that holds across redirects: verified (FR5, DEC-1).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR6). - Bundled folders load from a private origin with no network, and warm-up shows a page loaded ahead of time: verified (FR7); both depend on a module the record puts outside the package (the second fix).
- Sessions cross as native handles whose cookie values never appear in props, with ephemeral views, page storage off and separate page data where the device can: verified (FR8, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR9, DEC-2), with the non-blocking scoping note.
- The page follows the colour scheme and text scale,
textScaledefaults to the system font scale, and content height is reported: verified (FR10). - A content process end is reported and the app picks the recovery: verified (FR11).
- Loads report a closed set of reasons, and an unkept guarantee refuses with
unsupported: verified (FR13, DEC-5). - Behaviour beyond the baseline is named features listed by the platform info module, at revision 1 with no counters: verified (FR3, FR14, FR18).
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings: verified (FR19); the FR4 gap overstates what it closes (the fourth fix).
- The web view, its device report and the session registry are core within
web, and the other four modules are outside the core package: stated, but FR1 still exports them (the first fix). - The ecosystem comparison is out of the record, and four rejected alternatives sit one line each inside DEC-1, DEC-2, DEC-4 and DEC-5: verified.
- The record governs the web view, its device report,
NativeWebViewand the session handle: verified; the title is broader (the fifth fix). - No public evidence links, and writing rubric results R1 to R7: verified.
- Specification records only, observable behaviour, no internal company context: verified.
- Knowledge validation, Prettier and whitespace checks pass: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: the six fixes and two non-blocking notes above.
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and two fixes in the record either way.
Owner decision. spec:AST-131 adds requirements FR1–FR18 and decisions DEC-1–DEC-4 for the React Native web view that no current record states, including FR5's rule for navigations no person caused and FR18's iOS opt-in to private WebKit settings, and it rests on records that are still open (#12563, #12594, #12553, #12579, #12598). Approval waits on an engineering owner approving them by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding the record until those pull requests are decided.
Fixes needed:
- FR5 now keeps a server redirect, script or meta-refresh navigation in the view whatever its origin, which contradicts FR2's "the view keeps only the first page's origin", sends a person's own form on a page reached that way (an identity provider's sign-in) to the system browser, and leaves open whether FR8's channel accepts that page, so choose one outcome and state it in FR2, FR5 and FR8.
- The Intent, "Who uses it" and its notes still describe
AstryxWebData,AstryxWebBundles,AstryxAuthSessionandAstryxPageSnapshotsas thewebcapability's modules and say what each does, while FR1 leaves them out ofweband the foundation's amended FR20 leaves such capabilities to the app, so say that Astryx ships none of them or name the package and record that do.
Non-blocking: scope DEC-2's main-frame rule as FR8 now does, say which FR3 members are revision 1 and which are named features, have FR18 report its self-check through the platform info module, and list the amended foundation FR15 in Current-state impact.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment, the platform info record and the shared platform rules, cites the Stage and Preview records, and is not stacked: verified; all five pull requests are open.
- The record states the web view's contract for navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility and the fallbacks when
webis not linked: verified (FR4–FR16). - Astryx Stage and Preview are separate products that conform to it: verified (Non-goals).
- The capability's four other modules are listed in "Who uses it" and are outside the core package: verified, but the text still describes them as the capability's own modules (the second fix).
- Relies on the amended foundation FR3 and FR4 without restating them: verified; it also relies on the amended FR1, FR7, FR15 and FR20, and FR15 is not listed (non-blocking).
- Cites the shared platform rules FR2, FR3, FR5 and FR9: verified.
- The platform info module lists the named features: verified (FR3, FR13).
- The native-first surfaces FR3 and native component guidelines FR5 apply, and no other record owns the web view: verified.
webstays opt-in and the library reaches it only through the capability loader: verified (FR1).- Navigation is declared data the native view decides without waiting on JavaScript, with a pin that holds across redirects: verified (FR5, DEC-1); the rule for navigations no person caused contradicts FR2 (the first fix).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR6). - Sessions cross as native handles with no cookie value in props, with ephemeral views, a page-storage-off mode and page data kept apart where the device can: verified (FR7, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR8, DEC-2), with the non-blocking DEC-2 scope note.
- The page follows the colour scheme and text scale,
textScaledefaults to the system's font scale, and content height is reported: verified (FR9). - A content process end is reported, the app keeps running, and the app picks the recovery: verified (FR10).
- Loads report a closed set of reasons, and a guarantee the binary cannot keep refuses with
unsupported: verified (FR12, DEC-4). - Behaviour beyond the baseline is named features each binary lists through the platform info module, with every contract at revision 1 and no counters: verified (FR3, FR13, FR17), with the non-blocking revision note.
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings for WebRTC, media devices and DNS prefetching: verified (FR18, which also covers link preconnect).
- The web view, its device report and the session registry are core within
webbecause the view depends on the session handle, and the other four modules are outside the core package: verified (FR1, FR7). - The ecosystem comparison is out of the record, and three rejected alternatives sit one line each inside DEC-1, DEC-2 and DEC-4: verified.
- The record governs the web view, its device report,
NativeWebViewand the session handle, and leaves out the library components, the four modules, Stage and Preview, and browser features the view does not offer: verified (Non-goals). - No public evidence links, and writing rubric results R1 to R7: verified.
- Specification record only, observable behaviour, no internal company context: verified.
- Knowledge validation, Prettier and whitespace checks pass: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: the two fixes and four non-blocking notes above; the earlier title finding is withdrawn after the author's reply.
| cannot reach. The view checks that the running WebKit answers to each | ||
| setting before it uses it, and the app that opts in takes the review risk |
There was a problem hiding this comment.
Non-blocking: spec:AST-140 FR9 has the binary report the self-check for a named exception through the platform info module and fall back to the public path when it fails. Say that here, with FR4's protection as the fallback.
… non-core web pieces are left to the app
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and three fixes either way.
Owner decision. spec:AST-131 adds requirements FR1–FR18 and decisions DEC-1–DEC-4 for the React Native web view that no current record states, including FR5's rule for navigations no person caused, FR18's iOS opt-in to private WebKit settings and the move of web data, bundled content, sign-in and page snapshots out of web, and it rests on records that are still open (#12563, #12594, #12553, #12579, #12598). Approval waits on an engineering owner approving it by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding it until those pull requests are decided.
Fixes needed:
- FR7 still says what clearing the views' shared page data does, but with web data now outside
webno operation in the record clears it and the openspec:AST-130FR18 still gives web view data toweb, so keep a clear call inweband say what it clears, or drop the two clearing clauses and say how an app clears that data, and align AST-130 FR18. - Miss: FR10's "the app keeps running in every case" cannot hold on Android 7.x inside the stated API level 24 floor, where the platform table reports no content process end and
supports('contentProcessEnd')still answers true, so add anFR10 gap:line or scope FR10 to Android 8.0 and later and gate that feature by the device. - The description's ecosystem table still says why Astryx owns
AstryxAuthSession,AstryxWebData,AstryxWebBundlesandAstryxPageSnapshots, and its claim scope calls them the capability's modules, while the record leaves them to the app, so update both.
Non-blocking: scope FR5's channel refusal to channel isolation as FR8 does, say what the first page's origin is for an ungranted HTML string, reconcile FR3 and FR17's baseline with FR13's list, have FR18 report its self-check through the platform info module, and add the amended foundation FR8 and FR15 and a spec:AST-130 citation to the record.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment, the platform info record and the shared platform rules, cites the Stage and Preview records, and is not stacked: verified; all five pull requests are open.
- The record states the target contract of the
webcapability for the parts Astryx components use, the web view, its device report and the session-handle part of the session registry: verified (Intent, FR1–FR3, FR7). - It covers navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility and the fallbacks: verified (FR4–FR16), with the Android 7.x gap in FR10 (blocking fix).
- Astryx Stage and Preview are separate products that conform to it: verified (Non-goals).
- Web data, bundled web content, web sign-in and page snapshots are not part of
web, are outside the core package, and an app uses its host platform or an open-source library: verified in the record; FR7 still describes clearing that data (blocking fix). - Relies on the amended foundation FR3 and FR4 without restating them: verified; it also relies on the amended FR1, FR7, FR8, FR15 and FR20, and FR8 and FR15 are not listed (non-blocking).
- Cites the shared platform rules FR2, FR3, FR5 and FR9: verified.
- The platform info module lists the named features: verified against the open platform info record, which the record does not cite by id (non-blocking).
- The native-first surfaces FR3 and FR13 and the native component guidelines FR5 apply, and no other record or open pull request owns the web view: verified.
webstays opt-in and the library reaches it only through the capability loader: verified (FR1).- Navigation is declared data the native view decides without waiting on JavaScript; a navigation no person caused stays in the view and does not change the view's own origin: verified (FR5, DEC-1).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR6); its first page's origin for the channel is open (non-blocking). - Sessions cross as native handles with no cookie value in props, with ephemeral views, a page-storage-off mode and page data kept apart where the device can: verified (FR7, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR8, DEC-2), with the channel-isolation scope note on FR5 (non-blocking).
- The page follows the colour scheme and text scale,
textScaledefaults to the system font scale, and content height is reported: verified (FR9). - A content process end is reported, the app keeps running, and the app picks the recovery: false on Android 7.x inside the stated floor (blocking fix); verified elsewhere (FR10).
- Loads report a closed set of reasons, and a guarantee the binary cannot keep refuses with
unsupported: verified (FR12, DEC-4). - Behaviour beyond the baseline is named features listed through the platform info module, each contract's baseline is its first release's shape, with no revision number: verified (FR3, FR13, FR17), with the two-baselines note (non-blocking).
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings for WebRTC, media devices and DNS prefetching: verified (FR18, which also covers link preconnect).
- The web view, its device report and the session registry are core within
webbecause the view depends on the session handle, and the other four pieces are outside the package andweb: verified (FR1, FR7, Who uses it). - Ecosystem comparison: false where it says why Astryx owns the sign-in, web data, bundled content and snapshot pieces, which the record leaves to the app (blocking fix).
- Three rejected alternatives sit one line each inside DEC-1, DEC-2 and DEC-4: verified.
- Claim scope: the record governs the web view, its device report,
NativeWebViewand the session handle, and leaves out the library components, Stage, Preview and unsupported browser features: verified; calling the four excluded pieces the capability's modules is false (blocking fix). - No public evidence links; writing rubric results R1 to R7: verified.
- Specification record only, observable behaviour, no internal company context: verified.
- Knowledge validation, Prettier and whitespace checks pass: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: three blocking fixes (two in the record, one in the description) and five non-blocking notes above.
…d from Android 8.0
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and one fix either way.
Owner decision. spec:AST-131 adds requirements FR1–FR18 and decisions DEC-1–DEC-4 for the React Native web view that no current record states, including FR5's rule for navigations no person caused, FR18's iOS opt-in to private WebKit settings and FR7's rule that web has no call to clear the views' shared page data, and it rests on records that are still open (#12563, #12594, #12553, #12579, #12598). Approval waits on an engineering owner approving it by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding it until those pull requests are decided.
Fix needed:
- FR10 still says "The app keeps running in every case" right before its new sentence that a content process end can end the app before Android 8.0, and its verification row fails on "The app ends" with Android 7.x listed as a state, so scope that sentence to devices that report
contentProcessEndand keep only the reporting failure for Android 7.x.
Non-blocking: name the store or profile that holds the views' shared page data an app now clears itself, say "a person's navigation" in FR5's new HTML-string sentence and whether that document's own messages reach the app, reconcile FR3 and FR17's baseline with FR13's list, have FR18 report its self-check through the platform info module, add the amended foundation FR8 and FR15 to Current-state impact, and, Miss: correct the description's R5 rubric line, which says the record cites only foundation ids although it also cites the platform code, system modules, Stage, Preview, native-first and native component records.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment, the system modules record and the shared platform rules, cites the Stage and Preview records, and is not stacked: verified; all five pull requests are open drafts, and no Stack line exists.
- The record states the target contract of
webfor the parts Astryx components use (the web view, its device report, the session-handle part of the session registry): verified (Intent, FR1–FR3, FR7). - It covers navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility and the fallbacks: verified (FR4–FR16).
- Stage and Preview are separate products that conform to it: verified (Non-goals).
- Web data, bundled web content, web sign-in and page snapshots are not part of
web, are outside the core package, and an app uses its host platform or an open-source library: verified (Intent, Non-goals, FR7); the store an app's clear must reach is unnamed (non-blocking). - Relies on the amended foundation FR3 and FR4 without restating them: verified; it also relies on the amended FR1, FR7 and FR20 (listed) and FR8 and FR15 (not listed, non-blocking).
- Cites the shared platform rules FR2, FR3, FR5 and FR9, the system modules record's platform info module, the native-first surfaces FR3 and the native component guidelines FR5: verified.
- No other record or open pull request owns the web view: verified on
main(only the foundation record mentions it). webstays opt-in and the library reaches it only through the capability loader: verified (FR1).- Navigation is declared data the native view decides without waiting on JavaScript; a navigation no person caused stays in the view and does not change the view's own origin: verified (FR5, DEC-1), with the HTML-string wording note (non-blocking).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR5, FR6). - Sessions cross as native handles with no cookie value in props, with ephemeral views, a page-storage-off mode and page data kept apart where the device can: verified (FR7, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR8, DEC-2) on devices with channel isolation.
- The page follows the colour scheme and text scale,
textScaledefaults to the system font scale, and content height is reported: verified (FR9). - A content process end is reported, the app keeps running, and the app picks the recovery: verified on iOS and Android 8.0 and later; false on Android 7.x, which the record now says itself while FR10 still promises otherwise (blocking fix).
- Loads report a closed set of reasons, and a guarantee the binary cannot keep refuses with
unsupported: verified (FR12, DEC-4). - Behaviour beyond the baseline is named features listed through the platform info module, each contract's baseline is its first release's shape, with no revision number: verified (FR3, FR13, FR17), with the two-baselines note (non-blocking).
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings for WebRTC, media devices and DNS prefetching: verified (FR18, which also covers link preconnect).
- The web view, its device report and the session registry are core within
webbecause the view depends on the session handle; the other four pieces are outside the package andweb: verified (FR1, FR7, Who uses it). - The who-uses-it and ecosystem tables match the record: verified.
- Three rejected alternatives sit one line each inside DEC-1, DEC-2 and DEC-4: verified.
- Claim scope and non-goals: verified.
- No public evidence links: verified.
- Writing rubric results R1–R7: verified, except R5's "cites only foundation ids", which is stale (non-blocking); no pull request or issue reference remains in the record.
- Specification record only, observable behaviour, no internal company context: verified.
- Knowledge validation, Prettier and whitespace checks pass: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: one blocking fix (FR10) and five non-blocking notes above.
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and one fix to the description either way; the record's own content-process-end text is fixed at this head.
Owner decision. spec:AST-131 adds requirements FR1–FR18 and decisions DEC-1–DEC-4 for the React Native web view that no current record states, including FR5's rule for navigations no person caused, FR18's iOS opt-in to private WebKit settings and FR7's rule that web has no call to clear the views' shared page data, and it rests on records that are still open (#12563, #12594, #12553, #12579, #12598). Approval waits on an engineering owner approving it by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding it until those pull requests are decided.
Fix needed:
- The description's Decision bullet still says a content process end is reported and the app keeps running, which FR10 now limits to iOS and Android 8.0 and later, so scope that bullet the same way and say that earlier Android reports
contentProcessEndas not supported.
Non-blocking: scope DEC-4's refusal to guarantees a prop requests, since FR8 loads without channel isolation and FR11 loads an iOS page without capture protection (Miss: earlier reviews did not raise it), and the earlier notes on naming the store for the views' shared page data, FR13's baseline against FR3 and FR17, FR18's self-check report, and the amended foundation FR8 and FR15 in Current-state impact still stand.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment, the system modules record and the shared platform rules, cites the Stage and Preview records, and is not stacked: verified; all five pull requests are open drafts, and no Stack line exists.
- The record states the target contract of
webfor the parts Astryx components use (the web view, its device report, the session-handle part of the session registry): verified (Intent, FR1–FR3, FR7). - It covers navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility and the fallbacks: verified (FR4–FR16).
- Stage and Preview are separate products that conform to it: verified (Non-goals).
- Web data, bundled web content, web sign-in and page snapshots are not part of
web, are outside the core package, and an app uses its host platform or an open-source library: verified (Intent, Non-goals, FR7); the store an app's clear must reach is unnamed (non-blocking). - Relies on the amended foundation FR3 and FR4 without restating them: verified; it also relies on the amended FR1, FR7 and FR20 (listed) and FR8 and FR15 (not listed, non-blocking).
- Cites the shared platform rules FR2, FR3, FR5 and FR9, the system modules record's platform info module, the native-first surfaces FR3 and the native component guidelines FR5: verified.
- No other record or open pull request owns the web view: verified (on
mainonly the foundation record mentions it; the open pull requests that mention it are this workstream's records or name it in passing). webstays opt-in and the library reaches it only through the capability loader: verified (FR1).- Navigation is declared data the native view decides without waiting on JavaScript; a navigation no person caused stays in the view and does not change the view's own origin: verified (FR5, DEC-1).
- An HTML string has an opaque origin unless
grantsOrigingrants the base URL's: verified (FR5, FR6). - Sessions cross as native handles with no cookie value in props, with ephemeral views, a page-storage-off mode and page data kept apart where the device can: verified (FR7, DEC-3).
- One message channel whose sender origin comes from the engine: verified (FR8, DEC-2) on devices with channel isolation.
- The page follows the colour scheme and text scale,
textScaledefaults to the system font scale, and content height is reported: verified (FR9). - A content process end is reported, the app keeps running, and the app picks the recovery: false before Android 8.0, where FR10 now says the end is not reported and can end the app (blocking fix).
- Loads report a closed set of reasons, and a guarantee the binary cannot keep refuses with
unsupported: verified (FR12, DEC-4), with the DEC-4 scope note (non-blocking). - Behaviour beyond the baseline is named features listed through the platform info module, each contract's baseline is its first release's shape, with no revision number: verified (FR3, FR13, FR17), with the two-baselines note (non-blocking).
- Native code uses public platform API only, with an off-by-default iOS opt-in to private WebKit settings for WebRTC, media devices and DNS prefetching: verified (FR18, which also covers link preconnect).
- The web view, its device report and the session registry are core within
webbecause the view depends on the session handle; the other four pieces are outside the package andweb: verified (FR1, FR7, Who uses it). - The who-uses-it and ecosystem tables match the record: verified (the seven rows are identical).
- Three rejected alternatives sit one line each inside DEC-1, DEC-2 and DEC-4: verified.
- Claim scope and non-goals: verified.
- No public evidence links: verified.
- Writing rubric results R1–R7: verified; R5 now lists every record the text cites, and no pull request or issue reference remains in the record.
- Specification record only, observable behaviour, no internal company context: verified.
- Knowledge validation, Prettier and whitespace checks pass: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: one blocking fix (in the description) and five non-blocking notes above.
| When a caller asks for a privacy or isolation guarantee (page storage off, a | ||
| frame-safe channel) and the binary or device cannot keep it, | ||
| nothing loads and `onError` reports `unsupported`. A caller checks | ||
| `supports(feature)` first and picks its own path. |
There was a problem hiding this comment.
Non-blocking, Miss: no prop asks for "a frame-safe channel" (FR2, FR3), and FR8 loads on a device without channel isolation with every message as origin: "null" (lines 239-242); FR11 also loads an iOS page without capture protection when preventsCapture is set (lines 271-274), the path this decision rejects. Scope this decision to guarantees a prop requests (page storage off), and say that channel isolation and capture prevention are checked with supports first.
There was a problem hiding this comment.
This draft spec needs an engineering owner's decision before it can be approved, and three fixes either way; the earlier content-process-end claim in the description is fixed at this head.
Owner decision. spec:AST-131 states requirements FR1–FR18 and decisions DEC-1–DEC-4 for the React Native web view that no current record states, including FR1's ./web entry that makes WebView the public face of an internal native view, FR5's rule for navigations no person caused, and FR18's iOS opt-in to private WebKit settings; it also rests on changes to the foundation record, the shared platform rules and the system modules record that are still open (#12563, #12594, #12553). Approval waits on an engineering owner approving it by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holding it until those pull requests are decided and WebView's home is settled.
Fixes needed:
- Intent and Current-state impact rest "native views are internal implementation behind components" on the amended foundation FR21, which is about who draws an element and about glass and materials; the clause that says it is the amended FR5, so cite FR5 in both places and in the description.
- The platform table's iOS cell says
AstryxWebViewhas "Every named feature", while FR11 and FR13 have the iOS binary reportpreventsCaptureas not supported, so write "Every named feature butpreventsCapture, which it reports as not supported (FR11)". - Non-goals reads "None.", which drops the record template's standing bullets and the boundary around the components, while FR15 and the description still say
WebViewandWebContenthave their own records for their props and states and no such record exists; restore the template's bullets with a non-goal for what stays outside, and say in the description and FR15 that no record defines those components yet.
Non-blocking: DEC-4's refusal still reads wider than FR8 and FR11, which load without channel isolation and without capture protection on iOS; FR18 does not yet say that the binary reports the opt-in's self-check and falls back to FR4's protection; Current-state impact still leaves out the amended foundation FR15; FR11 no longer says that a *.<domain> pattern over a public suffix matches nothing; FR1's "links the web engine when it opts web in" drops the guarantee its own verification row checks; clearing the views' shared page data has no owner in this record or the system modules record; FR13's baseline leaves scrollEnabled, layerTypeAndroid and reload neither baseline nor named features; and the description's rubric line R5 still lists a record the text no longer cites.
Claims and files checked
Review mode: full; reason: spec-record
- Depends on the foundation amendment, the shared platform rules and the system modules record, and is not stacked: verified; all three pull requests are open drafts, and no Stack line exists.
- The record states the target contract of
webfor the parts Astryx components use (the web view, its device report, the session-handle part of the session registry): verified (Intent, FR1–FR3, FR7). - The native web view is internal implementation behind the library's
WebView, which is its public face: verified in the record (FR1, FR2); its cited authority is wrong (blocking fix above). - The
./webentry exportsWebViewandWebContentin place of the native view and its probe: verified (FR1). - The record covers the web view, its device report and the session handle, with rows and notes for pieces outside
webgone: verified (Who uses it, FR7, Non-goals). - It covers navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility and the fallbacks: verified (FR4–FR16).
- Requirements that read as bans now describe what each module does, with the safe defaults, one script per page, cookie values kept native and a refused load kept as behaviour: verified (FR4, FR7, FR12, DEC-2, DEC-3, DEC-4).
- Non-goals reads "None." as the template requires: false; the template's Non-goals carries standing bullets, and the record's own boundary for the components is gone (blocking fix above).
- Decisions state the chosen direction and its reason, with the one-line rejected alternatives gone: verified (DEC-1 to DEC-4).
- Versioning reads "contracts grow by named features": verified (FR3, FR13, FR17), though the baseline note above still stands.
- Existing authority searched, and no other record owns the web view: verified; on
mainonly the foundation record mentions the web capability, and the open pull requests that mention a web view are this workstream's. - A content process end is reported and the app keeps running on iOS and Android 8.0 and later: verified (FR10 and the description now agree).
- Native code uses public platform API, with an off-by-default iOS opt-in to private WebKit settings: verified (FR18), with the self-check note above.
- The who-uses-it table matches the record, and the ecosystem comparison sits in the description: verified.
- Writing rubric results R1–R7: verified except R5, which lists a record the text no longer cites (non-blocking).
- Specification record only, no internal company context: verified.
- Knowledge validation and Prettier: verified, rerun at this head.
docs/specs/AST-131-react-native-web-view/spec.md: three blocking fixes and eight non-blocking notes above.
|
|
||
| - **FR1 — `web` is an opt-in capability.** The web view, its device report, | ||
| and the session registry belong to the `web` capability, which an app opts | ||
| in (`spec:AST-112/FR3`); an app links the web engine when it opts `web` in. |
There was a problem hiding this comment.
Non-blocking: "an app links the web engine when it opts web in" no longer rules out linking it otherwise, while the FR1 verification row (line 363) still fails a build where "An opted-out app links WebKit". Write "only when it opts web in".
| (`schemes`, `hosts` with `*.<domain>` patterns that match only below a | ||
| public suffix, and whole-segment `pathPrefix`), and an optional title of |
There was a problem hiding this comment.
Non-blocking: "*.<domain> patterns that match only below a public suffix" no longer says what happens when the pattern's own domain is a public suffix (*.co.uk), which the earlier wording ruled out. The FR11 verification row names that state but no failure for it; say that such a pattern matches nothing.
There was a problem hiding this comment.
Approval of the draft spec:AST-131 waits on an engineering owner's decision, and one record fix stands either way.
The record states new requirements (FR1–FR18, DEC-1–DEC-4) that no current record states, and it relies on the draft spec:AST-112 and its open amendment (#12563), spec:AST-140 (#12594) and spec:AST-130 (#12553). An engineering owner records approval by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or holds the record until those records are decided and it is settled whether WebView gets a Core contract or starts under ./unstable/*.
Blocking:
- FR16 (lines 309-311) gives
WebViewandWebContenta required label while the description says their props sit outside this record, so leave the label to the components' own record (or OQ2) or say in the description that FR16 sets it, and state that boundary in Non-goals.
The inline comments carry smaller wording fixes (FR4's one-script list, DEC-4's scope, the Current-state reliances) that do not block.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the open foundation amendment, the system modules record and the shared platform rules: verified, all three pull requests are open.
- Claim: the native view is internal behind
WebView, and./webexportsWebViewandWebContent: verified (FR1). - Claim: the record covers only the web view, its device report and the session handle: verified (Intent, Who uses it).
- Claim: requirements read as present behaviour, keeping the safe defaults, one page script, native cookie values and refused loads: verified; FR4's script list misses the frame protection (non-blocking).
- Claim: Non-goals keeps the template's two standing bullets: verified.
- Claim: decisions state direction and reason, with no rejected alternatives: verified (DEC-1 to DEC-4).
- Claim: contracts grow by named features: verified (FR3, FR13, FR17).
- Claim: no other record owns the web view: verified by a search of the records on
main. - Claim: a navigation no person caused stays in the view: verified (FR5).
- Claim: a load that needs a guarantee the binary cannot keep reports
unsupported: false for capture prevention on iOS and for the message channel without channel isolation (non-blocking). - Claim: on iOS and Android 8.0 and later the app keeps running after a content process end: verified (FR10).
- Claim: the props, layout and states of
WebViewandWebContentsit outside the record: false, FR16 sets a required label (blocking). - Claim: the knowledge check and Prettier pass: verified at this head.
- Claim: rubric R5 lists the records the record cites: false, it lists one the record no longer cites (non-blocking).
- File:
docs/specs/AST-131-react-native-web-view/spec.md: one blocking finding (FR16), non-blocking wording notes.
| view adds one script to a page, its own page script, which carries the | ||
| message channel (FR8), the colour scheme and text scale (FR9), and the | ||
| content height (DEC-2). |
There was a problem hiding this comment.
Non-blocking, Miss: this list leaves out the frame protection above, the page-level protection that FR18 sets against WebKit's private settings. Either this one script carries it, and the list should say so, or the view adds a second script. Also, DEC-2 says nothing about content height; FR9 owns onContentHeight. Name the protection here and cite FR9.
| - Relies on `spec:AST-140` FR5: contracts grow by named features, which the | ||
| platform info module lists (FR3, FR13, FR17). |
There was a problem hiding this comment.
Non-blocking, Miss: the record also rests on spec:AST-140 FR2 (FR15), FR3 (Intent, FR12) and FR9 (Why this exists), and on spec:AST-130 (FR3), none of which is on main. Name them here beside FR5, with the amended spec:AST-112 FR15 the Platform support evidence bullet follows.
There was a problem hiding this comment.
Approval of the draft spec:AST-131 waits on an engineering owner's decision; FR16 no longer sets a label on WebView and WebContent, and no blocking finding remains.
The record adds requirements FR1–FR18 and DEC-1–DEC-4 that no current record states, and it relies on the draft spec:AST-112 and the open #12563, #12594 and #12553. An engineering owner records approval by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or holds the record until those records are decided; that decision also settles whether WebView gets a Core contract or starts under ./unstable/*, and whether FR11 and FR15 may depart from spec:AST-112 FR7's "never a silent no-op".
The inline comments carry non-blocking notes, among them iOS 15 and 16 losing page storage under FR7 and a missing entry for useWebViewSupports.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the open foundation amendment, the system modules record and the shared platform rules: verified, all three pull requests are open.
- Claim: the native view is internal behind
WebView, and./webexportsWebViewandWebContent: verified (FR1). - Claim: the record covers only the web view, its device report and the session handle: verified (Intent, Who uses it).
- Claim: requirements read as present behaviour, keeping the safe defaults, one page script, native cookie values and refused loads: verified; FR4's script list leaves out the frame protection (non-blocking).
- Claim: Non-goals keeps the template's two standing bullets: verified.
- Claim: decisions state direction and reason, with no rejected alternatives: verified (DEC-1 to DEC-4).
- Claim: contracts grow by named features listed through the platform info module: verified (FR3, FR13, FR17).
- Claim: no other record owns the web view: verified by a search of the records on
main. - Claim: a navigation no person caused stays in the view and leaves the view's origin as it was: verified (FR5).
- Claim: an HTML string has an opaque origin until it is granted one: verified (FR5, FR6).
- Claim: sessions cross as handles, with ephemeral views, page storage off and separate page data where the device can: verified (FR7).
- Claim: a load that needs a guarantee the binary cannot keep reports
unsupported: matches DEC-4, but FR11 shows an iOS page with capture prevention unprotected and FR8 loads without channel isolation (non-blocking, part of the owner's decision). - Claim:
textScaledefaults to the system font scale: verified (FR9). - Claim: on iOS and Android 8.0 and later the app keeps running after a content process end: verified (FR10).
- Claim: the private WebKit opt-in is iOS-only and off by default: verified (FR18).
- Claim: the three native pieces are core within the opt-in
webcapability: verified (Intent, FR1, FR18). - Claim: the props, layout and states of
WebViewandWebContentsit outside the record: verified at this head (FR16 sets no label). - Claim: the knowledge check and Prettier pass: verified at this head.
- Claim: rubric R5 lists the records the record cites: false, it lists one the record does not cite (non-blocking).
- Claim: rubric R7 finds one gap line, FR4's: verified.
- File:
docs/specs/AST-131-react-native-web-view/spec.md: no blocking finding; non-blocking notes inline.
| many views ask for it. On iOS the page shows and the binary reports the | ||
| feature with `isSupported` false, so capture prevention there is best | ||
| effort. A caller that requires it checks | ||
| `supports('preventsCapture')` first. |
There was a problem hiding this comment.
Non-blocking, Miss: this loads an iOS page that sets preventsCapture with no protection and no answer. Intent says the record details spec:AST-112 FR7 ("It is never a silent no-op and never a quietly weaker behavior"), and DEC-4 refuses a load whose guarantee the binary cannot keep. Either answer unsupported on iOS, or name this departure in Current-state impact with an open question, as spec:AST-130 does for its hint calls.
| draw their own fallback. The handle's | ||
| `postMessage` does nothing there. |
There was a problem hiding this comment.
Non-blocking, Miss: a postMessage that does nothing is the silent no-op spec:AST-112 FR7 rules out. Give the call a result (such as no-native-view or not-linked), or list it beside FR11's iOS capture prevention as a named departure from FR7.
| - Pages in views without an ephemeral store share the runtime's page data. | ||
| Where the device can keep it apart from the app's network cookies (the | ||
| `pageProfile` constant), it is kept apart. Where it cannot, those pages | ||
| run with page storage off. |
There was a problem hiding this comment.
Non-blocking, Miss: on iOS, WebKit's default store already keeps its cookies apart from the store React Native's networking uses, on every version. Yet Platform support (line 334) makes pageProfile true only on iOS 17 and later, so on iOS 15 and 16 every page outside an ephemeral store runs without localStorage or IndexedDB. Name what the data is kept apart from (another runtime's pages, for instance), or report pageProfile true on every iOS version.
| - The library's `useWebViewSupports(feature)` answers the same, and false | ||
| without a web view. |
There was a problem hiding this comment.
Non-blocking, Miss: FR1's ./web list (lines 91-92) has no useWebViewSupports, so no entry exports this hook. Name its entry in FR1, or drop the hook here and in Who uses it.
There was a problem hiding this comment.
Approval of the draft spec:AST-131 still waits on an engineering owner's decision; no blocking finding remains at this head.
The record adds requirements FR1–FR18 and DEC-1–DEC-4 that no current record states, and the records it rests on are still drafts or open: spec:AST-112 and spec:AST-140 on main, #12553 for spec:AST-130, and #13029 for spec:AST-140/DEC-9. An engineering owner records approval by commenting /approve-spec <full head SHA> on this pull request (the author may, as an engineering owner), or holds the record until those are decided; that decision also settles whether WebView and WebContent start in the stable ./web entry, which spec:AST-112 OQ7 leaves open. The new inline notes are non-blocking: spec:AST-140/DEC-9 is not on main yet, the "(amended)" reliance lines are stale since #12563 merged, and spec:AST-082 FR3 already answers part of OQ2.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record depends on the foundation amendment, the system modules record and the shared platform rules: partly stale; the amendment and the shared rules have merged, the system modules record is open, and the new DEC-9 citation also depends on the open move of the public-API decision (non-blocking).
- Claim: the native view is internal behind
WebView, and./webexportsWebViewandWebContent: verified (FR1, FR2). - Claim: the record covers only the web view, its device report and the session handle: verified (Intent, Who uses it).
- Claim: requirements read as present behaviour, keeping the safe defaults, one page script, native cookie values and refused loads: verified; FR4's script list leaves out the frame protection (non-blocking).
- Claim: Non-goals keeps the template's two standing bullets: verified.
- Claim: decisions state direction and reason, with no rejected alternatives: verified (DEC-1 to DEC-4).
- Claim: contracts grow by named features listed through the platform info module: verified (FR3, FR13, FR17).
- Claim: no other record owns the web view: verified by a search of the records on
main. - Claim: a navigation no person caused stays in the view and leaves the view's origin as it was: verified (FR5).
- Claim: an HTML string has an opaque origin until it is granted one: verified (FR5, FR6).
- Claim: sessions cross as handles, with ephemeral views, page storage off and separate page data where the device can: verified (FR7).
- Claim:
textScaledefaults to the system font scale: verified (FR9). - Claim: on iOS and Android 8.0 and later the app keeps running after a content process end: verified (FR10).
- Claim: a load that needs a guarantee the binary cannot keep reports
unsupported: matches DEC-4, but FR11 shows an iOS page with capture prevention unprotected (non-blocking, part of the owner's decision). - Claim: native code uses public platform API, with one iOS opt-in to private WebKit settings, off by default: verified (FR18); its new decision citation is not on
mainyet (non-blocking). - Claim: the three native pieces are core within the opt-in
webcapability: verified (Intent, FR1, FR18). - Claim: the props, layout and states of
WebViewandWebContentsit outside the record: verified. - Claim: the existing authority searched includes the platform-code record and the foundation amendment as open work: stale, both have merged (non-blocking).
- Claim: the implementation lives in the React Native package's platform layer: not checkable, as no React Native package is on
main. - Claim: the knowledge check and Prettier pass: verified at this head.
- Claim: rubric R5 lists the records the record cites: false, it lists one the record does not cite (non-blocking).
- Claim: rubric R6 and R7 results: verified (OQ1, OQ5 and OQ6 keep options; one FR4 gap line).
- File:
docs/specs/AST-131-react-native-web-view/spec.md: no blocking finding; non-blocking notes inline.
| own record, and this is the web group's. | ||
| - Relies on `spec:AST-112` FR3 (amended): the `web` capability is a device | ||
| feature an app opts in; Astryx's components link by default. | ||
| - Relies on `spec:AST-140/FR9` and `spec:AST-140/DEC-9`: native code uses |
There was a problem hiding this comment.
Non-blocking: spec:AST-140/DEC-9 is not on main. main's spec:AST-140 has DEC-1 to DEC-8, and "DEC-9 — Native code uses public platform API only" exists only in the open #13029; main's FR9 cites spec:AST-112/DEC-15 for the same rule. Cite spec:AST-112/DEC-15 beside FR9 until #13029 lands, or name #13029 among this pull request's dependencies and merge order.
|
|
||
| - Relies on `spec:AST-112` FR1 (amended): the `web` capability holds the web | ||
| view, its device report, and the session registry. | ||
| - Relies on `spec:AST-112` FR5 (amended): native views are internal |
There was a problem hiding this comment.
Non-blocking, Regression: #12563 merged, so FR1, FR3, FR5 and FR7 are main's text and "(amended)" no longer marks anything here. main's FR5 also does not make WebView "the web view's public face": FR16 has a React Native component implement a Core component and leaves where an RN-only component starts to OQ7 (the React Native lab under ./unstable/*, or Core's Lab), while FR1 exports WebView and WebContent from the stable ./web. Drop "(amended)" and name OQ7 as the open dependency.
| (`human-api`) Options: the caller creates the handle with | ||
| `AstryxWebSessions` and passes `session={{sessionId}}`; or `WebView` takes | ||
| the session's options and manages the handle for the caller. | ||
| - **OQ2 — Do `WebView` and `WebContent` expose `preventsCapture`, |
There was a problem hiding this comment.
Non-blocking, Miss: spec:AST-082 FR3 (current) already bounds this question: "A platform never offers a prop it does not fully honor." So WebView cannot offer preventsCapture on iOS, where FR11 makes it best effort, or linkMenu on Android, which lacks it. Say so here, so the question stays open only for allowedExternalSchemes, preventsCapture on Android and linkMenu on iOS.
Depends on #12563 (the
spec:AST-112amendment: default linking and opt-in device features, public platform API, native views internal behind components, named features listed by the platform info module), #12553 (spec:AST-130, the platform info module that lists the named features), and #12594 (spec:AST-140, the shared platform rules).Not stacked. Merges after #12563 (AST-112) and #12594 (AST-140).
Exact decision needed
The target contract of the React Native platform's
webcapability: the native web viewAstryxWebViewbehind the library'sWebView, its device reportAstryxWebViewInfo, and the session-handle part ofAstryxWebSessions, as the recordspec:AST-131(docs/specs/AST-131-react-native-web-view/spec.md) states them. It covers navigation policy, sessions and page storage, the message channel, appearance, content process end, capture prevention, the link menu, accessibility, and the fallbacks whenwebis not linked.This revision
WebView, which is its public face; the./webentry exportsWebViewandWebContentin place of the native view and its probe.webcapability are gone.spec:AST-140/FR5).Existing authority searched
spec:AST-112(React Native foundation) and its open amendment: FR2 (dependencies), FR3 (linking), FR4 (public platform API), FR5 (native views are internal implementation behind components), FR7 (capability shape), FR15 (evidence).spec:AST-140(React Native platform code, open): the shared platform rules this record cites, FR2 (missing piece), FR3 (results), FR5 (contracts grow by named features), FR9 (coexistence).spec:AST-130(system modules, open): the platform info module that lists named features.spec:AST-082(native-first surfaces): FR3 (component contracts), FR13 (dependencies).spec:AST-093(native component guidelines): FR5 (testing and validation).docs/specs/searched forWebView,web view,WebContent: no other record owns the web view.web viewandReact Native platform spec: only this workstream's sibling records.Decision
The record's requirements FR1 to FR18 and DEC-1 to DEC-4:
webis an opt-in capability; the library reaches it through the capability loader.WebViewis the web view's public face, and the native view is internal behind it; the./webentry exportsWebView,WebContent,AstryxWebViewInfo, andAstryxWebSessions.grantsOrigingrants itbaseUrl's.textScaledefaults to the system's font scale; content height for auto-sizing.unsupportedin place of the load.AstryxWebView.<feature>) that each platform's binary lists through the platform info module.AstryxWebView,AstryxWebViewInfo, andAstryxWebSessionsare core, within the opt-inwebcapability, becauseWebViewusesAstryxWebSessionsthrough its session handle (FR7; OQ6 asks whether the module's create and remove calls belong in this record).Who uses it
AstryxWebViewWebView, its public face;WebContent(throughWebView)AstryxWebViewInfoWebViewandWebContent(through the checks before a load); theuseWebViewSupportshook and the capability status ofuseCapabilitiesAstryxWebSessionsWebViewuses it through its session handle (session={{sessionId}}, FR7): the native view resolves the handle; core, within thewebcapabilityEcosystem comparison (moved out of the record)
AstryxWebViewonShouldStartLoadWithRequest,postMessage/onMessage, cookies, file access, downloads, incognito mode), and handles most apps' needs well.AstryxWebViewInfounsupported.AstryxWebSessionssharedCookiesEnabled,incognito).WebViewpasses a session handle, and the cookie values stay native.Rejected alternatives
None recorded. Each decision states its chosen direction and its reason.
Claim scope and non-goals
The record governs the native contracts
AstryxWebViewandAstryxWebViewInfo, the library's internalNativeWebViewbehindWebView, and the handle part ofAstryxWebSessionsthe view uses. The props, layout and states ofWebViewandWebContentsit outside this record; no record defines them yet. Non-goals: the template's two standing bullets only.Evidence and implementation relationship
The implementation lives in the React Native package's platform layer (the
webcapability) and its library components. No public evidence links.Writing rubric results
./testingdoubles).spec:AST-112,spec:AST-140,spec:AST-130,spec:AST-082,spec:AST-093).Scope
Components:
AstryxWebView,AstryxWebViewInfo,NativeWebView(internal),WebViewValidation
pnpm check:knowledge(node scripts/check-knowledge.mjs): "Knowledge templates and records are aligned.", exit 0.--check: all matched files use Prettier code style.pnpm specs:foris not runnable in this checkout (no install); skipped.Follow-up: claims moved from
spec:AST-112Cites
spec:AST-140FR9 and DEC-9 for public platform API, where #13029 movesspec:AST-112FR4's public-API line.