Skip to content

spec(AST-130): React Native platform: System modules - #12553

Draft
imdreamrunner wants to merge 32 commits into
mainfrom
spec/ast-130-react-native-system-modules
Draft

imdreamrunner wants to merge 32 commits into
mainfrom
spec/ast-130-react-native-system-modules

Conversation

@imdreamrunner

@imdreamrunner imdreamrunner commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Not stacked. Merges after #12563 (AST-112), #12594 (AST-140), #12554 (AST-125) and #12551 (Web, AST-131).

Exact decision needed

The observable contract of the React Native platform's system modules: AstryxAppearance, AstryxAccessibilitySettings (iOS), AstryxHaptics, AstryxClipboard, AstryxPlatformInfo, AstryxPermissions, AstryxBack (Android), AstryxLaunch (Android), AstryxFilePicker and AstryxStorage, and the app's cache location. It covers each module's methods, results and reasons, synchronous constants against asynchronous calls, change events and their cleanup, and the named features the contracts grow by.

This revision

  • AstryxPlatformInfo covers the binary's own facts: memory and bundle-size reads are gone from the contract, its platform row and its verification.
  • AstryxStorage serves the router's state as its default store; the update-check use is gone.
  • AstryxPermissions serves the camera capability; photo access is spec:AST-135's.
  • The record states current behaviour in positive terms. Requirements that read as bans now describe what each module does; constraints the platform relies on (one runtime dependency set, public platform API, prompts only on request) stay, stated as behaviour with their reason.
  • Non-goals keeps only the system-spec template's two standing bullets (equivalent internal implementations stay valid; internal mechanisms belong in architecture or implementation).
  • Decisions state the chosen direction and its reason; the one-line rejected alternatives are gone.
  • Versioning reads "contracts grow by named features" (spec:AST-140/FR5).

Existing authority searched

  • spec:AST-112 (React Native foundation): the parent. It sets the platform layer, the result vocabulary, the capability shape (FR7) and the library-to-platform mapping (FR9), and leaves each capability's methods, options and reasons to its group record. This record fills that for the system modules.
  • spec:AST-140 (React Native platform code, open): the shared rules this record cites, FR3 (results), FR5 (contracts grow by named features), FR6 (threads) and FR9 (coexistence).
  • spec:AST-082 (native-first surfaces; dependencies under FR13) and spec:AST-093 (native component guidelines: Reduce Motion, haptics, VoiceOver).
  • spec:AST-108 (theme motion; Reduce Motion limits) and spec:AST-086 (status announcements; the copy confirmation).
  • Exported symbols searched: AstryxAppearance, AstryxAccessibilitySettings, useAccessibilitySettings, AstryxHaptics, useHaptics, AstryxClipboard, useCopy, AstryxPlatformInfo, AstryxPermissions, useCameraPermission, AstryxFilePicker, useFilePicker, AstryxStorage.
  • Open pull requests (gh pr list --state open for the module names, "react native system modules", "react-native spec"): the sibling platform group records of this set (the Web record, AST-131, is open as a draft). None overlaps these modules.

Decision

The record states each module's contract as FR1 to FR18 and relies on the amended spec:AST-112 FR3 and DEC-15 for default linking and public platform API, and on spec:AST-140 FR3, FR5, FR6 and FR9 for the result vocabulary, named features, threading and coexistence:

  • Ten core modules, each read by its own wrapper; AstryxBack and AstryxLaunch are internal, with the library as their one caller.
  • Constants are read once and answered synchronously; every asynchronous call resolves a result with closed per-module reasons.
  • One process-wide store per change event, started by the first subscriber and stopped after the last.
  • One appearance model (preference, session and screen scopes, with the precedence owned by the library and one resolved read); the saved choice applies natively before the first frame, with run-only overrides and an opt-in cold-launch link as named features.
  • Android's root back gate and launch hold are driven by the library.
  • AstryxPlatformInfo reports the binary's app facts, linked capabilities, named features and feature rows.
  • AstryxPermissions serves the camera capability; prompts come only from request.
  • The system pickers; the runtime's namespaced key-value store, which the router uses for its state; the core's app cache location, where file-producing core pieces write and which the system may reclaim.
  • Native code uses public platform API, and each module links the frameworks its platform support row names.

Who uses it

Native piece Kind Astryx components that use it What a person sees
AstryxAppearance native module (Turbo Native Module) AstryxProvider, the theme provider every Astryx component renders under, which applies the app's light or dark override through it; app API (. entry) The app opens in the saved light or dark appearance, with no flash of the system's.
AstryxAccessibilitySettings native module (Turbo Native Module) AstryxProvider and every component styled with createStyles (./styles entry); through the library's system-settings hook also BottomSheet, Popover, Overlay, HoverCard, ContextMenu, Switch, SegmentedControl, ProgressBar, Carousel, TabBar, TopNav, Header, Toolbar, Table, Item, Markdown, SearchField, BarButton, Button and the glass and material surfaces; app API useAccessibilitySettings Drawn bars, sheets and menus turn opaque under Reduce Transparency, show borders under Show Borders, and cross-fade under Reduce Motion.
AstryxHaptics native module (Turbo Native Module) Through the library's moment table (useHaptics): Button, Switch, Slider, SegmentedControl, Selector, TabList, ToggleButton, Toast, BottomSheet, InlineSheet, ContextMenu, ReorderableList, Item swipe actions, Calendar's picker field, DonutChart and the charts A tick on a selection change, a click on a toggle, a bump at a slider's end, a threshold tick in a swipe.
AstryxClipboard native module (Turbo Native Module) PasteButton (reads on the person's press); CodeBlock, Chat message actions and Timestamp through the library's copy hook (useCopy) A copy button shows its check glyph and announces "Copied"; a paste fills the field.
AstryxPlatformInfo native module (Turbo Native Module) Its named-feature probes: every component that renders an Icon (where icon images load), the system menu of ContextMenu, DropdownMenu and Selector, the native presentation host of BottomSheet and modal windows, Item (native swipe-row support), the router's stack navigator (modal presentation kinds, header search field, stack host), and the zoom pager gesture; app API Nothing directly: each component picks the native path the binary has, or its drawn fallback.
AstryxPermissions native module (Turbo Native Module) CameraView (./camera entry) reads camera access through it; app API useCameraPermission The system prompt appears only when the app asks.
AstryxBack native module (Turbo Native Module) Through the library's back handling: AppShell, SearchField, the router's stack navigator (back, modals, header search field), and the dismissible layers BottomSheet, Drawer, Popover, HoverCard, ContextMenu, DropdownMenu, Selector, SplitView, TabMenu, TopNav menus Back closes the open sheet or menu first; at the root, Android plays its back-to-home animation.
AstryxLaunch native module (Turbo Native Module) The router (its root's first state and its first focused screen's layout) and AstryxPerformance.markFirstFrame On Android the launch screen stays until the first screen is drawn, and a cold deep link opens on its own screen.
AstryxFilePicker native module (Turbo Native Module) FileInput through the library's file picker hook (useFilePicker); app API AstryxFilePicker Choosing a file opens the system's photo or document picker; backing out changes nothing.
AstryxStorage native module (Turbo Native Module) The router's state persistence (its default store); app API (./storage entry) After a cold start the app opens on the screen it showed last.
React Native Linking React Native core API Every href the library renders, through its link helper and host services: Link, Button, Chip, ClickableCard, Item, Avatar, Breadcrumbs, Citation, ContextMenu and DropdownMenu items, Markdown links, SideNav, NavMenu and Tab; the router's external links; the camera template's "open Settings" A tapped link opens in the system's browser or the app that owns it; a blocked camera permission opens the app's Settings.
React Native Share React Native core API The library's host services (useHostServices().share), which the create templates' share actions use (assistant, camera, gallery, maps, text feed) The system share sheet opens with the item's text or link.

Ecosystem comparison

The record keeps one conclusion per module under "Why this exists"; the comparison behind it:

Module What the ecosystem does well The gap Astryx fills
AstryxAppearance React Native's Appearance reports the scheme and can override it while JavaScript runs; expo-system-ui sets the root background. A saved choice that the native shell applies before the first frame of every launch, a run-only override, and an opt-in launch link. A choice that JavaScript applies arrives after the first frame, so the window and status bar cross-fade.
AstryxAccessibilitySettings AccessibilityInfo reads Reduce Motion, Reduce Transparency, Bold Text, darker system colours and cross-fade transitions, with change events for most. One synchronous snapshot for the first frame, a change event for every key, and the iOS settings AccessibilityInfo does not read (Reduce Bright Effects, Show Borders). Android uses AccessibilityInfo itself (FR5).
AstryxHaptics Vibration plays patterns; expo-haptics plays UIKit's feedback kinds and Android effects well. Little capability gap. The module plays Android's HapticFeedbackConstants on the view with an API-level chain, needs no Expo runtime library (spec:AST-112/FR11), and lets the theme map moments to kinds (FR6). Scope: OQ1.
AstryxClipboard expo-clipboard and @react-native-clipboard/clipboard read and write text and test for content without reading it. The result vocabulary for the pasteboard, from the package's own native code. Scope: OQ1.
AstryxPlatformInfo expo-device, expo-application and react-native-device-info report the device, the app's version and install time. The binary's own contract facts no library can know: the linked capabilities, the named contract features, per-platform feature rows, and self-checks. Its app constants overlap the ecosystem with no gap.
AstryxPermissions PermissionsAndroid asks on Android; react-native-permissions covers many permissions with blocked and denied states. Little gap. A closed set tied to the camera capability, and not-declared where the system would end the app. Scope: OQ1.
AstryxBack BackHandler delivers Android back presses to JavaScript, and navigators consume them. React Native's activity always takes the back press, so Android's predictive back-to-home animation never plays at the root. The gate gives the press to the system when JavaScript has nothing to consume (FR11).
AstryxLaunch expo-splash-screen holds the splash until the app hides it; Linking.getInitialURL() reads the launch link. The library ends the Android launch hold at its first content with no app code and no Expo runtime library, and the router reads the launch link synchronously, so a cold deep link draws its screen in the first frame (FR12).
AstryxFilePicker expo-image-picker, expo-document-picker, react-native-image-picker and @react-native-documents/picker present the system photo, camera and document pickers well. Little gap: one call over photos and files with the result vocabulary (cancelled is not an error), no permission for the out-of-process photo picker, and no extra dependency. Camera capture belongs to the camera capability (FR12). Scope: OQ1.
AstryxStorage @react-native-async-storage/async-storage and react-native-mmkv store strings and JSON well. Little gap: one string store with the result vocabulary, where the router keeps its state. Scope: OQ1.

Light and dark (OQ3)

The JavaScript path that re-resolves tokens on each flip was measured on iOS and Android; a device measurement of the native path is pending.

Rejected alternatives

None recorded. Each decision states its chosen direction and its reason.

Claim scope and non-goals

The record governs the system modules listed above and the core's app cache location. Non-goals: the template's two standing bullets only.

Evidence and implementation relationship

The implementation lives in the React Native package's platform layer. No public evidence links. The comparison with the React Native ecosystem is summarized as one conclusion per module in "Why this exists"; no survey is in the record.

Writing rubric results

  • R1 narration: none.
  • R2 research in the record: none; the ecosystem comparison stays in this description, and the record keeps one conclusion per module.
  • R3 evidence naming a change: none; Verification cells name tests, Simulator, emulator, and device checks.
  • R4 rejected alternatives over one line or outside a decision: none; the decisions state their direction and reason only.
  • R5 pull request or issue references remaining: none.
  • R6 ruled open questions still listing options: none; OQ1 to OQ3 are unanswered and keep their options.
  • R7 project status (build status or work order): five requirement gaps in the R7 form, no other status: two under FR4 (the theme provider follows React Native's colour scheme alone, and the app writes the scope precedence itself; a link that arrives while the app runs applies its appearance), two under FR12 (the Android picker returns content:// URIs; the iOS picker offers a camera source) and one under FR18 (the core storage module also links WebKit on iOS).

Scope

Components: AstryxAppearance, AstryxAccessibilitySettings, AstryxHaptics, AstryxClipboard, AstryxPlatformInfo, AstryxPermissions, AstryxBack, AstryxLaunch, AstryxFilePicker, AstryxStorage, the app cache location

  • This PR contains specification records only.
  • It records observable behavior and preserves equivalent internal implementations.
  • Any named internal mechanism is intentionally public, names its dependent caller/system, and explains why an equivalent implementation would not satisfy the contract.
  • Verification states the evidence layer and failure signal without prescribing CI job/workflow topology.
  • It records one intentional durable decision, not a rescue for a separable tagalong.
  • The canonical knowledge owner, affected current claims, and overlapping open work are named; any ownership collision is resolved or called out for human decision.
  • Adjacent API, visual, accessibility, composition, and implementation facts remain outside scope unless this exact decision depends on them.
  • Public text and linked material contain no internal Meta context.

Validation

  • pnpm check:knowledge (node scripts/check-knowledge.mjs): "Knowledge templates and records are aligned.", exit 0.
  • Prettier --check on the record: all matched files use Prettier code style.
  • Repository scan of the diff and this description for internal markers: no hard hits.
  • pnpm specs:for was not run (no install in this checkout).

Follow-up: claims moved from spec:AST-112

Cites spec:AST-140 FR9 and DEC-9 for public platform API, where #13029 moves spec:AST-112 DEC-15.

@vercel

vercel Bot commented Nov 18, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 19, 2026 11:47pm UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 18, 2026
@astracat-bot

astracat-bot Bot commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
❓ Needs maintainer input (for maintainers only) Nov 19, 2026, 11:59 PM UTC

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record needs an engineering owner's decision before it can be approved, and it has eight fixes to make whatever that decision is.

Approval waits on an engineering owner approving or amending the new draft requirements FR1–FR20 and DEC-1–DEC-5 of spec:AST-130, whose parent spec:AST-112 is also draft. An engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner.

Blocking fixes:

  • FR16 says every module answers unavailable after a reload, but FR2's closed reason sets give it only to four modules, so AstryxAppearance, AstryxPermissions, AstryxFilePicker and AstryxStorage cannot satisfy both; add it to every module's set or narrow FR16.
  • FR9 closes the permission names to camera, while "Who uses it" says the audio recorder (./microphone entry) reads AstryxPermissions; add microphone with the capability that opts it in, or drop the recorder from that row.
  • Current-state impact lists only the camera and web-engine changes to spec:AST-112 and says the core split is unchanged, but the record also adds seven modules to the parent's FR1 core list, uses ./microphone and ./updates entries its FR5 does not define, and lets haptics, back and launch calls do nothing where its FR7 says a path is "never a silent no-op"; list each change.
  • Callers of AstryxClipboard.setString are told it is deprecated (FR7), which needs an explicit owner decision that names setString. Found by: deprecation rule
  • Callers of the network state's connected are told it is deprecated (FR10), which needs an explicit owner decision that names connected. Found by: deprecation rule
  • Callers of the network state's expensive are told it is deprecated (FR10), which needs an explicit owner decision that names expensive. Found by: deprecation rule
  • Callers of the network state's constrained are told it is deprecated (FR10), which needs an explicit owner decision that names constrained. Found by: deprecation rule
  • The description reports no research for rubric item R2, but "Why this exists" compares twelve modules with about 25 named ecosystem libraries, which R2 counts as a survey; move that table to an artifact linked from the pull request and keep its conclusion in DEC-5.

Also worth fixing: FR13's pick signature leaves out the events option that its iOS paragraph uses for events.onLoading.

Claims and files checked

Review mode: full; reason: no-earlier-review

  • Claim: the record states the twelve modules' contract as twenty requirements. Verified.
  • Claim: it moves camera capture into the parent's camera capability and adds a no-web-engine rule to the parent's core. Verified as stated in Current-state impact; the parent's other changes are unlisted (finding above).
  • Claim: existing records, exported symbols and open pull requests were searched, and none overlaps these modules. Verified; the later sibling drafts defer storage and the file picker to this record.
  • Claim: rubric items R1 and R3 to R7 pass as reported. Verified.
  • Claim: rubric item R2 finds no survey in the record. False (finding above).
  • Claim: the knowledge check passes for this record. Verified at this head.
  • Claim: the Prettier check passes and the whitespace check is clean. Verified at this head.
  • Claim: the pull request contains specification records only. Verified.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: eight blocking findings and one non-blocking finding, above.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record needs an engineering owner's decision before it can be approved, and it still has eight fixes to make whatever that decision is.

Approval waits on an engineering owner approving or amending the new draft requirements FR1–FR20 and DEC-1–DEC-5 of spec:AST-130, whose parent spec:AST-112 is also draft; an engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. The latest commit rewords how Astryx Stage is described and leaves each fix below in place.

Blocking fixes:

  • FR16 says every module answers unavailable after a reload, but FR2's closed reason sets give it only to four modules, so AstryxAppearance, AstryxPermissions, AstryxFilePicker and AstryxStorage cannot satisfy both; add it to every module's set or narrow FR16.
  • FR9 closes the permission names to camera, while "Who uses it" says the audio recorder (./microphone entry) reads AstryxPermissions; add microphone with the capability that opts it in, or drop the recorder from that row.
  • Current-state impact lists only the camera and web-engine changes to spec:AST-112 and says the core split is unchanged, but the record also adds seven modules to the parent's FR1 core list, uses ./microphone and ./updates entries its FR5 does not define, and lets haptics, back and launch calls do nothing where its FR7 says a path is "never a silent no-op"; list each change.
  • Callers of AstryxClipboard.setString are told it is deprecated (FR7), which needs an explicit owner decision that names setString. Found by: deprecation rule
  • Callers of the network state's connected are told it is deprecated (FR10), which needs an explicit owner decision that names connected. Found by: deprecation rule
  • Callers of the network state's expensive are told it is deprecated (FR10), which needs an explicit owner decision that names expensive. Found by: deprecation rule
  • Callers of the network state's constrained are told it is deprecated (FR10), which needs an explicit owner decision that names constrained. Found by: deprecation rule
  • The description reports no research for rubric item R2, but "Why this exists" compares twelve modules with about 25 named ecosystem libraries, which R2 counts as a survey; move that table to an artifact linked from the pull request and keep its conclusion in DEC-5.

Also worth fixing: FR13's pick signature leaves out the events option that its iOS paragraph uses, and DEC-5 reads as already deciding what OQ1 still asks.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record states the twelve modules' contract as twenty requirements and five decisions. Verified.
  • Claim: it moves camera capture into the parent's camera capability and adds a no-web-engine rule to the parent's core. Verified as stated in Current-state impact; the parent's other changes are unlisted (finding above).
  • Claim: existing records, exported symbols and open pull requests were searched, and none overlaps these modules. Verified; the open sibling drafts defer storage, the pickers and permissions to this record.
  • Claim: the "Who uses it" table describes each module's users. Matches the record; its microphone and updates entries feed two findings above.
  • Claim: the rejected alternatives are one line each inside DEC-1, DEC-3 and DEC-4. Verified.
  • Claim: the record carries no evidence links. Verified.
  • Claim: rubric items R1 and R3 to R7 pass as reported. Verified.
  • Claim: rubric item R2 finds no survey in the record. False (finding above).
  • Claim: the knowledge check passes for this record. Verified at this head.
  • Claim: the Prettier check passes and the whitespace check is clean. Verified at this head.
  • Claim: the pull request contains specification records only, with no internal context. Verified.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: eight blocking findings and two non-blocking findings, above.

Automated review (maintainer link)

…review consistency fixes, Light/Dark question

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record needs an engineering owner's decision before it can be approved, and three fixes remain whatever that decision is.

Approval waits on an engineering owner approving or amending the new draft requirements FR1–FR20 and DEC-1–DEC-5 of spec:AST-130, whose parent spec:AST-112 is also draft and whose FR18 and Current-state impact now rest on the parent's amendment in #12563; an engineering owner records the decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner. The latest commit fixes all eight earlier blocking findings.

Blocking fixes:

  • Current-state impact and FR18 cite spec:AST-112 DEC-15, an FR8 revision-1 baseline and an FR12 Astryx Stage version floor that exist only in #12563, so this record should merge only after #12563 lands and main is merged here, or with the pull requests declared as a stack.
  • FR2 still lists version() among the synchronous members, while the amended spec:AST-112 FR7 and FR8 this record relies on drop version() and say no contract carries a revision counter, so drop it or say what it answers.
  • The description says named features are checked through hasContractFeature, but neither this record nor the spec:AST-112 amendment names it (an open sibling record cites FR18 for it), so drop the name or state the check in FR18.

Also worth fixing: DEC-5 still reads as deciding what OQ1 asks, and OQ5's question about theme colours sits outside this record's own non-goals.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record states the system modules' contract as twenty requirements and five decisions. Verified.
  • Claim: it relies on the parent record's amendment for default linking, revision 1 with named features, the Astryx Stage version floor and public API only. Verified as stated; that amendment is not on the main branch yet (first finding).
  • Claim: named features are checked through hasContractFeature. False (third finding).
  • Claim: it moves camera capture into the parent's camera capability and adds the no-web-engine rule to the parent's core. Verified; the record also lists the parent's core-list additions and the no-op departure.
  • Claim: existing records, exported symbols and open pull requests were searched, and none overlaps these modules. Verified: the open sibling React Native records cite this one and claim none of its modules.
  • Claim: the "Who uses it" table describes each module's users. Matches the record.
  • Claim: the ecosystem comparison moved out of the record into the description. Verified; the record keeps one conclusion per module.
  • Claim: the light and dark JavaScript path was measured on iOS and Android. Not checked: no measurement is attached, and it decides nothing in the record.
  • Claim: the rejected alternatives are one line each inside DEC-1, DEC-3 and DEC-4. Verified.
  • Claim: the record carries no evidence links. Verified.
  • Claim: rubric items R1 to R7 pass as reported. Verified.
  • Claim: the knowledge check passes, the Prettier check passes and the whitespace check is clean. Verified at this head.
  • Claim: the pull request contains specification records only, with no internal context. Verified.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: three blocking findings and the non-blocking notes above.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record needs an engineering owner's decision before it can be approved, and four fixes remain whatever that decision is.

Approval waits on an engineering owner approving or amending the new draft requirements FR1–FR20 and DEC-1–DEC-5 of spec:AST-130, which rest on the spec:AST-112 amendment in #12563. An engineering owner records that decision by commenting /approve-spec <full head SHA> on this pull request, and the author may do so as an engineering owner.

Blocking:

  • Current-state impact and FR18 rely on spec:AST-112 FR3, FR8, FR12 and DEC-15 as amended, but that text exists only in the open #12563, so merge main here once #12563 lands or declare the two pull requests as a stack.
  • Miss: FR2, FR8, FR19 and "Why this exists" keep per-component revisions (components, componentRevision(name)), which the amended spec:AST-112 FR8 and DEC-14 this record relies on rule out, so move later component behaviour to named features or have the parent name an exception.
  • Miss: FR2 says AstryxLaunch calls return nothing while FR12's initialURL() answers the launch link synchronously, so narrow FR2's sentence to setRootBackEnabled and firstContent and list initialURL() with the synchronous members.
  • Miss: FR14 requires one file per key, a storage layout no caller depends on that the record's own Non-goals and the description's checklist keep out of a record, so state the persistence property instead or name who depends on it.

Non-blocking: FR10's supports('fetchUntrusted') matches neither FR18's named features nor FR8's feature-row names.

Claims and files checked

Review mode: full; reason: spec-record

  • Not stacked, lands after the parent amendment: stated intent; nothing enforces the order (first blocking point).
  • The decision covers the twelve modules' methods, results, synchronous and asynchronous members, change events, revision-1 baseline with named features, and Astryx Stage: verified in FR1–FR19.
  • The parent record leaves each capability's methods to its own record: verified in the parent's Non-goals.
  • The related current records (native-first surfaces, native guidelines, theme motion, status announcements) are named and current: verified.
  • Exported symbols and open pull requests were searched with no overlap: not checkable beyond this repository; no current record names these modules.
  • The decision summary (wrapper-only reads, synchronous constants, closed reasons, shared change events, native appearance, Android back and launch, pickers, storage, secure bytes, Astryx Stage, public platform API, no web engine): verified, except that per-component revisions undercut the revision-1 baseline (second blocking point).
  • The parent's core list and web-engine changes are listed: verified in Current-state impact.
  • The "Who uses it" table matches the record: verified, identical.
  • The ecosystem comparison stays out of the record: verified.
  • The light and dark measurement: not checked; no measurement is attached and it decides nothing.
  • Rejected alternatives are one line each inside DEC-1, DEC-3 and DEC-4: verified.
  • No public evidence links: verified.
  • Writing rubric results R1–R7: verified.
  • Scope checklist: specification records only, verification without CI topology and no private context verified; every named internal mechanism names its dependent: false for FR14 (fourth blocking point).
  • Knowledge check, Prettier and whitespace checks pass: verified, re-run on this revision.
  • Files: docs/specs/AST-130-react-native-system-modules/spec.md: four blocking points, one non-blocking note.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record still needs an engineering owner's decision before it can be approved, and two fixes remain whatever that decision is.

Approval waits on an engineering owner approving, amending or rejecting the draft requirements FR1–FR18 and DEC-1–DEC-5, including FR4's appearance model, FR18's rule that clearing web view data has no Astryx call, and FR1 keeping the back gate, launch hold and native appearance step in the core with its new fallback for a shell without them. An engineering owner records that decision by commenting /approve-spec with the full head SHA on this pull request; the author is an engineering owner and may do so.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131, spec:AST-139, spec:AST-141 and amended spec:AST-112 clauses (FR1, FR3, FR5, FR15, FR20, DEC-15) that exist only in the open drafts #12594, #12554, #12551, #12579, #12598 and #12563, so merge main here once all six land.
  • Miss: lines 240 and 332 give the launch-link setting and the permission declaration to “the configuration plugin”, which the amended spec:AST-112 this record cites places only in the optional Expo wrapper, so name the app's configuration that the generated native project carries instead.

The description's R7 result, FR2's install-time wording, the iOS cold-launch scene and the fallback for shells without the generated steps are fixed at this head; three non-blocking notes cover the launch link in such a shell, the empty value of the feature lists, and how a named feature is reported and probed.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: not stacked; merges after the AST-112 amendment and the AST-140, AST-125, Stage, Preview and Web drafts. Verified: these are the six open drafts the record cites, and all six are still open, so the first blocking finding stands until they land.
  • Claim: the record covers the ten listed modules and the app's cache location, with methods, results, reasons, synchronous constants, change events and named features. Verified (FR1–FR17).
  • Claim: Astryx Stage and Preview are separate products that conform to these contracts. Verified (Non-goals, lines 116–117).
  • Claim: AST-112 sets the platform layer, the result vocabulary, the capability shape, additive evolution, the library-to-platform mapping and Astryx Stage, and leaves each capability's methods to its own documentation. Verified against AST-112 on main (FR6–FR9, FR12, Non-goals).
  • Claim: the native-first, native guideline, theme motion and status announcement records were searched. Verified: the record conforms to AST-082 FR13, AST-093 FR3, AST-108 FR4 and AST-086 FR1–FR2.
  • Claim: the sibling platform records do not overlap these modules; files, secure storage and client identity are out of scope; capabilities no Astryx component uses are outside the core. Verified (Non-goals, lines 96–108; the web record's page-data rule agrees with FR18).
  • Claim: exported symbols and open pull requests were searched. Not checked: the React Native package is not in this repository.
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15 and on AST-140 FR3, FR5, FR6 and FR9. Verified (lines 43–51, 166, 419, 447, 501–507); it also relies on the amended FR15 and FR20 and on AST-140 FR1–FR2 (lines 131, 206, 494, 508).
  • Claim: wrapper-only reads, launch values read once, synchronous members that never throw, closed per-module reasons, one store per change event. Verified (FR1–FR3); the empty value of the feature lists is unstated (non-blocking).
  • Claim: one appearance model with library-owned precedence and one resolved read, applied natively before the first frame, with run-only overrides and an opt-in cold-launch link as named features. Verified (FR4, FR17); the link's setting names the Expo-only plugin (second blocking finding).
  • Claim: Android's root back gate and launch hold are driven by the library. Verified (FR10, FR11).
  • Claim: each contract's baseline is its first release's shape, with later behaviour as named features checked before use. Verified (FR17, through the AST-140 draft's FR5).
  • Claim: the system pickers, a namespaced key-value store and a core cache location the system may reclaim. Verified (FR12–FR14).
  • Claim: public platform API only and no web engine in the core, with no Astryx call to clear web view data; camera capture belongs to the camera capability. Verified (FR18; lines 101–102, 368–370).
  • Claim: the record changes AST-112 FR1 so that cookies leave the amended core and the camera capability gains camera capture, and adds the no-web-engine rule to FR1 and FR3. Verified (Current-state impact, lines 510–518).
  • Claim: the “Who uses it” table. Verified: identical to the record's table (lines 79–92).
  • Claim: the ecosystem comparison and the light and dark measurement. Not checked: research in the description only; OQ3 stays open in the record.
  • Claim: one-line rejected alternatives in DEC-1, DEC-3 and DEC-4. Verified (lines 562–563, 585–586, 598–599).
  • Claim: writing rubric results R1–R7, including five gap lines. Verified (gap lines 228, 249, 390, 392, 464; no narration, research or pull request references in the record).
  • Claim: the scope checklist. Verified: one record file changes, and it names its dependents and verification layers.
  • Claim: the knowledge check and Prettier pass and the diff has no whitespace errors. Verified at this head.
  • File: the AST-130 system modules record: two blocking findings, three non-blocking notes.

Automated review (maintainer link)

- `get()` answers the platform, the calling runtime's namespace, the per-platform feature rows
(`<capability>.<behaviour>`, with `isSupported` and a note), and the
self-checks of the platform internals the package relies on (`compat`).
`supports(name)` reads a feature row from the last answer and is `null`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss, non-blocking: spec:AST-140/FR5 has this module report each named feature with isSupported false and a note where a platform lacks it, its FR2 has a probe answer from data the binary reports once at start, and the amended spec:AST-112/FR7 gives each capability supports(feature) for its named features. Here supports(name) reads a <capability>.<behaviour> row from the last get() and is null until then, and contractFeatures is a bare list (lines 305–306). Say which report carries a named feature's isSupported and note, and whether this supports is that probe or a renamed read.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This record still needs an engineering owner's decision before it can be approved, and two fixes remain whatever that decision is.

Approval waits on an engineering owner approving, amending or rejecting the draft requirements FR1–FR18 and DEC-1–DEC-5, including FR4's appearance model, FR18's rule that clearing web view data has no Astryx call, and FR1 keeping the back gate, launch hold and native appearance step in the core. An engineering owner records that decision by commenting /approve-spec with the full head SHA on this pull request; the author is an engineering owner and may do so.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131, spec:AST-139, spec:AST-141 and amended spec:AST-112 clauses (FR3, FR15, FR20, DEC-15) that exist only in the open drafts #12594, #12554, #12551, #12579, #12598 and #12563, so merge main here once all six land.
  • Regression: Current-state impact (lines 511–519) still edits a “core's list” in spec:AST-112/FR1, but the amendment in #12563 now lists no modules in FR1 (the group records list them) and names cookies only in FR5's ./network entry, so restate those lines and the description's matching sentence against the amended FR5 and FR7.

The launch-link setting and the permission declaration now follow the amended parent's generated native project, which fixes the last review's second blocking finding; three non-blocking notes cover the launch link in a shell without the generated steps, the synchronous members FR2 leaves out of its list, and how named features are reported and probed.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: not stacked; merges after the AST-112 amendment and the AST-140, AST-125, Stage, Preview and Web drafts. Verified: these are the six open drafts the record cites, and all six are still open and unmerged, so the first blocking finding stands until they land.
  • Claim: the record covers the ten listed modules and the app's cache location, with methods, results, reasons, synchronous constants, change events and named features. Verified (FR1–FR17).
  • Claim: Astryx Stage and Preview are separate products that conform to these contracts. Verified (Non-goals, lines 116–117).
  • Claim: AST-112 sets the platform layer, the result vocabulary, the capability shape, additive evolution, the library-to-platform mapping and Astryx Stage, and leaves each capability's methods to its own documentation. Verified against AST-112 on main (FR6–FR9, FR12, Non-goals).
  • Claim: the native-first, native guideline, theme motion and status announcement records were searched. Verified: the record conforms to AST-082 FR13, AST-093 FR3, AST-108 FR4 and AST-086 FR1–FR2.
  • Claim: the sibling platform records do not overlap these modules; files, secure storage and client identity are out of scope; capabilities no Astryx component uses are outside the core. Verified (Non-goals, lines 96–108; the web record's page-data rule agrees with FR18).
  • Claim: exported symbols and open pull requests were searched. Not checked: the React Native package is not in this repository.
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15 and on AST-140 FR3, FR5, FR6 and FR9. Verified (lines 43–51, 166, 420, 448, 502–508); it also relies on the amended FR15 and FR20 and on AST-140 FR1 (lines 131, 206, 464, 495, 509).
  • Claim: wrapper-only reads, launch values read once, synchronous members that never throw, closed per-module reasons, one store per change event. Verified (FR1–FR3); FR2's list leaves out some synchronous members (non-blocking).
  • Claim: one appearance model with library-owned precedence and one resolved read, applied natively before the first frame, with run-only overrides and an opt-in cold-launch link as named features. Verified (FR4, FR17).
  • Claim: Android's root back gate and launch hold are driven by the library. Verified (FR10, FR11).
  • Claim: each contract's baseline is its first release's shape, with later behaviour as named features checked before use. Verified (FR17, through the AST-140 draft's FR5).
  • Claim: the system pickers, a namespaced key-value store and a core cache location the system may reclaim. Verified (FR12–FR14).
  • Claim: public platform API only and no web engine in the core, with no Astryx call to clear web view data; camera capture belongs to the camera capability. Verified (FR18; lines 101–102, 369–371).
  • Claim: the record changes AST-112 FR1 so that cookies leave the amended core list and the camera capability gains camera capture, and adds the no-web-engine rule to FR1 and FR3. False against the current amendment: its FR1 has no core list, and cookies remain only in FR5's network entry (second blocking finding).
  • Claim: the “Who uses it” table. Verified: identical to the record's table (lines 79–92).
  • Claim: the ecosystem comparison and the light and dark measurement. Not checked: research in the description only; OQ3 stays open in the record.
  • Claim: one-line rejected alternatives in DEC-1, DEC-3 and DEC-4. Verified (lines 563–564, 586–587, 599–600).
  • Claim: writing rubric results R1–R7, including five gap lines. Verified (gap lines 228, 250, 391, 393, 465; no narration, research or pull request references in the record).
  • Claim: the scope checklist. Verified: one record file changes, and it names its dependents and verification layers.
  • Claim: the knowledge check and Prettier pass and the diff has no whitespace errors. Verified at this head.
  • File: the AST-130 system modules record: two blocking findings, three non-blocking notes.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner's decision on the draft requirements FR1–FR18 and DEC-1–DEC-5, including FR4's appearance model, FR18's rule that clearing web view data has no Astryx call, FR1 keeping the back gate, launch hold and native appearance step in the core, and FR17's baseline, and one fix remains whatever that decision is. An engineering owner records that decision by commenting /approve-spec with the full head SHA on this pull request; the author is an engineering owner and may do so.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131, spec:AST-139, spec:AST-141 and amended spec:AST-112 clauses (FR3, FR7's group table, FR15, FR20, DEC-15) that exist only in the open drafts #12594, #12554, #12551, #12579, #12598 and #12563, so merge main here once all six land.

Current-state impact now states its relation to the amended parent's FR5 and FR7, which fixes the last review's second blocking finding. Non-blocking: the amendment in #12563 now fixes a contract's baseline only at the first release after the package leaves the canary channel while FR17 (line 447) keeps the first release, and three earlier notes stand (the launch link in a shell without the generated steps, the synchronous members FR2 leaves out of its list, and how named features are reported and probed).

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: not stacked; merges after the AST-112 amendment and the AST-140, AST-125, Stage, Preview and Web drafts. Verified: these are the six open drafts the record cites, and all six are still open and unmerged, so the blocking finding stands until they land.
  • Claim: the record covers the ten listed modules and the app's cache location, with methods, results, reasons, synchronous constants, change events and named features. Verified (FR1–FR17).
  • Claim: Astryx Stage and Preview are separate products that conform to these contracts. Verified (Non-goals, lines 116–117).
  • Claim: AST-112 sets the platform layer, the result vocabulary, the capability shape, additive evolution, the library-to-platform mapping and Astryx Stage, and leaves each capability's methods to its own documentation. Verified against AST-112 on main (FR6–FR9, FR12, Non-goals).
  • Claim: the native-first, native guideline, theme motion and status announcement records were searched. Verified: the record conforms to AST-082 FR13, AST-093 FR3, AST-108 FR4 and AST-086 FR1–FR2.
  • Claim: the sibling platform records do not overlap these modules; files, secure storage and client identity are out of scope; capabilities no Astryx component uses are outside the core. Verified (Non-goals, lines 96–108; the web record's page-data rule agrees with FR18).
  • Claim: exported symbols and open pull requests were searched. Not checked: the React Native package is not in this repository.
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15 and on AST-140 FR3, FR5, FR6 and FR9. Verified (lines 43–51, 166, 420, 448, 502–508); it also relies on the amended FR7, FR15 and FR20 and on AST-140 FR1 (lines 131, 206, 464, 495, 509–516).
  • Claim: wrapper-only reads, launch values read once, synchronous members that never throw, closed per-module reasons, one store per change event. Verified (FR1–FR3); FR2's list leaves out some synchronous members (non-blocking).
  • Claim: one appearance model with library-owned precedence and one resolved read, applied natively before the first frame, with run-only overrides and an opt-in cold-launch link as named features. Verified (FR4, FR17).
  • Claim: Android's root back gate and launch hold are driven by the library. Verified (FR10, FR11).
  • Claim: each contract's baseline is its first release's shape, with later behaviour as named features checked before use. Verified against the AST-140 draft's FR5; the amended AST-112 FR8 now fixes the baseline only after the package leaves the canary channel (non-blocking).
  • Claim: the system pickers, a namespaced key-value store and a core cache location the system may reclaim. Verified (FR12–FR14).
  • Claim: public platform API only and no web engine in the core, with no Astryx call to clear web view data; camera capture belongs to the camera capability. Verified (FR18; lines 101–102, 369–371).
  • Claim: the record is the System modules group record the amended AST-112 FR7 names, changes its FR5 so the network entry and its cookies leave the app API, places camera capture with the camera capability, and keeps web engines out of the core. Verified against the amendment's FR7 table and FR5 (lines 511–518).
  • Claim: the “Who uses it” table. Verified: the same rows as the record's table (lines 79–92), apart from column padding.
  • Claim: the ecosystem comparison and the light and dark measurement. Not checked: research in the description only; OQ3 stays open in the record.
  • Claim: one-line rejected alternatives in DEC-1, DEC-3 and DEC-4. Verified (lines 562–563, 585–586, 598–599).
  • Claim: writing rubric results R1–R7, including five gap lines. Verified (gap lines 228, 250, 391, 393, 465; no narration, research or pull request references in the record).
  • Claim: the scope checklist. Verified: one record file changes, and it names its dependents and verification layers.
  • Claim: the knowledge check and Prettier pass and the diff has no whitespace errors. Verified at this head.
  • File: the AST-130 system modules record: one blocking finding, four non-blocking notes.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner's decision on the draft requirements FR1–FR18 and DEC-1–DEC-5 of spec:AST-130, and four fixes remain whatever that decision is.

Owner decision. Every requirement in this record is new, and its parent spec:AST-112 is still draft on main, so no current record covers them. An engineering owner approves, amends or rejects FR1–FR18 and DEC-1–DEC-5 as written, in particular FR4's appearance model, FR18's handoff of web view data to the web capability and FR1's weaker path for apps whose shell lacks the native steps, by commenting /approve-spec <full head SHA> on this pull request; the author is an engineering owner and may record it.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131 and the amended spec:AST-112 (FR3, FR7's group table, FR15, FR20, DEC-15), which exist only in the open drafts #12594, #12554, #12551 and #12563, so merge main here once those land.
  • “Why this exists” (lines 66–68) and the description say AstryxPermissions serves the camera and photo capabilities, but FR9 closes its set at camera and spec:AST-135 (#12572) keeps photo access in AstryxPhotoLibrary, so say “tied to the camera capability” or add photos to FR9.
  • Regression: Current-state impact (lines 477–478) says this record removes the ./network entry from the amended spec:AST-112/FR5, but #12563 has since dropped that entry, so drop the line or state it as matching the amended FR5.
  • Current-state impact (lines 481–482) says the record details an exception to spec:AST-112/FR7 for the hint calls that return no value, but FR7 names no exception (“never a silent no-op”) and OQ2 asks whether it should, so restore “Departs from spec:AST-112/FR7”.

The non-blocking notes are inline, chiefly FR18's web view data, which spec:AST-131 has no call to remove.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the AST-112, AST-140, AST-125 and Web drafts and is not stacked: verified; all four are open drafts the record cites (blocking 1).
  • Claim: platform info covers only the binary's own facts, with the memory and bundle-size reads gone: verified (FR8, the support table, Verification).
  • Claim: storage serves the router's state and the update-check use is gone: verified (FR13, “Who uses it”).
  • Claim: permissions serve the camera and photo capabilities: false; FR9 names camera only (line 300; blocking 2).
  • Claim: behaviour is stated in positive terms, keeping the dependency, public-API and prompt constraints: verified, except Current-state impact's FR7 line (blocking 4).
  • Claim: Non-goals keep only the template's two standing bullets: verified against the system-spec template.
  • Claim: decisions state direction and reason, with the rejected-alternative lines gone: verified (DEC-1 to DEC-5).
  • Claim: versioning reads “contracts grow by named features”: verified (FR17, Current-state impact); two “baseline” mentions remain (lines 456, 506).
  • Claim: the shared rules cited are AST-140 FR3, FR5, FR6 and FR9: partly; the record also cites FR1 and FR2 (line 111).
  • Claim: no open pull request overlaps these modules: false; the Photos draft (#12572) cites FR9 and FR12 (blocking 2).
  • Claim: the ecosystem table's requirement references: false for two rows; the back gate is FR10, not FR11, and the launch hold FR11, not FR12.
  • Claim: the writing rubric results, five requirement gaps under R7: verified (two under FR4, two under FR12, one under FR18).
  • Claim: the knowledge check and the Prettier check pass: verified, both exit 0 at this head.
  • Claim: the JavaScript light and dark path was measured on iOS and Android: not verifiable from the repository; no requirement rests on it.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: blocking findings 1–4 and the inline notes.

Automated review (maintainer link)

Comment on lines +428 to +429
for it. The web engine and the web view's data belong to the `web`
capability (`spec:AST-131`).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: spec:AST-131 (#12551) has no call that removes web view data; its FR7 covers ephemeral sessions and page storage only. The gap below says the iOS storage module removes that data today, so after the gap closes it has no stated home. Name the AST-131 call that takes it over, or say again that clearing web view data has no Astryx call. The support table's AstryxStorage and cache-location cells (lines 444–445) name directories, not frameworks, so this check has no list for them.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner's decision on the draft requirements FR1–FR18 and DEC-1–DEC-5 of spec:AST-130, and two fixes remain whatever that decision is.

Owner decision. Every requirement in this record is new, and its parent spec:AST-112 is still draft on main, so no current record covers them. An engineering owner approves, amends or rejects FR1–FR18 and DEC-1–DEC-5 as written, in particular FR4's appearance model, FR18's handoff of web view data to the web capability and FR1's weaker path for apps whose shell lacks the native steps, by commenting /approve-spec <full head SHA> on this pull request; the author is an engineering owner and may record it.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131 and the amended spec:AST-112 (FR3, FR7's group table, FR15, FR20, DEC-15), which exist only in the open drafts #12594, #12554, #12551 and #12563, so merge main here once those land.
  • Miss: FR11 (lines 329–331) and “Who uses it” (line 90) end Android's launch hold through AstryxPerformance.markFirstFrame, which no record defines, so an app on another router has no defined call and keeps its launch screen for the full 2.5 seconds; define it here, cite the record that does, or say how such an app ends the hold.

The camera-only permission set, the dropped ./network line and the restated FR7 departure resolve the earlier findings on those lines; the remaining non-blocking notes are inline, chiefly FR18's web view data, which spec:AST-131 has no call to remove.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the AST-112, AST-140, AST-125 and Web drafts and is not stacked: verified; all four are open drafts the record cites (blocking 1).
  • Claim: platform info covers only the binary's own facts, with the memory and bundle-size reads gone: verified (FR8, the support table, Verification).
  • Claim: storage serves the router's state and the update-check use is gone: verified (FR13, “Who uses it”).
  • Claim: permissions serve the camera capability and photo access belongs to the Photos record: verified (lines 66–68, FR9 line 300; the Photos draft agrees).
  • Claim: behaviour is stated in positive terms, keeping the dependency, public-API and prompt constraints: verified (FR2, FR9, FR18, DEC-5).
  • Claim: Non-goals keep only the template's two standing bullets: verified against the system-spec template.
  • Claim: decisions state direction and reason, with the rejected-alternative lines gone: verified (DEC-1 to DEC-5).
  • Claim: versioning reads “contracts grow by named features”: verified (FR17, line 414); two “baseline” mentions remain (lines 456, 505).
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15 and on AST-140 FR3, FR5, FR6 and FR9: partly; it also cites the amended FR15 and FR20 and AST-140 FR1 and FR2 (lines 111, 184, 460, 473).
  • Claim: the “Who uses it” table names each module's users: partly; its AstryxLaunch row names AstryxPerformance.markFirstFrame, which no record defines (blocking 2).
  • Claim: no open pull request overlaps these modules: verified for the sibling group records; the Photos draft cites FR9, FR12 and FR14 and agrees with the camera-only set.
  • Claim: the ecosystem table's requirement references: false for two rows; the back gate is FR10, not FR11, and the launch hold FR11, not FR12.
  • Claim: the writing rubric results, with five requirement gaps under R7: verified (two under FR4, two under FR12, one under FR18).
  • Claim: the knowledge check and the Prettier check pass: verified, both exit 0 at this head.
  • Claim: the diff and description carry no private references: verified, none found.
  • Claim: the JavaScript light and dark path was measured on iOS and Android: not verifiable from the repository; no requirement rests on it.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: blocking findings 1–2 and the inline notes.

Automated review (maintainer link)

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner's decision on the draft requirements FR1–FR18 and DEC-1–DEC-5 of spec:AST-130, and one fix remains whatever that decision is.

Owner decision. Every requirement in this record is new, and its parent spec:AST-112 is still draft on main, so no current record covers them. An engineering owner approves, amends or rejects FR1–FR18 and DEC-1–DEC-5 as written, in particular FR4's appearance model, FR11's new AstryxPerformance.markFirstFrame() app call and FR18's handoff of web view data to the web capability, by commenting /approve-spec <full head SHA> on this pull request; the author is an engineering owner and may record it.

Blocking:

  • The record cites spec:AST-140, spec:AST-125, spec:AST-131 and the amended spec:AST-112 (FR3, FR7's group table, FR15, FR20, DEC-15), which exist only in the open drafts #12594, #12554, #12551 and #12563, so merge main here once those land.

FR11 now defines AstryxPerformance.markFirstFrame() for an app on another router, which resolves the earlier finding on the undefined call; two inline notes cover that call's place in FR2, OQ2 and FR11's Verification row.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the AST-112, AST-140, AST-125 and Web drafts and is not stacked: verified; all four are open drafts the record cites (the blocking finding).
  • Claim: the decision covers each module's methods, results, reasons, synchronous constants, change events and named features: verified (FR1–FR4, FR14, FR17).
  • Claim: platform info covers only the binary's own facts, with the memory and bundle-size reads gone: verified (FR8; neither read appears).
  • Claim: storage serves the router's state and the update-check use is gone: verified (FR13; no update-check use appears).
  • Claim: permissions serve the camera capability and photo access belongs to the Photos record: verified (Why this exists, FR9; the Photos draft agrees).
  • Claim: behaviour is stated in positive terms, keeping the dependency, public-API and prompt constraints: verified (FR2, FR9, FR18, DEC-5).
  • Claim: Non-goals keep only the template's two standing bullets: verified against the system-spec template.
  • Claim: decisions state direction and reason, with the rejected-alternative lines gone: verified (DEC-1 to DEC-5).
  • Claim: versioning reads "contracts grow by named features": verified (FR17).
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15 and on AST-140 FR3, FR5, FR6 and FR9: partly; it also cites the amended FR15 and FR20 and AST-140 FR1 and FR2.
  • Claim: the decision summary (ten core modules with internal back and launch modules, synchronous constants, one store per change event, the appearance model, the library-driven back gate and launch hold, platform info, camera permissions, pickers, storage, the cache location, public platform API): verified (FR1–FR18); an app on another router reaches the launch hold through markFirstFrame(), which the library forwards (FR11).
  • Claim: the "Who uses it" table names each module's users: partly; its launch row still lists markFirstFrame as a library caller, where the record now makes it an app call for other routers.
  • Claim: the exported symbols searched: partly; the list leaves out AstryxPerformance, which FR11 now defines.
  • Claim: no open pull request overlaps these modules: verified; no open React Native draft defines AstryxPerformance, and the Photos draft cites FR9, FR12 and FR14 consistently.
  • Claim: the ecosystem table's requirement references: false for two rows; the back gate is FR10, not FR11, and the launch hold FR11, not FR12.
  • Claim: the writing rubric results, with five requirement gaps under R7: verified (two under FR4, two under FR12, one under FR18).
  • Claim: the knowledge check and the Prettier check pass: verified, both exit 0 at this head.
  • Claim: the diff and description carry no private references: verified, none found.
  • Claim: the JavaScript light and dark path was measured on iOS and Android: not verifiable from the repository; no requirement rests on it.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: the blocking finding and the inline notes.

Automated review (maintainer link)

Comment on lines +335 to +336
`firstContent()`. An app on the Astryx router makes no call. On iOS, and
where the module is absent, it returns at once.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: markFirstFrame() returns nothing and does nothing on iOS or where the module is absent, but FR2's no-value calls (lines 156–159), the departure from spec:AST-112/FR7 (lines 484–486) and OQ2 (lines 578–584) name only the haptics calls and the internal back and launch hints. Add AstryxPerformance.markFirstFrame() to FR2's list and to OQ2, so the stated departure covers the one app-facing call among them.

| FR8 | Unit tests; Simulator and emulator reads | constants; `get()` | A constant throws, or `get()` answers a feature row the binary does not report |
| FR9 | Unit tests; Simulator and emulator prompts | each state; undeclared permission; a busy prompt; module absent on each platform | A mount prompts, a `blocked` permission prompts, or an undeclared permission crashes |
| FR10 | Unit tests of the back gate; emulator runs on Android 16 | an open sheet; a navigator that can go back; the root; before the first call | The back-to-home animation does not play at the root, or a press with a consumer reaches the system |
| FR11 | Unit tests of the once-per-runtime report and the synchronous link; emulator cold launches | a launch with and without a link; a launch that never reports | An empty root frame shows before the first content, the hold never ends, or a cold deep link draws another screen first |

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking: this row has no state for an app on another router that calls AstryxPerformance.markFirstFrame() (FR11, lines 332–336). Add it to the representative states, with a failure such as the hold outliving that call.

@astracat-bot astracat-bot Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval waits on an engineering owner's decision on the draft requirements FR1–FR18 and DEC-1–DEC-5 of spec:AST-130, and two fixes remain whatever that decision is.

Owner decision. Every requirement in this record is new, and its parents spec:AST-112 and spec:AST-140 are draft on main, so no current record covers them. An engineering owner approves, amends or rejects FR1–FR18 and DEC-1–DEC-5 as written by commenting /approve-spec <full head SHA> on this pull request; the author is an engineering owner and may record it.

Blocking:

  • Line 476 now cites spec:AST-140/DEC-9, which exists only in the open draft #13029, and lines 201, 228 and 434 cite spec:AST-125 and spec:AST-131, which exist only in #12554 and #12551, so cite spec:AST-140/FR9 alone at line 476 and merge main here once those two land (or declare a stack).
  • The description still says the record relies on spec:AST-112 DEC-15 for public platform API, calls spec:AST-140 open although it and the spec:AST-112 amendment have merged, and names FR11 and FR12 for the back gate and launch hold, which are FR10 and FR11 in the record.

The citations of the amended spec:AST-112 and of spec:AST-140 now resolve on main.

Claims and files checked

Review mode: full; reason: spec-record

  • Claim: the record merges after the AST-112, AST-140, Navigation hosts and Web drafts and is not stacked: partly; the AST-112 amendment and AST-140 have merged, the other two are open, and the record now also cites AST-140 DEC-9 from a fifth open draft that this list leaves out.
  • Claim: the decision covers each module's methods, results, reasons, synchronous constants, change events and named features: verified (FR1–FR4, FR14, FR17).
  • Claim: platform info covers only the binary's own facts, with the memory and bundle-size reads gone: verified (FR8; neither read appears).
  • Claim: storage serves the router's state and the update-check use is gone: verified (FR13).
  • Claim: permissions serve the camera capability and photo access belongs to the Photos record: verified (FR9; the Photos draft agrees).
  • Claim: behaviour is stated in positive terms, keeping the dependency, public-API and prompt constraints: verified (FR2, FR9, FR18, DEC-5).
  • Claim: Non-goals keep only the template's two standing bullets: verified.
  • Claim: decisions state direction and reason, with no rejected-alternative lines: verified (DEC-1 to DEC-5).
  • Claim: versioning reads "contracts grow by named features": verified (FR17).
  • Claim: the record relies on the amended AST-112 FR3 and DEC-15, and on AST-140 FR3, FR5, FR6 and FR9: false; for public platform API it now relies on AST-140 FR9 and DEC-9 and cites no DEC-15, and it also cites AST-140 FR1 and FR2.
  • Claim: AST-140 is an open pull request: false; it merged before this head.
  • Claim: the decision summary (ten core modules, synchronous constants, one store per change event, the appearance model, the library-driven back gate and launch hold, platform info, camera permission, pickers, storage, the cache location, public platform API): verified (FR1–FR18).
  • Claim: the "Who uses it" table names each module's users: verified, except that the launch row does not say the first-frame call is the app's call for another router.
  • Claim: the ecosystem table's requirement references: false for two rows; the back gate is FR10, not FR11, and the launch hold is FR11, not FR12.
  • Claim: no open pull request overlaps these modules: verified; the Media and camera and Photos drafts cite this record and define none of its modules.
  • Claim: the writing rubric results, with five requirement gaps under R7: verified (two under FR4, two under FR12, one under FR18).
  • Claim: the knowledge check and the Prettier check pass: verified, both exit 0 at this head.
  • Claim: the diff and description carry no private references: verified, none found.
  • Claim: the JavaScript light and dark path was measured on iOS and Android: not verifiable from the repository; no requirement rests on it.
  • Claim: the public-platform-API citation follows the AST-112 slimming draft's move of DEC-15 to AST-140 DEC-9: verified; that draft adds DEC-9 with DEC-15's text and decider, and main does not have it yet.
  • File docs/specs/AST-130-react-native-system-modules/spec.md: the two blocking findings and the inline notes.

Automated review (maintainer link)

every module of this group is core.
- Relies on `spec:AST-140` FR5: contracts grow by named features, which the
platform info module reports.
- Relies on `spec:AST-140/FR9` and `spec:AST-140/DEC-9`: native code uses

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec:AST-140/DEC-9 exists only in the open draft #13029. On main, AST-140 has DEC-1 to DEC-8, and its FR9 already carries this rule ("Native code calls public platform API (spec:AST-112/DEC-15)"). The description's merge order does not name #13029, so if this merges first, the line points to a decision main does not have. Cite spec:AST-140/FR9 alone: its public-API line holds before and after #13029 lands.

This branch was successfully deployed

1 active deployment
Preview — 7d9eccb0 Deployed Nov 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant