Skip to content

spec(AST-112): keep the package's shape; move the rest to its owners - #13029

Merged
imdreamrunner merged 3 commits into
mainfrom
spec/ast-112-slim
Nov 20, 2026
Merged

imdreamrunner merged 3 commits into
mainfrom
spec/ast-112-slim

Conversation

@imdreamrunner

@imdreamrunner imdreamrunner commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

spec:AST-112 keeps only the React Native package's shape: the package set, the two layers and their dependency rules, default linking, where native code lives, the public entries, the capability shape, building on core, the build system, the release train, the evidence bar, accessibility, and where each native piece lives. Everything else moves to the record on main that owns it, or is removed. A new draft record, spec:AST-142 (React Native commands), takes the astryx rn CLI.

Exact decision needed

Whether spec:AST-112's claims move to the new spec:AST-142 and to spec:AST-140, or leave the record, as listed under Decision. Every moved decision keeps its decider and date.

Existing authority searched

Decision

docs/specs/AST-112-react-native-foundation/spec.md (spec:AST-112):

  • Removed, with no mention left: FR6, FR8 and FR22, which only pointed to spec:AST-140; FR17; the Platform asks section; FR5's line on names . does not export; FR18 (gesture arbitration) and FR21 (glass and materials), each with its verification row; FR2's two router lines; FR7's group table and the line that introduces it; the Current-state entry on the group records. References to FR6 and FR8 now point to spec:AST-140 FR3 and FR5 (DEC-4 to spec:AST-140 DEC-5). FR8's canary note stays as a line under FR7.
  • No record cites a spec that is not on main, other than spec:AST-142, which this pull request adds. Pointers to removed claims are dropped (FR2's recognizer line, FR5's router line and the ./controls line, DEC-9, and the end of the spec:AST-082 DEC-2 entry); FR20's coexistence pointer cites spec:AST-140/FR9.
  • FR16 folds into FR10: each React Native component implements a Core component with core's name and contract, a React Native–only component starts where OQ7 says, and a shortfall is a gap line in the component's own record. FR10's verification row takes FR16's check.
  • FR13, DEC-6, OQ5, OQ6, FR13's verification row, the six CLI Current-state entries (@astryxdesign/cli, spec:AST-114 ×3, spec:AST-042, architecture:cli-surface), and the ./commands lines of FR2 and FR5 move to the new spec:AST-142 as FR1, DEC-1, OQ1, OQ2, FR1's row and its Current-state impact. DEC-1 keeps Decider: imdreamrunner, 2026-11-17. FR1 of spec:AST-112 keeps one line: the React Native commands are the astryx rn group, which spec:AST-142 specifies; FR5 keeps a one-line pointer for the ./commands entry. affects_architecture and affects_consumer_docs move with them.
  • DEC-22 is removed: spec:AST-140 DEC-6 already decides it. Its FR4 requirement lines become spec:AST-140 FR9 lines that cite DEC-6, with their two verification rows. The library's code now meets its five gap lines, so they do not move; FR9 gains one gap line for what remains: VideoView's full-screen presentation on iOS uses React Native's Modal.
  • DEC-21, with its FR3 line and verification row, moves to spec:AST-140 as DEC-10 and an FR9 line (Decider: imdreamrunner, 2026-11-19). The code now meets its gap line, so the gap line does not move.
  • Facts spec:AST-140 states are removed: FR2's motion line (spec:AST-140 FR6, which gains the line's clause that the feel follows spec:AST-107 and spec:AST-108), and FR2's third-party coexistence line (spec:AST-140 FR9, which gains its compatibility test, its haptics library and its inset agreement, and their failures in FR9's verification row). FR2 keeps "no third-party native dependency". FR4's public-API line and DEC-15 move to spec:AST-140 FR9 and DEC-9 (Decider: imdreamrunner, 2026-11-17), and FR4's public-API check moves to FR9's first verification row.
  • Stay as on main: DEC-9 (without pointers to removed claims), DEC-10 and its Intl and unsupported-platform lines, DEC-18 and its non-goal, FR23, DEC-20 (Decider: cixzhang, 2026-11-18) and the spec:AST-017 FR27 entry, and the spec:AST-082 DEC-2 Current-state entry (Decider: cixzhang, 2026-11-18) without its pointer to the removed FR21.
  • The Verification table re-pads, because its widest rows moved or lost text.

docs/specs/AST-140-react-native-platform-code/spec.md (spec:AST-140): FR6 gains the motion-feel clause; FR9 gains the moved lines, the VideoView gap line, DEC-9 and DEC-10, and three verification rows. It drops its citations of spec:AST-112 FR18 and FR22 and of the group records: the "Platform group records" section, the group-record line under "Related records", the Current-state line on the group records, and the spec:AST-130 citations in FR4 and FR5; the Intent and "Why this exists" lines keep their rule without the pointer. DEC-15's citation points to DEC-9. The branch is rebased on main after #12988, whose text is kept where the two met (the Verification table).

docs/specs/AST-114-bases/spec.md (spec:AST-114): its Non-goals line on React Native platform commands cites spec:AST-142 FR1 and OQ1 instead of spec:AST-112 FR13 and OQ5.

docs/specs/AST-142-react-native-commands/spec.md (spec:AST-142, new, draft, owners [imdreamrunner]): the astryx rn group, as moved. It is a separate record because the commands are a CLI surface: they follow spec:AST-114, spec:AST-042 and architecture:cli-surface, and a CLI change no longer edits the package record.

Open drafts

The open drafts state the removed claims in their own records: #12562 (gesture arbitration), #12557, #12817 and #12820 (glass and surface), #12554 (the router) and #12596 (the lab start). Citation-only updates went to #12867, #12850, #12838, #12834, #12822 and #12686 (FR10 for web parity), #12555 (FR5 for internal views), and #12553, #12552 and #12551 (spec:AST-140 FR9 and DEC-9 for public platform API).

Drafts that cite spec:AST-112 FR21 for render keep those lines for their own render fixes.

Rejected alternatives

None recorded in the records.

Claim scope and non-goals

Only the moves and removals above. The contracts bullet, OQ2, OQ3 and OQ8 stay. No moved rule changes its content.

Evidence and implementation relationship

The records are specifications only and have no implementation in this pull request.

Writing rubric results

  • R1 narration: none; the records are in the present tense.
  • R2 research in the record: none.
  • R3 evidence naming a change: none.
  • R4 rejected alternatives over one line or outside a decision: none; no Rejected: lines.
  • R5 pull request or issue references remaining: none in the records.
  • R6 ruled open questions still listing options: none; spec:AST-142 OQ1 and OQ2 and spec:AST-112 OQ2, OQ3, OQ7 and OQ8 are unanswered and keep their options.
  • R7 project status (build status or work order): none added; the one FR9 gap line keeps the FRn gap: form.

Scope

  • This PR contains specification records only.
  • It records observable behavior and preserves equivalent internal implementations.
  • Any named internal mechanism is intentionally public, names its dependent caller/system, and explains why an equivalent implementation would not satisfy the contract.
  • Verification states the evidence layer and failure signal without prescribing CI job/workflow topology.
  • It records one intentional durable decision, not a rescue for a separable tagalong.
  • The canonical knowledge owner, affected current claims, and overlapping open work are named; any ownership collision is resolved or called out for human decision.
  • Adjacent API, visual, accessibility, composition, and implementation facts remain outside scope unless this exact decision depends on them.
  • Public text and artifacts contain no internal Meta context.

Validation

  • node scripts/check-knowledge.mjs: knowledge templates and records are aligned (exit 0), here and on each open draft above.
  • Prettier: --check clean on every changed record.
  • git diff --check: clean.

@vercel

vercel Bot commented Nov 19, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Nov 20, 2026 2:17am UTC

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Nov 19, 2026
@astracat-bot

astracat-bot Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Contributor

AI review status for this pull request.

Review status Updated
🔄 In progress (for maintainers only) Nov 20, 2026, 2:01 AM UTC

@cixzhang

Copy link
Copy Markdown
Contributor

/approve-spec 459e440

@imdreamrunner

Copy link
Copy Markdown
Contributor Author

/approve-spec 69fc687

@imdreamrunner
imdreamrunner marked this pull request as ready for review November 20, 2026 02:01
@imdreamrunner
imdreamrunner enabled auto-merge (squash) November 20, 2026 02:01
@imdreamrunner
imdreamrunner merged commit 4493a3c into main Nov 20, 2026
137 checks passed

This branch was successfully deployed

1 active deployment
Preview — 69fc6879 Deployed Nov 20, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants