Repository navigation
Conversation
…face prop; OQ7 asks which other surfaces do
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
There was a problem hiding this comment.
This spec change waits on an engineering owner's decision, and two record fixes are needed either way.
Decision needed: the amended DEC-2 in spec:AST-082 reverses a current decision that rejects visual props for one platform, so approval waits on an engineering owner recording the decision by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner). That approval should also settle three things: which contract holds surface, how it combines with the theme's native material intent and the Swift Button's placement-derived glass, and whether IconButton is covered.
Blocking findings:
spec:AST-093FR4 still says a native component "never adds a visual prop for one platform (spec:AST-082/DEC-2)", so amend it in this pull request to name the Button and IconButtonsurfaceexception.- "Typed from the shared contracts" reads as the core contract, because current records call the core contract the shared one, and under FR3 that would make the web Button and IconButton honor
glass, so name the contract that holdssurfaceand say whatglassdraws where the platform or OS version has no system glass.
Before approval, the description also needs the admission argument spec:AST-002 FR5 asks for: the two otherwise identical cases, why the caller knows the difference, and why Button cannot derive it from its placement.
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: records only, one knowledge record changed. Verified.
- Claim: Button and IconButton take
surface,plainby default orglass. Verified in the DEC-2 amendment. - Claim: every other native-only look stays theme intent. Verified.
- Claim: DEC-2's original text stays, with an "Amended:" note on its rejected alternative. Verified; the decider line is unchanged.
- Claim: a new OQ7 is open and lists no options. Verified.
- Claim: the owner chose a surface prop on Button. The record also covers IconButton; left to the approval.
- Claim: no decision is needed. False: the spec-owner approval check still waits on an engineering owner.
- Claim: overlapping open work is separate and merges cleanly. Verified for the contracts and ref-prop changes; the React Native glass draft touches no text here.
- Claim: affected current claims are named. False:
spec:AST-093FR4 is not named. - Claim: writing rubric clean, knowledge check aligned, Prettier and whitespace clean. Verified.
- Claim: no internal context in public text. Verified.
- File
docs/specs/AST-082-native-first-surfaces/spec.md: the two blocking findings above.
…ls back to chrome material; AST-093 FR4 names the exception
There was a problem hiding this comment.
This spec change still waits on an engineering owner's decision, and four record fixes are needed either way.
Decision needed: the amended DEC-2 in spec:AST-082 reverses a current decision that rejects visual props for one platform, so approval waits on an engineering owner recording the decision by commenting /approve-spec <full head SHA> on this pull request, on the head that carries the fixes below (the author may do so as an engineering owner). That approval should also confirm that IconButton is meant beside Button, and the surface name beside FR10's existing material intent.
Blocking findings:
surfaceis placed in the iOS and Android contracts only, but FR3 says one API serves every platform a language's apps run on and a prop scoped to one of them states its reason, so add macOS (and say whether Windows) or state why macOS has no honest glass.- The amendment calls
plainthe default but also says an unsetsurfacefollows the theme'smaterialand the placement rule, which draws glass in a system bar whereplainwould not, so say thatsurfacehas no default (unset follows the theme and placement, andplainorglassoverrides them) or drop the unset sentence. - Miss: the verification row for
spec:AST-093FR4 still fails "a platform-only visual prop is added", so extend it with the sameButtonandIconButtonsurfaceexception. - The description says
glassfalls back "with no warning" and that no open pull request editsspec:AST-093, but the record says nothing about warnings and #8288 and #8500 edit that record's Current-state impact, so align the description with the record and name those two in the overlap line.
The earlier findings on the spec:AST-093 FR4 requirement and on which contract holds surface are fixed, and the admission argument is now in the description.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: records only, two knowledge records changed. Verified.
- Claim: Button and IconButton take
surface,plainby default orglass. Verified in the amendment; the default conflicts with the unset rule (second finding). - Claim: it is a platform prop in the iOS and Android contracts, not in the core or web contracts. Verified; macOS is left out without a reason (first finding).
- Claim: an explicit
surfacedecides, and an unset one follows the theme's native material intent and the placement rule. Verified. - Claim: without system glass,
glassdraws the platform's chrome material with no warning, and accessibility settings apply as for any glass. Partly false: the record says nothing about warnings (fourth finding). - Claim: every other native-only look stays theme intent. Verified.
- Claim: DEC-2's original text stays, with an "Amended:" note on its rejected alternative. Verified; the decider line is unchanged.
- Claim:
spec:AST-093FR4 names the exception, so the two records agree. Verified for the requirement; its verification row still disagrees (third finding). - Claim: a new OQ7 is open and lists no options. Verified.
- Claim: the owner chose a surface prop on Button. The record also covers IconButton; left to the approval.
- Claim: no decision is needed. False: the spec-owner approval check still waits on an engineering owner.
- Claim: overlapping open work is separate and merges cleanly, and no open pull request edits
spec:AST-093. The named pull requests merge cleanly; two older open pull requests editspec:AST-093elsewhere (fourth finding). - Claim: the admission argument for a per-call-site prop. Present: the two cases, the caller's knowledge and why Button cannot derive it are named; the outcomes are implied.
- Claim: writing rubric clean, the amendment follows the dated-amendment form, knowledge check aligned, Prettier and whitespace clean. Verified.
- Claim: no internal context in public text. Verified.
- File
docs/specs/AST-082-native-first-surfaces/spec.md: first and second findings. - File
docs/specs/AST-093-native-component-guidelines/spec.md: third finding.
…ST-093's FR4 check names the exception
There was a problem hiding this comment.
This spec change is ready for an engineering owner's decision, with one description fix.
Decision needed: the amended DEC-2 in spec:AST-082 reverses a current decision that rejects visual props for one platform, so approval waits on an engineering owner recording the decision by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner). That approval should also confirm that IconButton is meant beside Button, and the surface name beside FR10's existing material intent.
Blocking finding:
- Miss: the overlap list leaves out #9369, which would make current a Swift Button record that decides glass with "no new prop or modifier" and keeps macOS and iOS before 26 on the token look, so name it and say that record follows the amended DEC-2 before it becomes current (a description edit, which does not move the head).
All four record and description fixes from the last review are in.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: records only, two knowledge records changed. Verified.
- Claim: Button and IconButton take
surface,plainorglass, and an unset button looks as it does today. Verified in the DEC-2 amendment: unset follows the theme and the placement rule. - Claim: every other native-only look stays in the theme, and a new open question asks which other components get such a prop. Verified (OQ7).
- Claim: no decision is needed because the owner decided it. Not verified: the amendment's decider line names the owner, but the spec-owner approval check still waits on an approval at this head.
- Claim: the existing authority searched was DEC-2, DEC-6, FR3 and OQ1 to OQ6. Verified as read; the "behavior and presentation choices" wording is DEC-2's own sentence citing DEC-6.
- Claim: the named overlapping pull requests are separate, the two that edit the same record merge cleanly, and two others touch only the Current-state impact of
spec:AST-093. Verified; #9369 is missing from the list (blocking finding). - Claim:
surfaceis a platform prop in every native platform's contract, not in the core or web contracts. Verified; the record itself gives no reason for leaving the web out. - Claim:
surfacehas no default; unset follows the theme's native material intent and the placement rule, and a set value overrides them. Verified. - Claim: without system glass,
glassdraws the platform's chrome material, and Reduce Transparency and Increase Contrast apply as for any glass. Verified; the record leaves chrome material to each platform's record. - Claim: DEC-2's original text stays, with an "Amended:" note on its rejected alternative. Verified; the decider line is unchanged.
- Claim:
spec:AST-093FR4 and its verification row name the same exception. Verified. - Claim: OQ7 is open and lists no options. Verified.
- Claim: the owner chose a surface prop on Button. The record also covers IconButton; left to the approval.
- Claim: the admission argument for a per-call-site prop. Present: the two cases, the caller's knowledge and why Button cannot derive it are named; the outcomes are implied.
- Claim: no other component gains a surface prop here, and the React Native draft can cite the amended decision once this merges. Verified.
- Claim: writing rubric clean, the dated-amendment form
spec:AST-030uses, knowledge check aligned, Prettier and whitespace clean. Verified. - Claim: no internal context in public text. Verified.
- File
docs/specs/AST-082-native-first-surfaces/spec.md: clear. - File
docs/specs/AST-093-native-component-guidelines/spec.md: clear.
Records only. On native platforms, a
ButtonorIconButtoncan take a glass appearance at one call site: they take asurfaceprop,plainorglass. Left unset, a button looks as it does today. Every other native-only look stays in the theme, and which other surfaces get a prop like this is a new open question.Exact decision needed
None: the owner decided it (
spec:AST-082DEC-2's amendment). This pull request records it.Existing authority searched
spec:AST-082DEC-2 (native-only visuals are theme configuration, not component props; "Rejected: visual props for one platform on components"), DEC-6 (platform props carry behavior and presentation choices), FR3 (core and platform contracts), and Open questions OQ1–OQ6.surface,glass,native-only,visual props.Overlap checked: #12707, #12699, #12557, #8500, #8288, #9369 (#9369 would make current a Swift Button record that decides glass with no new prop or modifier and keeps macOS and iOS before 26 on the token look; that record follows the amended DEC-2 before it becomes current; #8500 and #8288 edit
spec:AST-093's Current-state impact, not FR4 or its verification row; #12707 records the separate contracts decision inspec:AST-082FR3, DEC-7 and DEC-17, and a merge-tree check against it is clean; #12699 adds only an FR4 ref bullet; one decision per pull request, so this is separate; #12557 draftsspec:AST-123and touches nospec:AST-082text)Decision
ButtonandIconButtontake a per-call-sitesurfaceprop (plainorglass) as a situational appearance choice. It is a platform prop in every native platform's contract (FR3, FR5); the core and web contracts do not have it, because FR3 says a platform never offers a prop it does not fully honor.surfacehas no default: unset follows the theme's nativematerialintent and the platform's placement rule, andplainorglassoverrides them. Where a platform or OS version has no system glass,glassdraws that platform's chrome material; Reduce Transparency and Increase Contrast apply as for any glass. Every other native-only look stays theme intent. DEC-2's original text stays. Its "Rejected: visual props … on components" line gets an "Amended:" note that names Button and IconButton as the one exception.spec:AST-093FR4: "never adds a visual prop for one platform" now namesButtonandIconButton'ssurfaceprop as the exception, so the two records agree. Its verification row's failure signal names the same exception.Why a per-call-site prop (
spec:AST-002FR5)Take two otherwise identical buttons in the same view. One shows while the app presents that view with native appearance, and the other while the app presents it with non-native appearance (for example, a surface that moves components between native and non-native appearance). Only the app knows which presentation it is in at that call site. Button cannot derive it from its placement or from the theme alone, so the choice is made at the call site.
Rejected alternatives
Claim scope and non-goals
spec:AST-123(open draft spec(AST-123): React Native platform: Surfaces and glass #12557) can citespec:AST-082DEC-2 as amended, plus OQ7, once this merges.Evidence and implementation relationship
None needed: this records the owner's decision.
Writing rubric results
spec:AST-030uses for amended decisions.Rejected:sentence, with an "Amended:" note.Scope
Components: Button, IconButton (record:
spec:AST-082)Validation
pnpm check:knowledge: templates and records aligned.git diff --check: clean.