Skip to content

chore(ci): qualify development on patched Node 26 - #72

Merged
steipete merged 1 commit into
mainfrom
fix/patched-node26-development
Oct 26, 2026
Merged

steipete merged 1 commit into
mainfrom
fix/patched-node26-development

Conversation

@joshavant

Copy link
Copy Markdown
Contributor

What Problem This Solves

Development qualification still selected the retired Node 25 line during dependency acquisition and checks.

User Impact

Contributors should use patched Node 22.23.4, 24.22.1 or 26.12.1. Node 25 development qualification is intentionally retired, with maintainer approval. The published package engine range, router source, dependencies and lockfile are unchanged.

Why This Change Was Made

Replace the Ubuntu Node 25 check with exact patched Node 26.12.1 and align the documented development contract. Remove only the two Dependabot ignore constraints whose stated purpose was retaining Node 25 tooling compatibility; this PR performs no dependency upgrade or automatic merge.

Evidence

  • Isolated native Linux ARM64: official checksum-verified Node 22.23.4, 24.22.1 and 26.12.1; separate source and mutable caches; declared pnpm 11.28.4.
  • Frozen installation and full pnpm run check passed on each: formatter, build, typecheck, lint, 9 test files / 58 tests, actual pack/import.
  • Each packed artifact SHA256: cd2ce2e393816074e8628ad5c013508ee36947987fb775e2dd6db6f3ad8dba51.
  • All YAML parsed; actionlint 1.7.12 plus shellcheck passed all workflow files with the checked-in configuration; git diff --check passed.
  • Independent review of the exact five-file patch at P0–P2: scoped-clean, one complete attempt. Patch SHA256: efef41b450d6fed431788af84d50e85c27e53f12bed444c4eb9e502be2bbcd94.

Local proof covers Linux ARM64. Configured macOS/Windows jobs remain hosted CI evidence when completed. This library owns no HTTPS transport; source/runtime qualification does not establish fleet delivery or future package publication. No release, deployment or package publication is requested.

@joshavant
joshavant requested a review from a team as a code owner October 26, 2026 07:17
@clawsweeper

clawsweeper Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

ClawSweeper review complete

ClawSweeper finished reviewing this revision. The review result is being finalized.

View the workflow run.

@clawsweeper clawsweeper Bot added P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR. labels Oct 26, 2026
@clawsweeper

clawsweeper Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codex review: needs maintainer review before merge.

What this changes

Replace Node 25 development qualification with Node 26.12.1, remove its dependency-update restrictions, and align contributor documentation.

Example: The Ubuntu compatibility job acquires Node before installing development dependencies.

  • Before: CI selects Node 25 and Dependabot excludes tsdown >=0.23.0 and Vitest >=5.0.0.
  • After: CI selects Node 26.12.1 and those Node 25-specific update exclusions are removed.

Review scores

Measure Result What it means
Overall readiness 🐚 platinum hermit (4/6) A narrow, useful maintenance patch with explicit compatibility intent, passing exact-head checks, and no actionable findings.
Proof confidence 🌊 off-meta tidepool Not applicable: The ordinary contributor proof gate is waived for this maintainer-authored automation change; exact-head CI validates the changed job, while the body reports separate Linux ARM64 frozen-install and package-check results.
Patch quality 🐚 platinum hermit (4/6) No actionable review findings were identified.

Product

Kind: Maintenance · Worth it: Yes · Fix scope: Complete
User problem: Development qualification continues to use retired Node 25 and prevents tooling updates solely to preserve that runtime.
Reason: The maintainer-authored direction explicitly retires that development contract, preserves consumer engine compatibility, and keeps the change narrowly scoped.

Merge readiness

✅ Ready for maintainer review

Keep open: this PR makes a focused, intentional development-runtime change that main does not contain; no actionable patch defects were found.

Priority: P2
Reviewed head: a1c7ff776a1f235a8b7c36423731b65537f397de

Before merge

None.

Findings

None.

Agent review details

How this fits together

Repository automation selects Node and installs the locked development toolchain, then runs package checks; Dependabot proposes future updates subject to the remaining cooldown and grouping rules.

flowchart LR
  A[Pull request] --> B[CI runtime matrix]
  B --> C[Frozen dependency installation]
  C --> D[Package checks]
  E[Dependabot policy] --> F[Dependency update proposals]
  F --> A
Loading

Technical review

Best possible solution:

Land the focused runtime-qualification change while preserving the existing package engine range and locked dependency graph.

Do we have a high-confidence way to reproduce the issue?

This is maintenance rather than a router bug report; current main visibly selects Node 25 and retains the two associated update exclusions.

Is this the best way to solve the issue?

The patch updates the existing runtime-selection owner and removes only the obsolete compatibility holds, without introducing another configuration path or changing installed dependencies.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning medium; reviewed against f0ef34a0096e.

Provenance checked

  • Node 25 CI lane and documented development contract changes intended behavior with a stated reason (01c7a1b: Strict-engine installs of newer tooling rejected Node 25, so the earlier change added qualification and retained compatible tool versions.)
  • Dependabot tsdown and Vitest exclusions changes intended behavior with a stated reason (c21eaef: Prevent automated upgrades from violating the supported Node 25 development contract; the current PR explicitly retires that contract.)
  • Patched Node 22/24 qualification keeps the original intent (f0ef34a: Exact patch selectors prevent reuse of older runtimes lacking the intended certificate rejection update; these selectors remain unchanged.)

Security

None.

Evidence

What I checked:

Likely related people:

  • Josh Avant: Raw commit f0ef34a adds .github/workflows/ci.yml:39 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: high; commits: f0ef34a0096e; files: .github/workflows/ci.yml)
  • Vincent Koc: Raw commit df50bfe adds .github/dependabot.yml:8 relative to its recorded parents. This identifies author metadata, not feature responsibility or a PR merger. (role: source-line author; confidence: medium; commits: df50bfe27128; files: .github/dependabot.yml)

Labels

Label changes:

  • add P2: Focused development-runtime security maintenance with no demonstrated broken consumer workflow or urgent regression.
  • add rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • add status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Label justifications:

  • P2: Focused development-runtime security maintenance with no demonstrated broken consumer workflow or urgent regression.
  • rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🌊 off-meta tidepool and patch quality is 🐚 platinum hermit.
  • status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR.

Rating scale

6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior.

Workflow

ClawSweeper edits this one comment on every review. Comment @clawsweeper re-review for a fresh review only. Repair and merge execution lanes are retired.

Reviewed October 26, 2026, 3:30 AM ET / 07:30 UTC.

@steipete steipete left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the development-runtime change, preserved consumer engine range, official patched release, and passing exact-head checks.

@steipete
steipete merged commit b3ce1d7 into main Oct 26, 2026
15 checks passed
@steipete
steipete deleted the fix/patched-node26-development branch October 26, 2026 12:11
@steipete

Copy link
Copy Markdown
Contributor

Merged as b3ce1d7 after all 12 exact-head checks passed and independent P0–P2 review completed without findings. Locally, the full check pipeline passed: formatting, build, typecheck, lint, 58 tests, and actual package pack/install/import validation (two test workers, low scheduling priority).

Official Node 26.12.1 release notes confirm blocked-public-key chain rejection and updated roots. The published package engine range is unchanged. The merged source also passed the non-publishing release workflow: https://github.com/openclaw/uirouter/actions/runs/40320659595 (dry_run=true, version 0.1.2). No tag, package version bump, publication, or deployment was performed. Post-merge macOS CI remains queued; it has not been bypassed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

P2 Normal priority bug or improvement with limited blast radius. rating: 🐚 platinum hermit Good normal PR readiness with ordinary maintainer review expected. status: 👀 ready for maintainer look ClawSweeper has no concrete contributor-facing blocker left for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants