Repository navigation
chore(ci): qualify development on patched Node 26 - #72
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. What this changesReplace Node 25 development qualification with Node 26.12.1, remove its dependency-update restrictions, and align contributor documentation. Example: The Ubuntu compatibility job acquires Node before installing development dependencies.
Review scores
ProductKind: Maintenance · Worth it: Yes · Fix scope: Complete Merge readiness✅ Ready for maintainer review Keep open: this PR makes a focused, intentional development-runtime change that main does not contain; no actionable patch defects were found. Priority: P2 Before mergeNone. FindingsNone. Agent review detailsHow this fits togetherRepository automation selects Node and installs the locked development toolchain, then runs package checks; Dependabot proposes future updates subject to the remaining cooldown and grouping rules. flowchart LR
A[Pull request] --> B[CI runtime matrix]
B --> C[Frozen dependency installation]
C --> D[Package checks]
E[Dependabot policy] --> F[Dependency update proposals]
F --> A
Technical reviewBest possible solution: Land the focused runtime-qualification change while preserving the existing package engine range and locked dependency graph. Do we have a high-confidence way to reproduce the issue? This is maintenance rather than a router bug report; current main visibly selects Node 25 and retains the two associated update exclusions. Is this the best way to solve the issue? The patch updates the existing runtime-selection owner and removes only the obsolete compatibility holds, without introducing another configuration path or changing installed dependencies. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against f0ef34a0096e. Provenance checked
SecurityNone. EvidenceWhat I checked:
Likely related people:
LabelsLabel changes:
Label justifications:
Rating scale6/6 🦀 challenger crab · 5/6 🦞 diamond lobster · 4/6 🐚 platinum hermit · 3/6 🦐 gold shrimp · 2/6 🦪 silver shellfish · 1/6 🧂 unranked krab. Overall follows the weaker of proof and patch quality; ✨ marks media proof (a screenshot, video, or linked artifact) that directly shows the changed behavior. WorkflowClawSweeper edits this one comment on every review. Comment Reviewed October 26, 2026, 3:30 AM ET / 07:30 UTC. |
steipete
left a comment
There was a problem hiding this comment.
Reviewed the development-runtime change, preserved consumer engine range, official patched release, and passing exact-head checks.
|
Merged as b3ce1d7 after all 12 exact-head checks passed and independent P0–P2 review completed without findings. Locally, the full check pipeline passed: formatting, build, typecheck, lint, 58 tests, and actual package pack/install/import validation (two test workers, low scheduling priority). Official Node 26.12.1 release notes confirm blocked-public-key chain rejection and updated roots. The published package engine range is unchanged. The merged source also passed the non-publishing release workflow: https://github.com/openclaw/uirouter/actions/runs/40320659595 ( |
What Problem This Solves
Development qualification still selected the retired Node 25 line during dependency acquisition and checks.
User Impact
Contributors should use patched Node 22.23.4, 24.22.1 or 26.12.1. Node 25 development qualification is intentionally retired, with maintainer approval. The published package engine range, router source, dependencies and lockfile are unchanged.
Why This Change Was Made
Replace the Ubuntu Node 25 check with exact patched Node 26.12.1 and align the documented development contract. Remove only the two Dependabot ignore constraints whose stated purpose was retaining Node 25 tooling compatibility; this PR performs no dependency upgrade or automatic merge.
Evidence
pnpm run checkpassed on each: formatter, build, typecheck, lint, 9 test files / 58 tests, actual pack/import.cd2ce2e393816074e8628ad5c013508ee36947987fb775e2dd6db6f3ad8dba51.git diff --checkpassed.efef41b450d6fed431788af84d50e85c27e53f12bed444c4eb9e502be2bbcd94.Local proof covers Linux ARM64. Configured macOS/Windows jobs remain hosted CI evidence when completed. This library owns no HTTPS transport; source/runtime qualification does not establish fleet delivery or future package publication. No release, deployment or package publication is requested.