Repository navigation
Bench foundation: bounded NODE recording, IMU validity and review handoff - #10
Merged
Merged
Conversation
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the focused IMU quaternion boundary and bounded NODE raw-recording → existing Observation JSONL → WORLD replay pipeline. No UI application, team/GNSS/radar implementation, CI workflow, firmware or frozen Alpha evidence changes are included.
Independent review remediation — ready for re-review
OpenCode requested changes on
2b54410508118ae4e2c75d0f162467ada98dba28, recorded at760a3f6e6c98b46578f53cce712c06b97266b003. The review was imported verbatim. New head:8a84369941c74d5f884c9ec6cc33d10395223597. Regression-first commit:f99db9a10448cbd86e7af4e834885133af0d39a8; implementation:57c8be07a5e728808c998224f1712cf79b459dbb.All five requested fixes:
Compatibility: a fully preserved but dirty capture can retain COMPLETE acquisition artifacts while
clean_first_run=FAIL; CLI now exits 2 for that case. Scientific acceptance remains NOT_EVALUATED. Status fields are additive; Observation v1 and JSONL/manifest interfaces remain unchanged. Diagnostic artifacts may survive late cancellation; file existence is not an acceptance signal.Validation
f0323be3d79af1bd5f29fd21b483323c90eeb7be3f90c8e89c980e92d8432b2cunchanged.4e1c920consumes NODE output; first/middle/last full envelopes and browser jumps verified. No physical serial port opened.Review entry points and physical gate
Per-defect remediation, commands, mutations and compatibility · canonical branch handoff · prepared ESP32 protocol.
Noncooperating serial consumers may bypass ownership requests; cooperative exclusion is tested but physical USB/alias behavior and already-open readers are unverified. Operator/device evidence and specific owner authorization remain mandatory. EXP-NODE-ESP32-001 remains NOT AUTHORIZED / NOT RUN. No merge, flash, reset, physical acquisition, human trial or Alpha evidence change. PR #7–#9 required follow-ups remain separate. Independent OpenCode re-review is still required.