Repository navigation
spec(AST-127): React Native platform: Icons and drawing - #12555
imdreamrunner wants to merge 19 commits into
Conversation
…s through five core contracts
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
AI review status for this pull request.
|
… native code uses public API only
There was a problem hiding this comment.
Approval waits on an engineering owner's decision. This draft record makes Astryx's drawn glyphs the default React Native icon on iOS and Android, with SF Symbols only behind an opt-in on iOS, while the current native-first surfaces record (AST-082 FR17 and DEC-10) defaults every native platform to its system symbols. An engineering owner decides that default, either amending AST-082 FR17 and DEC-10 for React Native or asking this record to default to platform symbols, and records approval of FR1–FR13 and DEC-1–DEC-5 by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
Whichever way that goes, these need fixing in the record:
- FR5 resolves the drawn glyph before any app or theme icon, so a theme's own icon for a built-in name never draws, against AST-082 FR17's rule that an app or theme icon replaces the platform default (
spec.mdlines 168-180). - FR5's mirroring list names
reply,undoandarrowRight, which are not among core's built-in icon names, the one shared set under FR17 (lines 181-184). - The
platformicon source that DEC-1 depends on appears only as aniconSourcepreference in the Who-uses-it table, with no requirement giving its values, default, theme setting or precedence (line 58). - Current-state impact says the record only details AST-112 FR1 and FR9, but it adds four contracts to AST-112's core list and reverses FR9's mapping of icon names onto system symbols (lines 321-328).
- FR10's last sentence decides how scene versions after 2 are reported while OQ2 still lists both options and FR8 reports scene versions through
version()(lines 279-280 and 414-417). - The "Why this exists" table surveys and rejects five ecosystem libraries outside any decision, which the writing rubric's R2 and R4 move to a linked artifact, so the reported R2, R4 and R6 results do not hold (lines 42-48).
Claims and files checked
Review mode: full; reason: no-earlier-review
- Claim: the record only details the parent foundation record's FR1, FR6–FR9 and FR12 — false: it adds to FR1's core list and reverses FR9's icon mapping without listing either.
- Claim: the native-first surfaces record's FR17 platform-symbol default conflicts, recorded as OQ1 — verified.
- Claim: the native component guidelines settle nothing on icon drawing for this package — verified: that record covers the Swift native package.
- Claim: icon set and icon variant records own names and artwork — verified, though FR5 names icons outside the built-in set.
- Claim: paths, exports and open pull requests were searched and nothing else owns these contracts — verified.
- Claim: the decision bullets match the record — verified, except that OQ2 is described as open while FR10 already rules part of it.
- Claim: the listed components use these native pieces, and the implementation lives in the React Native package — unverified: that package is not in this repository.
- Claim: four rejected alternatives, each inside its decision — false in part: the "Why this exists" table rejects five more libraries outside any decision.
- Claim: writing rubric R1, R3, R5 and R7 results — verified; R2, R4 and R6 — false.
- Claim: the pull request contains specification records only — verified.
- Claim: the knowledge check, Prettier and the whitespace check pass, and the leak scan is clean — verified.
- File:
docs/specs/AST-127-react-native-icons-drawing/spec.md— six blocking findings above, plus two suggestions: state the scene format's path, gradient and transform encoding or where its conformance cases live, and verify FR7's screen-reader exposure with an accessibility-hierarchy check.
There was a problem hiding this comment.
Approval waits on an engineering owner's decision. This draft record makes Astryx's drawn glyphs the default React Native icon on iOS and Android, with SF Symbols only behind an opt-in on iOS, while the current native-first surfaces record (AST-082 FR17 and DEC-10) defaults every native platform to its system symbols. An engineering owner decides that default, either by amending AST-082 FR17 and DEC-10 for React Native or by asking this record to default to platform symbols, and records approval of FR1–FR13 and DEC-1–DEC-5 by commenting /approve-spec <full head SHA> on this pull request; the author may do so as an engineering owner.
Whichever way that goes, these need fixing in the record:
- FR5 resolves the drawn glyph before any app or theme icon, so a theme's own icon for a built-in name never draws, against AST-082 FR17's rule that an app or theme icon replaces the platform default and AST-087 FR6's theme-first order (
spec.mdlines 168-180). - FR5's mirroring list names
reply,undoandarrowRight, which are not among core's built-in icon names, the one shared set under FR17 (lines 181-184). - The
platformicon source that DEC-1 depends on appears only as aniconSourcepreference in the Who-uses-it table, with no requirement giving its values, default, theme setting or precedence (line 58). - Current-state impact says the record only details AST-112 FR1 and FR9, but it adds four contracts to AST-112's core list (which the open AST-112 amendment in #12563 proposes) and reverses FR9's mapping of icon names onto system symbols, which no amendment changes (lines 321-328).
- FR10's last sentence decides how scene versions after 2 are reported while OQ2 still lists both options and FR8 reports scene versions through
version()(lines 279-280 and 414-417). - The "Why this exists" table surveys and rejects five ecosystem libraries outside any decision, which the knowledge-contracts record (INV10) and the writing rubric's R2 and R4 move to a linked artifact, so the reported R2, R4 and R6 results do not hold (lines 42-48).
The latest push rewords the Astryx Stage rows and verification cells and leaves each of these in place.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record only details the parent foundation record's FR1, FR6–FR9 and FR12 — false: it adds to FR1's core list and reverses FR9's icon mapping without listing either.
- Claim: the native-first surfaces record's FR17 platform-symbol default conflicts, recorded as OQ1 — verified.
- Claim: the native component guidelines settle nothing on icon drawing for this package — verified: that record covers the Swift native package.
- Claim: icon set and icon variant records own names and artwork — verified, though FR5 names icons outside the built-in set and puts built-in glyphs ahead of theme icons.
- Claim: paths, exports and open pull requests were searched and nothing else owns these contracts — verified; the open parent amendment (#12563) delegates this group to this record.
- Claim: overlapping open work is named — false in part: the description does not name #12563, which rewrites the parent's core list for this group.
- Claim: the decision bullets match the record — verified, except that OQ2 is described as open while FR10 already rules part of it.
- Claim: the listed components use these native pieces, and the implementation lives in the React Native package — unverified: that package is not in this repository.
- Claim: four rejected alternatives, each inside its decision — false in part: the "Why this exists" table rejects five more libraries outside any decision.
- Claim: writing rubric R1, R3, R5 and R7 results — verified; R2, R4 and R6 — false.
- Claim: the pull request contains specification records only — verified.
- Claim: the knowledge check, Prettier and the whitespace check pass, and the leak scan is clean — verified.
- File:
docs/specs/AST-127-react-native-icons-drawing/spec.md— six blocking findings above, plus three suggestions: state the scene format's path, gradient and transform encoding or where its conformance cases live; verify FR7's screen-reader exposure with an accessibility-hierarchy check; and define theisPlatformEnabledswitch FR12 relies on.
…ons resolve first
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision. iOS now defaults to SF Symbols with app and theme icons first, but Android still has no system icon map and a built-in name without a symbol gets Astryx's drawn glyph, against the current native-first surfaces record (AST-082 FR17 and DEC-10); an engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR13 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
To fix whichever way that goes:
- Intent and Current-state impact say the record follows AST-082 FR17 (
spec.md:29-32,:339-341), but its own FR5 gap gives Android no system icon for any built-in name (:315-316), so list FR17 and DEC-10 as departed from until OQ1 is ruled and state that gap against FR17. - Miss: FR5 takes SF Symbols from "the library's name table" (
spec.md:179-181,:317-319) while@astryxdesign/nativealready exportsNATIVE_ICON_DEFAULTS, one SF Symbol and Material Symbol map for core's 29 names, so name that map as FR5's table and add each symbol's minimum iOS there, or say why it cannot serve.
The six findings from the last review are fixed, and the smaller notes (the isPlatformEnabled switch, the theme's icon-source field, unregistered namespaced names, prefetch with nothing to download, the Large Content Viewer under the new default) are in the review.
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Depends on the open AST-112 amendment and its merge order: verified (both pull requests are open; the amendment sets revision 1 with named features).
- Records the five contracts' API, native contract, threading, fallbacks, accessibility, mirroring, name resolution, scene format and Astryx Stage behavior: verified (FR1–FR13).
- Cites the parent by FR id and relies on its amended FR3, FR8 and FR12: verified (Current-state impact,
spec.md:330-335). - Follows AST-082 FR17 and AST-112 FR9, with the drawn default and stand-in left to OQ1: false in part, since Android has no system icon map (first finding above).
- AST-093 settles nothing about icon drawing here: verified (its FR3 only points iOS to SF Symbols through FR17).
- Name resolution order (theme entry, app image, theme glyph, system symbol, drawn glyph): verified (
spec.md:174-183). - Image icons in the first frame, a prefetch that never rejects, and no fetch from a previewed project: verified (FR1–FR3).
- One versioned scene format with shared conformance cases and three failure reasons: verified (FR7).
- The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR6, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR10, DEC-4).
- Every contract at revision 1 and public platform API only: verified (FR11, FR13).
- Writing rubric R1–R7: verified (no narration words, the survey moved to the description, evidence names layers, three one-line rejections inside DEC-1, DEC-2 and DEC-4, no pull request references, OQ1–OQ3 keep their options, three named gap lines).
- Knowledge check, Prettier and whitespace checks pass: verified (the knowledge check reports the records aligned, Prettier passes, the diff check is clean).
- No internal context in public text: verified.
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the two findings above and five non-blocking notes; otherwise clear.
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision. This draft record defaults iOS to SF Symbols with app and theme icons first, but Android has no system icon map and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow; an engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
To fix whichever way that goes:
- The description's merge order (#12576 → #12563 → this record) names #12576, which closed without merging, and leaves out #12594, whose
spec:AST-140this record cites nine times (for examplespec.md:320), so list this record after #12594 (and after #12579 and #12598 forspec:AST-139andspec:AST-141) and drop #12576. - Intent and Current-state impact say the record follows AST-082 FR17 (
spec.md:29-31,:43,:325-327), but its own FR4 gap gives Android no system icon for any built-in name (:303-304), so list FR17 and DEC-10 as departed from until OQ1 is ruled and state that gap against FR17. - FR4 takes SF Symbols from "the library's name table" (
spec.md:173,:307) while@astryxdesign/nativealready exportsNATIVE_ICON_DEFAULTS, one SF Symbol map and one Material Symbol map for core's 29 names, so name that map as FR4's table and record each symbol's minimum iOS there, or say why it cannot serve.
The smaller notes (the undefined isPlatformEnabled switch and AstryxCapabilitiesProvider, version() on AstryxVectorInfo, unregistered namespaced names, and prefetch with nothing to download) are in the review.
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Depends on the open AST-112 amendment and the open AST-140 record: verified (both are open drafts, and the record cites both).
- Merge order #12576 → #12563 → this record: false, since #12576 closed without merging and #12594 is missing (first finding above).
- Astryx Stage and Preview are separate products: verified (Non-goals,
spec.md:79). - Existing authority searched (the AST-112 parent, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087): verified; AST-093 settles nothing here, and AST-087 covers the web only.
- The record follows AST-082 FR17 and AST-112 FR9, with the drawn stand-in left to OQ1: false in part, since Android has no system icon map (second finding above).
- Name resolution order (theme entry, app image, theme glyph, system symbol, drawn glyph): verified (
spec.md:167-176). - Image icons in the first frame, and a prefetch that resolves a result and never rejects: verified (FR1, FR2).
- One data-only, versioned scene format with shared conformance cases and three failure reasons: verified (FR6).
- The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Every contract at revision 1 with no named features, and public platform API only: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent).
- The components that use each piece: not checkable, since the React Native package is not in this repository.
- Writing rubric R1–R7: verified (no narration words, the survey moved to the description, evidence names layers, three one-line rejections inside DEC-1, DEC-2 and DEC-4, no pull request references in the record, OQ1–OQ3 keep their options, one named gap line).
- Knowledge check, Prettier and whitespace checks pass: verified (the knowledge check reports the records aligned, Prettier passes for the record, and the diff check is clean).
- No internal context in public text: verified.
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the three findings above and four non-blocking notes; otherwise clear.
… from NATIVE_ICON_DEFAULTS
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision. This draft record defaults iOS to the SF Symbols in NATIVE_ICON_DEFAULTS with app and theme icons first, but Android has no system icon map and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow; an engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
The earlier merge-order, FR17-conformance and icon-table findings are fixed, and one more fix is needed whichever way that decision goes:
- FR4 puts the theme's icon-source setting at
native.iconSourcein the theme's definition (spec.md:188-189), but AST-082 FR10 limits native theme configuration todefineNativeTheme's published vocabulary and FR18 gives the theme definition nonativepart, so make it adefineNativeThememember and list that change to AST-082 FR10 under Current-state impact, or drop the theme-level setting.
The smaller notes (merging after the AST-139 and AST-141 records too, the "Android departure" wording at spec.md:45, the undefined AstryxCapabilitiesProvider, version() on AstryxVectorInfo, and unregistered namespaced names) are in the review.
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Not stacked; merges after the AST-112 amendment and the AST-140 record: verified (both are open drafts, and the record cites both).
- The record also cites the Astryx Stage and Preview records: verified (Non-goals,
spec.md:81); the merge order does not include them (non-blocking note). - Existing authority searched (the AST-112 parent, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087): verified; AST-093 settles nothing here, and AST-087 covers web theme icons.
- The record follows AST-082 FR17 and AST-112 FR9 on iOS, names
NATIVE_ICON_DEFAULTSas the SF Symbol map, and lists the Android departure under Current-state impact: verified (spec.md:175-178,:337-338). - Name resolution order (theme entry, app image, theme glyph, system symbol under the default source, drawn glyph): verified (
spec.md:167-189). - Image icons in the first frame, and a prefetch that resolves a result and never rejects: verified (FR1, FR2).
- One data-only, versioned scene format with shared conformance cases and three failure reasons: verified (FR6).
- The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Every contract at revision 1 with no named features, and public platform API only: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent, Why this exists).
- Drawn glyphs as the default is left to OQ1: verified (OQ1 keeps both options).
- The components that use each piece: not checkable, since the React Native package is not in this repository.
- Writing rubric R1–R7: verified (no narration words, no pull request references in the record, three one-line rejections inside DEC-1, DEC-2 and DEC-4, OQ1–OQ3 keep their options, two gap lines that name FR4 and the mismatch).
- Knowledge check, Prettier and whitespace checks pass: verified (the knowledge check reports the records aligned with no warning for this record, Prettier passes for the record, and no line ends in whitespace).
- No internal context in public text: verified.
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the finding above and five non-blocking notes; otherwise clear.
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision. This draft record defaults iOS to the SF Symbols in NATIVE_ICON_DEFAULTS with app and theme icons first, but Android has no system icon view and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow. An engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
The fixed regular stroke for drawn glyphs and the development-build stop for unknown namespaced names fix both earlier findings. Two small notes remain, neither blocking: name the record that defines AstryxCapabilitiesProvider and its iconSource and isPlatformEnabled props (FR4, FR11), and state version() as AstryxVectorInfo's own member until OQ2 is ruled (FR8).
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Not stacked; merges after the AST-112 amendment and the AST-140 record, and after the Astryx Stage and Preview records it cites: verified (all four are open drafts, and the record cites each id).
- Existing authority searched (the AST-112 parent, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087, the AST-130 sibling): verified as listed.
- The record follows AST-082 FR17 and AST-112 FR9 on iOS, names
NATIVE_ICON_DEFAULTSas the SF Symbol map, and lists the Android departure under Current-state impact: verified (spec.md:174-177,:337-340). - Name resolution order (theme entry, app image, system symbol under the default source, shared drawn glyph): verified (
spec.md:167-183). - Image icons in the first frame, and a prefetch that resolves a result and never rejects: verified (FR1, FR2).
- One data-only, versioned scene format with shared conformance cases and three failure reasons: verified (FR6).
- The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Each contract's baseline is its first release's shape with no named features, and native code uses public platform API only: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent).
- Drawn glyphs as the default is left to OQ1: verified (OQ1 keeps both options).
- The components that use each piece: matches the record's table; not checkable against code, since the React Native package is not in this repository.
- Writing rubric R1–R7: verified (no narration words, no pull request references in the record, three one-line rejections inside DEC-1, DEC-2 and DEC-4, OQ1–OQ3 keep their options, two gap lines that name FR4 and the mismatch).
- Knowledge check, Prettier and whitespace checks pass: verified (the knowledge check reports the records aligned with no line for this record, Prettier passes for the record, and no line ends in whitespace).
- No internal context in public text: verified.
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the owner decision above and two non-blocking notes; otherwise clear.
Icon and Vector are the public faces; the icon, symbol and vector views are internal behind them. The scene grows by named features (groups), reported by AstryxVectorInfo. Clear Non-goals and state each decision's direction and reason.
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision, and two record defects need fixing. This draft record defaults iOS to the SF Symbols in NATIVE_ICON_DEFAULTS with app and theme icons first, but on Android no view draws system icons and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow. An engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
Blocking (both introduced at this head):
- With Non-goals reduced to "None.", FR1, FR3, FR6 and FR7 prescribe the three native views and the scene format while calling them internal and no longer saying who depends on them, which the knowledge-contracts rule against prescribing internal mechanisms (INV18) forbids; restore the template's two Non-goals lines, state that the native contracts and the scene format are the interface between the library's JavaScript and each binary across releases, and write "not exported to apps" instead of "internal".
- FR1 and FR3 now describe the native views but name props the native contract table does not have (
tintfortintColor,colorforsymbolColor, and aneffectobject foreffect,effectTriggerandeffectRepeat), so use the table's names or say how the library maps them.
Smaller notes are inline: two citations point at the wrong clause (AST-112 FR21, and AST-082 FR3 for the unknown-name stop, which is FR4's icon slot), AstryxCapabilitiesProvider and PlatformSymbol are defined in no record, groups is called a named feature of the first release, and FR9's "one glyph per control" lost its "at most".
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Not stacked; merges after the AST-112 amendment and the AST-140 record: verified (both are open drafts and the record cites both; the Astryx Stage and Preview records are no longer cited).
- The five pieces' contract, with the icon, symbol and vector views internal behind
IconandVectorunder AST-112 FR5 and FR21: partly false (the amendment's FR5 supports it; its FR21 covers who draws and glass and materials). - Existing authority searched (the AST-112 parent and amendment, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087, open pull requests, the AST-130 sibling): verified as listed.
- The record follows AST-082 FR17 and AST-112 FR9 on iOS, names
NATIVE_ICON_DEFAULTSas the SF Symbol map, and lists the Android departure under Current-state impact: verified (spec.md:162-165,:326-328). - Five core contracts in every binary: verified (
spec.md:95,:314-315). - Name resolution order (theme entry, app image, system symbol under the default source, shared drawn glyph): verified (
spec.md:155-175). - Image icons in the first frame, and a prefetch that always resolves a result: verified (FR1, FR2).
- One data-only scene format with shared conformance cases, growing by named features, three failure reasons, and
AstryxVectorInfolisting features: verified (FR6, FR8); whethergroupsis baseline is a note. - The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Each contract's baseline is its first release's shape, it grows by named features, and native code uses public platform API: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent).
- Written in positive terms, with Non-goals reading "None." and each decision stating its direction and reason: verified as text; emptying Non-goals is the first blocking finding.
- The Icon, Vector and chart component contracts stay with their own records: not stated in the record at this head (it left with the Non-goals).
- The table of components that use each piece: matches the record row for row; not checkable against code, since the React Native package is not in this repository.
- Writing rubric R1–R7: verified (no narration words, no research or pull request references in the record, no rejected lines, OQ1–OQ3 keep their options, two gap lines that name FR4 and the mismatch).
- Checklist: spec records only, verification by evidence layer, one decision, owners and overlapping work named, no internal context: verified; preserves equivalent internal implementations, and named internal mechanisms are public with their dependents and reason: false at this head (first blocking finding).
- Knowledge check, Prettier, whitespace and leak checks pass: verified (the knowledge check reports the records aligned with no line for this record, Prettier passes for the record, no line ends in whitespace).
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the owner decision above, two blocking findings and four non-blocking notes; otherwise clear.
| `AstryxCapabilitiesProvider`, a value or a function of the theme's name, | ||
| decides; without it, the source is `platform`. Under `theme`, built-in names | ||
| skip system symbols. | ||
| - **FR5 — The library applies Astryx's display rules before the views draw.** |
There was a problem hiding this comment.
Non-blocking (Miss; earlier reviews named the same clause): AST-082 states the unknown-name stop in FR4's icon slot ("on a native platform, in a development build an unknown name stops with a message that names the icon"), not in FR3. Cite spec:AST-082/FR4.
| - **FR5 — The library applies Astryx's display rules before the views draw.** | ||
| - Right-to-left: `chevronLeft`, `chevronRight`, `chevronsLeft`, | ||
| `chevronsRight`, and `externalLink` mirror; `chevronDown`, `arrowUp`, | ||
| `arrowDown`, `arrowsUpDown`, `upload`, `check`, and `close` keep their |
There was a problem hiding this comment.
Non-blocking: no record on main, in the AST-112 amendment or in AST-140 defines AstryxCapabilitiesProvider, its entry or its iconSource and isPlatformEnabled props. The same holds for PlatformSymbol (line 70, a miss from earlier heads), which is now the only app-facing way to draw an arbitrary SF Symbol. Name the records that define them.
| - Android ignores the prop. | ||
|
|
||
| ### Behaviour across binaries | ||
|
|
There was a problem hiding this comment.
Non-blocking: "marks one glyph per control" was "at most one", and the next sentence gives a symbol or image control no marked glyph. Restore "at most one". Line 213 has the same kind of change: "a renderer reads every scene to the end" sits beside too-deep, which stops at 100 levels, where the old text said a renderer "does not crash on it".
There was a problem hiding this comment.
Resolved in f31ba03: "marks at most one glyph per control".
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision, and one record defect needs fixing. This draft record defaults iOS to the SF Symbols in NATIVE_ICON_DEFAULTS with app and theme icons first, but on Android no view draws system icons and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow. An engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android map before approval.
Blocking:
- FR1 and FR3 describe the native views with props the native contract table does not have (
tintfortintColor,colorforsymbolColor, and aneffectobject foreffect,effectTriggerandeffectRepeat), so use the table's names or say how the library maps them.
The restored Non-goals lines settle the earlier internal-mechanism finding, and smaller notes are inline: the restored line could name the native contract tables beside the scene format, two citations point at the wrong clause (AST-112 FR21, and AST-082 FR3 for the unknown-name stop, which is FR4's icon slot), AstryxCapabilitiesProvider and PlatformSymbol are defined in no record, and groups reads as both baseline and a named feature.
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Not stacked; merges after the AST-112 amendment and the AST-140 record: verified (both are open drafts, and the record cites no other unmerged record).
- The five pieces' contract, with the icon, symbol and vector views internal behind
IconandVectorunder AST-112 FR5 and FR21: partly false (the amendment's FR5 supports it; its FR21 covers who draws and glass and materials). - Existing authority searched (the AST-112 parent and amendment, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087, open pull requests, the AST-130 sibling): verified as listed.
- The record follows AST-082 FR17 and AST-112 FR9 on iOS, names
NATIVE_ICON_DEFAULTSas the SF Symbol map, and lists the Android departure under Current-state impact: verified (spec.md:163-166,:327-329). - Five core contracts in every binary: verified (
spec.md:96,:315-316). - Name resolution order (theme entry, app image, system symbol under the default source, shared drawn glyph): verified (
spec.md:156-176). - Image icons in the first frame, and a prefetch that always resolves a result: verified (FR1, FR2).
- One data-only scene format with shared conformance cases, growing by named features, three failure reasons, and
AstryxVectorInfolisting features: verified (FR6, FR8); whethergroupsis baseline is a note. - The library decides mirroring over core's names, the Bold Text step and Reduce Motion: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Each contract's baseline is its first release's shape, it grows by named features, and native code uses public platform API: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent).
- Written in positive terms, with Non-goals keeping only the template's two standing lines and each decision stating its direction and reason: verified (
spec.md:72-79; the second line names the scene format in place of the template's closing sentence). - The
Icon,Vectorand chart component contracts stay with their own records, icon sets and variants with AST-084 and AST-087, and drawn glyphs as the default is OQ1: verified (the record defines no component props; OQ1 atspec.md:390-402). - The table of components that use each piece: matches the record row for row; not checkable against code, since the React Native package is not in this repository.
- The ecosystem comparison: context outside the record; consistent with what those libraries publicly offer, not checked against their code here.
- Writing rubric R1–R7: verified (no narration words, no research or pull request references in the record, no rejected lines, OQ1–OQ3 keep their options, two gap lines that name FR4 and the mismatch).
- Checklist: spec records only, equivalent implementations preserved, verification by evidence layer, one decision, owners and overlapping work named, no internal context: verified; named internal mechanisms public with their dependents: verified for the scene format, not stated for the native contract tables (a note).
- Knowledge check, Prettier, whitespace and leak checks pass: verified (the knowledge check reports the records aligned with no line for this record, Prettier passes for the record, no line ends in whitespace).
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the owner decision above, one blocking finding and five non-blocking notes; otherwise clear.
| - Internal modules, files, function names, algorithms, data structures, storage | ||
| layouts, manifests, journals, locks, transaction protocols, and CI | ||
| job/workflow topology belong in architecture or implementation unless callers | ||
| or interoperating systems intentionally depend on that exact mechanism as a | ||
| public protocol. The vector scene format is such a protocol: every renderer | ||
| and the library's writer depend on it (FR6). |
There was a problem hiding this comment.
Non-blocking: this names the scene format as the one public protocol, but the native contract tables (lines 83-96) are the same kind of interface: FR10 freezes their first-release shape, and spec:AST-140 FR1 makes each contract the library layer's way into native code. FR1, FR3 and FR7 still call the views "internal" and name no dependent. Add the native contracts to this sentence (the library's JavaScript and each binary's native code depend on them across releases), and write "not exported to apps" where the record says "internal".
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision; no blocking record defect remains. This draft record defaults iOS to the SF Symbols in NATIVE_ICON_DEFAULTS with app and theme icons first, but on Android no view draws system icons and a built-in name without a symbol gets Astryx's drawn glyph, which the current native-first surfaces record (AST-082 FR17 and DEC-10) does not allow. An engineering owner either amends FR17 and DEC-10 to allow that and approves FR1–FR12 and DEC-1–DEC-4 by commenting /approve-spec <full head SHA> on this pull request (the author may do so as an engineering owner), or the record adds an Android system icon map before approval.
The earlier prop-name finding is fixed (FR1 and FR3 now use the native contract table's names); smaller notes stay inline: the mechanism line could name the native contract tables beside the scene format, two citations point at the wrong clause (AST-112 FR21, and AST-082 FR3 for the unknown-name stop, which is FR4's icon slot), AstryxCapabilitiesProvider and PlatformSymbol are defined in no record, and two wordings ("reads every scene to the end", and the FR4 gap's minimum iOS) say more than the record means.
Claims and files checked
Review mode: full; reason: spec-record
- Claims in the description:
- Not stacked; merges after the AST-112 amendment and the AST-140 record: verified (both are open drafts, and the record cites no other unmerged record).
- The icon, symbol and vector views are internal behind
IconandVectorunder AST-112 FR5 and FR21: partly false (the amendment's FR5 supports it; its FR21 covers who draws and glass and materials). - Existing authority searched (the AST-112 parent and amendment, AST-140, AST-082 FR3 and FR17, AST-093, AST-084 and AST-087, open pull requests, the AST-130 sibling): verified as listed.
- The record follows AST-082 FR17 and AST-112 FR9 on iOS, names
NATIVE_ICON_DEFAULTSas the SF Symbol map, and lists the Android departure under Current-state impact: verified (spec.md:164-167,:326-328). - Five core contracts in every binary: verified (
spec.md:96,:315-316). - Name resolution order (theme entry, app image, system symbol under the default source, shared drawn glyph): verified (
spec.md:157-177). - Image icons in the first frame, and a prefetch that always resolves a result: verified (FR1, FR2).
- One data-only scene format with shared conformance cases, growing by named features (
groups), three failure reasons, andAstryxVectorInfolisting features: verified (FR6, FR8, FR10). - The library decides mirroring over core's names, the Bold Text step and Reduce Motion, and the views take plain flags: verified (FR5, DEC-3).
- The drawn glyph's own view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Each contract keeps the baseline AST-140 FR5 sets and grows by named features, and native code uses public platform API: verified (FR10, FR12).
- No third-party native dependency, and apps may use other libraries beside these components: verified (Intent).
- Written in positive terms, with Non-goals keeping only the template's two standing lines and each decision stating its direction and reason: verified (
spec.md:70-79; the second line names the scene format in place of the template's closing sentence). - The
Icon,Vectorand chart component contracts stay with their own records, icon sets and variants with AST-084 and AST-087, and drawn glyphs as the default is OQ1: verified (the record defines no component props; OQ1 atspec.md:389-401). - The table of components that use each piece: matches the record row for row; not checkable against code, since the React Native package is not in this repository.
- The ecosystem comparison: context outside the record; not checked against those libraries' code.
- Writing rubric R1–R7: verified (no narration words, no research or pull request references in the record, no rejected lines, OQ1–OQ3 keep their options, two gap lines that name FR4 and the mismatch).
- Checklist: spec records only, equivalent implementations preserved, verification by evidence layer, one decision, owners and overlapping work named, no internal context: verified; named internal mechanisms public with their dependents: verified for the scene format, not stated for the native contract tables (a note).
- Knowledge check, Prettier, whitespace and leak checks pass: verified (the knowledge check reports the records aligned with no line for this record, Prettier passes for the record, no line ends in whitespace).
- Files:
docs/specs/AST-127-react-native-icons-drawing/spec.md: the owner decision above and four non-blocking notes; otherwise clear.
There was a problem hiding this comment.
Approval waits on an engineering owner's spec decision, and two small fixes are needed. On Android this draft record draws Astryx's glyph for every built-in icon, and on iOS wherever no SF Symbol applies, where the current spec:AST-082 FR17 and DEC-10 require each native platform's own system symbols; an engineering owner either amends FR17 and DEC-10 for React Native or requires an Android map, and records the decision by commenting /approve-spec <full head SHA> (the author may, as an engineering owner).
- Regression: Current-state impact (line 318) lists a change to
spec:AST-112FR1's core list, which the amended FR1 onmainno longer has, so replace it with "Followsspec:AST-112FR3, FR7 and DEC-13: the icons group links in the core" and drop "(amended)" from line 315. - The description's "Exact decision needed" still cites
spec:AST-112FR21 for the internal native views, while the record cites FR5 alone and FR21 covers glass and materials, so cite FR5 alone there.
Five non-blocking notes remain, most of them inline: the deprecated home of NATIVE_ICON_DEFAULTS, the native contract tables missing from the Non-goals protocol sentence, the undefined AstryxCapabilitiesProvider and PlatformSymbol, the AST-082 FR4 citation, and two over-broad wordings.
Claims and files checked
Review mode: full; reason: spec-record
- Claim: the record merges after the AST-112 amendment and AST-140: verified, both are merged on
main. - Claim: the views are internal behind
IconandVectorunder AST-112 FR5 and FR21: false for FR21 (the record cites FR5 alone; FR21 covers glass and materials); FR5 verified (lines 102, 139, 228, 324). - Claim: AST-140 owns the shared rules the record cites (missing piece, results, additive growth, threading, conformance, coexistence): verified against AST-140 FR2, FR3, FR5, FR6, FR7 and FR9.
- Claim: iOS follows AST-082 FR17 and AST-112 FR9 with
NATIVE_ICON_DEFAULTSas the SF Symbol map, and the Android departure is listed until OQ1 is ruled: verified (lines 164-167, 326-328). - Claim:
Iconresolves a theme entry, an app image, the system symbol under the defaultplatformsource, then the drawn glyph: verified (FR4, lines 157-177). - Claim: image icons appear in the first frame from local or already-shown masks, and prefetch always resolves a result: verified (FR1, FR2).
- Claim: one data-only scene format with shared conformance cases, safe reading and three error reasons, with
AstryxVectorInfolisting features: verified (FR6, FR8). - Claim: the library decides mirroring, the Bold Text step and Reduce Motion: verified (FR5).
- Claim: the drawn glyph's vector view supplies the Large Content Viewer image: verified (FR9, DEC-4).
- Claim: each contract keeps the AST-140 FR5 baseline, native code uses public API, and Astryx takes no third-party native dependency: verified (FR10, FR12, Intent).
- Claim: Non-goals keeps only the template's two standing lines: verified (lines 70-79).
- Claim: writing rubric results (no narration words, no pull request references, OQ1 to OQ3 open with options, two FR4 gap lines): verified.
- Claim: the knowledge check, Prettier and the whitespace check pass: verified at this head.
- Claim: the open AST-112 follow-up moves FR21 out of AST-112: verified; it keeps every AST-112 claim this record cites.
- File:
docs/specs/AST-127-react-native-icons-drawing/spec.md: findings above.
| - Relies on `spec:AST-112` FR3 (amended): the library's own native pieces link | ||
| by default, so these five core contracts are in every binary. | ||
| - Relies on `spec:AST-140/FR5`: each contract keeps the baseline that `spec:AST-140/FR5` sets, and later behavior is a named feature the binary reports. | ||
| - Changes `spec:AST-112/FR1`: the core's list gains `AstryxIconView`, |
There was a problem hiding this comment.
Regression (blocking): since the AST-112 amendment merged, main's spec:AST-112 FR1 has no core list and no system symbols: the core is "the native half of the library's own components", FR7's group table already lists "Icons and drawing | spec:AST-127 | core", and DEC-13 links icons by default. Replace this line with "Follows spec:AST-112 FR3, FR7 and DEC-13: the icons group links in the core", and drop "(amended)" from line 315.
| shows it through the symbol view (FR3) on iOS. | ||
| - An image the app registers for the name shows through the icon view. | ||
| - Under the `platform` icon source, a built-in name shows its system symbol: | ||
| on iOS, the SF Symbol that `@astryxdesign/native`'s `NATIVE_ICON_DEFAULTS` |
There was a problem hiding this comment.
Regression (non-blocking): spec:AST-112 FR4 and DEC-19 on main (draft) now say "@astryxdesign/native is deprecated: the shared contracts replace it". Say where this SF Symbol map lives once the shared contracts replace that package, or list the dependency under Current-state impact.
Not stacked. Merges after #12563 (AST-112) and #12594 (AST-140).
Exact decision needed
The contract of the React Native platform's icon and drawing pieces:
AstryxIconView,AstryxIcons,AstryxSymbolView,AstryxVectorView, andAstryxVectorInfo. The icon, symbol, and vector views are internal implementation behindIconandVector(spec:AST-112FR5 and FR21). It records their native contract, threading, fallbacks, accessibility (screen readers, Bold Text, Reduce Motion, the iOS Large Content Viewer), right-to-left mirroring, howIconresolves a name, and the shared vector scene format, as a child ofspec:AST-112.Existing authority searched
spec:AST-112(React Native foundation) and its open amendment (spec(AST-112): React Native commands are one astryx rn group; package shape (Expo wrapper, default linking, named features) #12563): the parent. The record cites FR ids only and relies on amended FR3 without restating it.spec:AST-140(React Native platform code, spec(AST-140): React Native platform code #12594): owns the shared platform rules this record cites (missing piece, result vocabulary, additive evolution, threading, conformance suites, coexistence).spec:AST-082(native-first surfaces): FR3 component contracts; FR17 shared icon names, the system-symbol default, and app or theme icons replacing it. The record follows FR17 andspec:AST-112/FR9on iOS and names@astryxdesign/native'sNATIVE_ICON_DEFAULTSas the SF Symbol map; it lists the Android departure from FR17 and DEC-10 under Current-state impact until OQ1 is ruled.spec:AST-093(native component guidelines): nothing settles icon drawing for this package.spec:AST-084(icon set integrations) andspec:AST-087(icon variants): which names and artwork exist; out of scope here.Icon,Vector,PlatformSymbol,AstryxIcons,AstryxVectorInfo. The native views and the scene types are internal behindIconandVector.icon OR vector OR symbol,react native spec): web Icon fixes, CLI icon-set work, and component icon slots. None owns the React Native platform's icon or drawing contracts. Sibling records: AST-130 (spec(AST-130): React Native platform: System modules #12553) owns the platform info module that reports named features.Decision
Five core contracts, in every binary:
Iconresolves a name in this order: a theme entry (assetNameimage orsystemNamesymbol), an app-registered image, the system symbol under the defaultplatformicon source (SF Symbols throughAstryxSymbolViewon iOS), then the shared drawn glyph onAstryxVectorView. Built-in names are core's; others are namespaced.IconandVector, the public faces (FR1, FR3, FR7).AstryxIcons.prefetchwarms remote masks and always resolves a result.groupstoday); renderers read every input safely and reportunreadable,unsupported, ortoo-deep.AstryxVectorInfolists the scene features a binary reads (FR6, FR8).spec:AST-140/FR5sets, and the group grows by named features. Native code uses public platform API.Who uses it
AstryxSymbolViewIconon iOS for every built-in name with an SF Symbol under the default icon source, and for a theme'ssystemNameentries, and so every component that renders an Icon;PlatformSymbolAstryxVectorViewIconfor a name no system symbol or defined icon draws, and so every component that renders an Icon (Button,IconButton,Badge,Banner,TabBar,TabList,BarButton,DropdownMenu,Item,SearchField,Table, …);Vector, and through itAreaChart,BarChart,LineChart,DonutChart, andSparklineAstryxVectorInfoVector, and through it the five chartsAstryxIconViewIconfor an icon the app registers as an image or a theme names withassetName, and so every component that renders such an IconAstryxIconsAstryxProvider, and soAstryxAppRoot: it prefetches the active theme's image iconsEcosystem comparison (context for "Why this exists"; not part of the record)
AstryxSymbolViewAstryxVectorView,AstryxVectorInfoAstryxIconView,AstryxIconsImagetints a mask and caches decoded images. expo-image adds disk and memory caches, prefetch, tint, and transitions. react-native-vector-icons and @expo/vector-icons draw icon fonts as text, synchronously and tinted.Imageand expo-image load each source asynchronously, so a menu's image icons fill in after the rows. An icon font fixes the stroke weight and glyph set at build time. Astryx needs theme image masks in the first frame and a prefetch that resolves a result.Rejected alternatives
Each decision in the record states its chosen direction and its reason.
Claim scope and non-goals
The record governs the five native contracts behind
IconandVector, plus the library rules they depend on (name resolution, the icon source, mirroring, Bold Text, Reduce Motion); its Non-goals section keeps only the template's two standing lines. TheIcon,Vector, and chart component contracts stay with their own records, and icon sets and theme variants withspec:AST-084andspec:AST-087. Drawn glyphs as the default is OQ1.Evidence and implementation relationship
The implementation lives in the React Native package's platform layer, with the mapping rules in its library layer. No public evidence links. The record stays valid without them.
Writing rubric results
proposes,decided,previously,a port of, andnowfinds nothing. Every requirement is in the record's own words, not taken from source comments../testingdoubles, shared conformance cases, Simulator, emulator, accessibility-hierarchy checks, UI-thread frame checks).spec:AST-112FR ids.FR4 gap:lines (no Android system icons, againstspec:AST-082/FR17; the library's own SF Symbol table instead ofNATIVE_ICON_DEFAULTS).Scope
Components: React Native platform: AstryxIconView, AstryxIcons, AstryxSymbolView, AstryxVectorView, AstryxVectorInfo
Validation
pnpm check:knowledge(run asnode scripts/check-knowledge.mjs): "Knowledge templates and records are aligned.", no error or warning for this record.--checkpasses for the record.git diff --check origin/main: clean.pnpm specs:forwas not run: no install in this checkout.Follow-up: claims moved from
spec:AST-112Cites
spec:AST-112FR5 alone for its internal native views; #13029 moves FR21 out ofspec:AST-112.